Bug 8853: Suppress links in basketgroups list
authorMathieu Saby <mathieu.saby@univ-rennes2.fr>
Sat, 9 Mar 2013 15:15:19 +0000 (16:15 +0100)
committerJared Camins-Esakov <jcamins@cpbibliography.com>
Wed, 13 Mar 2013 12:02:34 +0000 (08:02 -0400)
In the table listing all closed basketgroups, clicking the name of a
basketgroup reopen it. To edit an open basketgroup or reopen a closed
basketgroup, there are specific buttons in "Action" column. So the link
around basketgroup name is an UX problem. This patch suppress the link
around basketgroup name, in both "closed" and "open" tab.

To test :
1. create some closed and open basketgroups
2. check links are not showing anymore

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt

index d8be02a..b0a7a92 100644 (file)
@@ -275,11 +275,11 @@ function yuiToolbar() {
                        [% FOREACH basketgroup IN basketgroups %]
                                [% UNLESS ( basketgroup.closed ) %]
                                        <tr>
-                                               <td><a href="/cgi-bin/koha/acqui/basketgroup.pl?op=add&amp;booksellerid=[% basketgroup.booksellerid %]&amp;basketgroupid=[% basketgroup.id %]">[% IF ( basketgroup.name ) %]
+                                               <td>[% IF ( basketgroup.name ) %]
                                                                                                        [% basketgroup.name %]
                                                                                                [% ELSE %]
                                                                                                        Basket group no. [% basketgroup.id %]
-                                                                                               [% END %]</a>
+                                                                                               [% END %]
                                                </td>
                                                        <td>
                               <span>
@@ -306,11 +306,11 @@ function yuiToolbar() {
                                [% IF ( basketgroup.closed ) %]
                                <tr>
                                <td>
-                    <a href="/cgi-bin/koha/acqui/basketgroup.pl?op=reopen&amp;booksellerid=[% basketgroup.booksellerid %]&amp;basketgroupid=[% basketgroup.id %]">[% IF ( basketgroup.name ) %]
+                                     [% IF ( basketgroup.name ) %]
                                                                                        [% basketgroup.name %]
                                                                                [% ELSE %]
                                                                                        Basket group no. [% basketgroup.id %]
-                                                                               [% END %]</a>
+                                                                               [% END %]
                                        </td>
                                        <td>
                                                        <form action="/cgi-bin/koha/acqui/basketgroup.pl" method="get"><input type="hidden" name="op" value="reopen" /><input type="hidden" name="booksellerid" value="[% basketgroup.booksellerid %]" /><input type="hidden" name="basketgroupid" value="[% basketgroup.id %]" /><input type="submit" value="Reopen" /></form>