ACPICA: Abort downward walk on temporary node detection.
authorBob Moore <robert.moore@intel.com>
Fri, 2 Feb 2007 16:48:21 +0000 (19:48 +0300)
committerLen Brown <len.brown@intel.com>
Sat, 3 Feb 2007 02:14:28 +0000 (21:14 -0500)
Enhancement to code that ignores temporary  namespace nodes

Signed-off-by: Alexey Starikovskiy <alexey.y.starikovskiy@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/acpi/namespace/nswalk.c

index c6619d8..bccf27d 100644 (file)
@@ -194,24 +194,28 @@ acpi_ns_walk_namespace(acpi_object_type type,
                                          child_node);
                if (child_node) {
 
-                       /* Found node, Get the type if we are not searching for ANY */
+                       /* Found next child, get the type if we are not searching for ANY */
 
                        if (type != ACPI_TYPE_ANY) {
                                child_type = child_node->type;
                        }
 
                        /*
-                        * 1) Type must match
-                        * 2) Permanent namespace nodes are OK
-                        * 3) Ignore temporary nodes unless told otherwise. Typically,
-                        *    the temporary nodes can cause a race condition where they can
-                        *    be deleted during the execution of the user function. Only the
-                        *    debugger namespace dump will examine the temporary nodes.
+                        * Ignore all temporary namespace nodes (created during control
+                        * method execution) unless told otherwise. These temporary nodes
+                        * can cause a race condition because they can be deleted during the
+                        * execution of the user function (if the namespace is unlocked before
+                        * invocation of the user function.) Only the debugger namespace dump
+                        * will examine the temporary nodes.
                         */
-                       if ((child_type == type) &&
-                           (!(child_node->flags & ANOBJ_TEMPORARY) ||
-                            (child_node->flags & ANOBJ_TEMPORARY)
-                            && (flags & ACPI_NS_WALK_TEMP_NODES))) {
+                       if ((child_node->flags & ANOBJ_TEMPORARY) &&
+                           !(flags & ACPI_NS_WALK_TEMP_NODES)) {
+                               status = AE_CTRL_DEPTH;
+                       }
+
+                       /* Type must match requested type */
+
+                       else if (child_type == type) {
                                /*
                                 * Found a matching node, invoke the user callback function.
                                 * Unlock the namespace if flag is set.