Bug 13871: [QA Follow-up] Fix small regression on AF with branchcode in Patron Info...
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 11 May 2016 12:42:33 +0000 (14:42 +0200)
committerKyle M Hall <kyle@bywatersolutions.com>
Wed, 11 May 2016 13:02:25 +0000 (13:02 +0000)
If you enable send_patron_home_library_in_af in your sip account, you
want a separate AF field for the home branch.

Test plan:
Send a 63 (Patron Info) and verify that you have an extra AF.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested Patron Status and Patron Info.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/SIP/Sip/MsgType.pm

index 360f7fe..787449b 100644 (file)
@@ -1001,10 +1001,10 @@ sub handle_patron_info {
         if( defined( $patron_pwd ) && !$password_rc ) {
             $msg .= ' -- ' . INVALID_PW;
         }
+        $resp .= maybe_add( FID_SCREEN_MSG, $msg, $server );
         if ( $server->{account}->{send_patron_home_library_in_af} ) {
-            $msg .= ' -- ' . $patron->{branchcode};
+            $resp .= maybe_add( FID_SCREEN_MSG, $patron->{branchcode}, $server);
         }
-        $resp .= maybe_add( FID_SCREEN_MSG, $msg, $server );
         $resp .= maybe_add( FID_PRINT_LINE, $patron->print_line );
     } else {