bug 4205 remove extra 'plan by' option

There wasn't a conditional in place to stop the planning
pull down from showing a blank 'plan by' option.

This patch also makes the other 'plan by' options look
cleaner by removing the all caps.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/budgets-admin-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/budgets-admin-toolbar.inc
index f0c041c..c3ec018 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/budgets-admin-toolbar.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/budgets-admin-toolbar.inc
@@ -42,27 +42,28 @@
 
                var planning_menu = [
 
-                        { text: _("Plan by MONTHS"),
+                        { text: _("Plan by Months"),
                             url: "/cgi-bin/koha/admin/aqplan.pl?budget_period_id=<!-- TMPL_VAR NAME="budget_period_id" -->&authcat=MONTHS"
                             <!-- TMPL_UNLESS NAME="CAN_user_acquisition_planning_manage" -->,  id:'disabled' <!-- /TMPL_UNLESS  -->
                         },
 
-                        { text: _("Plan by BRANCHES"),
+                        { text: _("Plan by Branches"),
                             url: "/cgi-bin/koha/admin/aqplan.pl?budget_period_id=<!-- TMPL_VAR NAME="budget_period_id" -->&authcat=BRANCHES"
                             <!-- TMPL_UNLESS NAME="CAN_user_acquisition_planning_manage" -->,  id:'disabled' <!-- /TMPL_UNLESS  -->
                         },
 
-                        { text: _("Plan by ITEMTYPES"),
+                        { text: _("Plan by Item Types"),
                             url: "/cgi-bin/koha/admin/aqplan.pl?budget_period_id=<!-- TMPL_VAR NAME="budget_period_id" -->&authcat=ITEMTYPES"
                             <!-- TMPL_UNLESS NAME="CAN_user_acquisition_planning_manage" -->,  id:'disabled' <!-- /TMPL_UNLESS  -->
                         },
-
+           <!-- TMPL_IF NAME="authcat" -->
                 <!-- TMPL_LOOP NAME="auth_cats_loop" -->
                         { text: _("Plan by <!-- TMPL_VAR NAME="authcat" -->    "),
                             url: "/cgi-bin/koha/admin/aqplan.pl?budget_period_id=<!-- TMPL_VAR NAME="budget_period_id" -->&authcat=<!-- TMPL_VAR NAME="authcat" -->"
                             <!-- TMPL_UNLESS NAME="CAN_user_acquisition_planning_manage" -->,  id:'disabled' <!-- /TMPL_UNLESS  -->
                         },
                 <!-- /TMPL_LOOP -->
+           <!-- /TMPL_IF -->
                 ]
 
                    new YAHOO.widget.Button({