Bug 10074 - Encoding problems for installer
authorTomas Cohen Arazi <tomascohen@gmail.com>
Thu, 18 Apr 2013 19:27:03 +0000 (16:27 -0300)
committerJared Camins-Esakov <jcamins@cpbibliography.com>
Sat, 20 Apr 2013 03:07:01 +0000 (23:07 -0400)
Bug 6554 patched output_html_with_http_headers to encode utf8 data, and Templates.pm to expect utf8 data to be encoded.
The Installer page login screen outputs directly to STDOUT (InstallAuthAuth.pm does, WHICH IS WRONG!) and wasn't fixed to do the encoding first.

This patch makes it use output_html_with_http_headers and solves the problem.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
installer/InstallAuth.pm

index 0015a14..a866815 100644 (file)
@@ -394,11 +394,8 @@ sub checkauth {
         -HttpOnly => 1,
         -expires => ''
     );
-    print $query->header(
-        -type    => 'text/html; charset=utf-8',
-        -cookie  => $cookie
-      ),
-      $template->output;
+
+    output_html_with_http_headers $query, $cookie, $template->output;
     exit;
 }