merge linus into release branch
authorLen Brown <len.brown@intel.com>
Thu, 29 Jun 2006 23:57:46 +0000 (19:57 -0400)
committerLen Brown <len.brown@intel.com>
Thu, 29 Jun 2006 23:57:46 +0000 (19:57 -0400)
Conflicts:

drivers/acpi/acpi_memhotplug.c

1  2 
drivers/acpi/Kconfig
drivers/acpi/acpi_memhotplug.c

diff --combined drivers/acpi/Kconfig
@@@ -133,13 -133,6 +133,13 @@@ config ACPI_FA
          This driver adds support for ACPI fan devices, allowing user-mode 
          applications to perform basic fan control (on, off, status).
  
 +config ACPI_DOCK
 +      tristate "Dock"
 +      depends on !ACPI_IBM_DOCK
 +      default y
 +      help
 +        This driver adds support for ACPI controlled docking stations
 +
  config ACPI_PROCESSOR
        tristate "Processor"
        default y
@@@ -335,7 -328,7 +335,7 @@@ config ACPI_CONTAINE
  config ACPI_HOTPLUG_MEMORY
        tristate "Memory Hotplug"
        depends on ACPI
-       depends on MEMORY_HOTPLUG || X86_64
+       depends on MEMORY_HOTPLUG
        default n
        help
          This driver adds supports for ACPI Memory Hotplug.  This driver
@@@ -57,6 -57,7 +57,7 @@@ MODULE_LICENSE("GPL")
  
  static int acpi_memory_device_add(struct acpi_device *device);
  static int acpi_memory_device_remove(struct acpi_device *device, int type);
+ static int acpi_memory_device_start(struct acpi_device *device);
  
  static struct acpi_driver acpi_memory_device_driver = {
        .name = ACPI_MEMORY_DEVICE_DRIVER_NAME,
        .ops = {
                .add = acpi_memory_device_add,
                .remove = acpi_memory_device_remove,
+               .start = acpi_memory_device_start,
                },
  };
  
+ struct acpi_memory_info {
+       struct list_head list;
+       u64 start_addr;         /* Memory Range start physical addr */
+       u64 length;             /* Memory Range length */
+       unsigned short caching; /* memory cache attribute */
+       unsigned short write_protect;   /* memory read/write attribute */
+       unsigned int enabled:1;
+ };
  struct acpi_memory_device {
        acpi_handle handle;
        unsigned int state;     /* State of the memory device */
-       unsigned short caching; /* memory cache attribute */
-       unsigned short write_protect;   /* memory read/write attribute */
-       u64 start_addr;         /* Memory Range start physical addr */
-       u64 length;             /* Memory Range length */
+       struct list_head res_list;
  };
  
+ static acpi_status
+ acpi_memory_get_resource(struct acpi_resource *resource, void *context)
+ {
+       struct acpi_memory_device *mem_device = context;
+       struct acpi_resource_address64 address64;
+       struct acpi_memory_info *info, *new;
+       acpi_status status;
+       status = acpi_resource_to_address64(resource, &address64);
+       if (ACPI_FAILURE(status) ||
+           (address64.resource_type != ACPI_MEMORY_RANGE))
+               return AE_OK;
+       list_for_each_entry(info, &mem_device->res_list, list) {
+               /* Can we combine the resource range information? */
+               if ((info->caching == address64.info.mem.caching) &&
+                   (info->write_protect == address64.info.mem.write_protect) &&
+                   (info->start_addr + info->length == address64.minimum)) {
+                       info->length += address64.address_length;
+                       return AE_OK;
+               }
+       }
+       new = kzalloc(sizeof(struct acpi_memory_info), GFP_KERNEL);
+       if (!new)
+               return AE_ERROR;
+       INIT_LIST_HEAD(&new->list);
+       new->caching = address64.info.mem.caching;
+       new->write_protect = address64.info.mem.write_protect;
+       new->start_addr = address64.minimum;
+       new->length = address64.address_length;
+       list_add_tail(&new->list, &mem_device->res_list);
+       return AE_OK;
+ }
  static int
  acpi_memory_get_device_resources(struct acpi_memory_device *mem_device)
  {
        acpi_status status;
-       struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
-       struct acpi_resource *resource = NULL;
-       struct acpi_resource_address64 address64;
+       struct acpi_memory_info *info, *n;
  
 -      ACPI_FUNCTION_TRACE("acpi_memory_get_device_resources");
  
-       /* Get the range from the _CRS */
-       status = acpi_get_current_resources(mem_device->handle, &buffer);
-       if (ACPI_FAILURE(status))
+       status = acpi_walk_resources(mem_device->handle, METHOD_NAME__CRS,
+                                    acpi_memory_get_resource, mem_device);
+       if (ACPI_FAILURE(status)) {
+               list_for_each_entry_safe(info, n, &mem_device->res_list, list)
+                       kfree(info);
                return -EINVAL;
-       resource = (struct acpi_resource *)buffer.pointer;
-       status = acpi_resource_to_address64(resource, &address64);
-       if (ACPI_SUCCESS(status)) {
-               if (address64.resource_type == ACPI_MEMORY_RANGE) {
-                       /* Populate the structure */
-                       mem_device->caching = address64.info.mem.caching;
-                       mem_device->write_protect =
-                           address64.info.mem.write_protect;
-                       mem_device->start_addr = address64.minimum;
-                       mem_device->length = address64.address_length;
-               }
        }
  
-       acpi_os_free(buffer.pointer);
        return 0;
  }
  
@@@ -117,21 -150,23 +149,21 @@@ acpi_memory_get_device(acpi_handle hand
        struct acpi_device *device = NULL;
        struct acpi_device *pdevice = NULL;
  
 -      ACPI_FUNCTION_TRACE("acpi_memory_get_device");
  
        if (!acpi_bus_get_device(handle, &device) && device)
                goto end;
  
        status = acpi_get_parent(handle, &phandle);
        if (ACPI_FAILURE(status)) {
 -              ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Error in acpi_get_parent\n"));
 -              return_VALUE(-EINVAL);
 +              ACPI_EXCEPTION((AE_INFO, status, "Cannot find acpi parent"));
 +              return -EINVAL;
        }
  
        /* Get the parent device */
        status = acpi_bus_get_device(phandle, &pdevice);
        if (ACPI_FAILURE(status)) {
 -              ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
 -                                "Error in acpi_bus_get_device\n"));
 -              return_VALUE(-EINVAL);
 +              ACPI_EXCEPTION((AE_INFO, status, "Cannot get acpi bus device"));
 +              return -EINVAL;
        }
  
        /*
         */
        status = acpi_bus_add(&device, pdevice, handle, ACPI_BUS_TYPE_DEVICE);
        if (ACPI_FAILURE(status)) {
 -              ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "Error in acpi_bus_add\n"));
 -              return_VALUE(-EINVAL);
 +              ACPI_EXCEPTION((AE_INFO, status, "Cannot add acpi bus"));
 +              return -EINVAL;
        }
  
        end:
        *mem_device = acpi_driver_data(device);
        if (!(*mem_device)) {
                printk(KERN_ERR "\n driver data not found");
 -              return_VALUE(-ENODEV);
 +              return -ENODEV;
        }
  
 -      return_VALUE(0);
 +      return 0;
  }
  
  static int acpi_memory_check_device(struct acpi_memory_device *mem_device)
  {
        unsigned long current_status;
  
 -      ACPI_FUNCTION_TRACE("acpi_memory_check_device");
  
        /* Get device present/absent information from the _STA */
        if (ACPI_FAILURE(acpi_evaluate_integer(mem_device->handle, "_STA",
                                               NULL, &current_status)))
 -              return_VALUE(-ENODEV);
 +              return -ENODEV;
        /*
         * Check for device status. Device should be
         * present/enabled/functioning.
        if (!((current_status & ACPI_MEMORY_STA_PRESENT)
              && (current_status & ACPI_MEMORY_STA_ENABLED)
              && (current_status & ACPI_MEMORY_STA_FUNCTIONAL)))
 -              return_VALUE(-ENODEV);
 +              return -ENODEV;
  
 -      return_VALUE(0);
 +      return 0;
  }
  
  static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
  {
-       int result;
+       int result, num_enabled = 0;
+       struct acpi_memory_info *info;
+       int node;
  
 -      ACPI_FUNCTION_TRACE("acpi_memory_enable_device");
  
        /* Get the range from the _CRS */
        result = acpi_memory_get_device_resources(mem_device);
        if (result) {
 -              ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
 -                                "\nget_device_resources failed\n"));
 +              printk(KERN_ERR PREFIX "get_device_resources failed\n");
                mem_device->state = MEMORY_INVALID_STATE;
                return result;
        }
  
+       node = acpi_get_node(mem_device->handle);
        /*
         * Tell the VM there is more memory here...
         * Note: Assume that this function returns zero on success
+        * We don't have memory-hot-add rollback function,now.
+        * (i.e. memory-hot-remove function)
         */
-       result = add_memory(mem_device->start_addr, mem_device->length);
-       if (result) {
-               printk(KERN_ERR PREFIX "add_memory failed\n");
+       list_for_each_entry(info, &mem_device->res_list, list) {
+               u64 start_pfn, end_pfn;
+               start_pfn = info->start_addr >> PAGE_SHIFT;
+               end_pfn = (info->start_addr + info->length - 1) >> PAGE_SHIFT;
+               if (pfn_valid(start_pfn) || pfn_valid(end_pfn)) {
+                       /* already enabled. try next area */
+                       num_enabled++;
+                       continue;
+               }
+               result = add_memory(node, info->start_addr, info->length);
+               if (result)
+                       continue;
+               info->enabled = 1;
+               num_enabled++;
+       }
+       if (!num_enabled) {
+               ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "\nadd_memory failed\n"));
                mem_device->state = MEMORY_INVALID_STATE;
-               return result;
+               return -EINVAL;
        }
  
        return result;
@@@ -209,6 -269,7 +263,6 @@@ static int acpi_memory_powerdown_device
        union acpi_object arg;
        unsigned long current_status;
  
 -      ACPI_FUNCTION_TRACE("acpi_memory_powerdown_device");
  
        /* Issue the _EJ0 command */
        arg_list.count = 1;
                                      "_EJ0", &arg_list, NULL);
        /* Return on _EJ0 failure */
        if (ACPI_FAILURE(status)) {
 -              ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "_EJ0 failed.\n"));
 -              return_VALUE(-ENODEV);
 +              ACPI_EXCEPTION((AE_INFO, status, "_EJ0 failed"));
 +              return -ENODEV;
        }
  
        /* Evalute _STA to check if the device is disabled */
        status = acpi_evaluate_integer(mem_device->handle, "_STA",
                                       NULL, &current_status);
        if (ACPI_FAILURE(status))
 -              return_VALUE(-ENODEV);
 +              return -ENODEV;
  
        /* Check for device status.  Device should be disabled */
        if (current_status & ACPI_MEMORY_STA_ENABLED)
 -              return_VALUE(-EINVAL);
 +              return -EINVAL;
  
 -      return_VALUE(0);
 +      return 0;
  }
  
  static int acpi_memory_disable_device(struct acpi_memory_device *mem_device)
  {
        int result;
-       u64 start = mem_device->start_addr;
-       u64 len = mem_device->length;
+       struct acpi_memory_info *info, *n;
  
 -      ACPI_FUNCTION_TRACE("acpi_memory_disable_device");
  
        /*
         * Ask the VM to offline this memory range.
         * Note: Assume that this function returns zero on success
         */
-       result = remove_memory(start, len);
-       if (result)
-               return result;
+       list_for_each_entry_safe(info, n, &mem_device->res_list, list) {
+               if (info->enabled) {
+                       result = remove_memory(info->start_addr, info->length);
+                       if (result)
+                               return result;
+               }
+               kfree(info);
+       }
  
        /* Power-off and eject the device */
        result = acpi_memory_powerdown_device(mem_device);
        if (result) {
 -              ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
 -                                "Device Power Down failed.\n"));
                /* Set the status of the device to invalid */
                mem_device->state = MEMORY_INVALID_STATE;
                return result;
@@@ -268,6 -336,7 +326,6 @@@ static void acpi_memory_device_notify(a
        struct acpi_memory_device *mem_device;
        struct acpi_device *device;
  
 -      ACPI_FUNCTION_TRACE("acpi_memory_device_notify");
  
        switch (event) {
        case ACPI_NOTIFY_BUS_CHECK:
                        ACPI_DEBUG_PRINT((ACPI_DB_INFO,
                                          "\nReceived DEVICE CHECK notification for device\n"));
                if (acpi_memory_get_device(handle, &mem_device)) {
 -                      ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
 -                                        "Error in finding driver data\n"));
 -                      return_VOID;
 +                      printk(KERN_ERR PREFIX "Cannot find driver data\n");
 +                      return;
                }
  
                if (!acpi_memory_check_device(mem_device)) {
                        if (acpi_memory_enable_device(mem_device))
 -                              ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
 -                                                "Error in acpi_memory_enable_device\n"));
 +                              printk(KERN_ERR PREFIX
 +                                          "Cannot enable memory device\n");
                }
                break;
        case ACPI_NOTIFY_EJECT_REQUEST:
                                  "\nReceived EJECT REQUEST notification for device\n"));
  
                if (acpi_bus_get_device(handle, &device)) {
 -                      ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
 -                                        "Device doesn't exist\n"));
 +                      printk(KERN_ERR PREFIX "Device doesn't exist\n");
                        break;
                }
                mem_device = acpi_driver_data(device);
                if (!mem_device) {
 -                      ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
 -                                        "Driver Data is NULL\n"));
 +                      printk(KERN_ERR PREFIX "Driver Data is NULL\n");
                        break;
                }
  
                 *      with generic sysfs driver
                 */
                if (acpi_memory_disable_device(mem_device))
 -                      ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
 -                                        "Error in acpi_memory_disable_device\n"));
 +                      printk(KERN_ERR PREFIX
 +                                  "Disable memory device\n");
                /*
                 * TBD: Invoke acpi_bus_remove to cleanup data structures
                 */
                break;
        }
  
 -      return_VOID;
 +      return;
  }
  
  static int acpi_memory_device_add(struct acpi_device *device)
        int result;
        struct acpi_memory_device *mem_device = NULL;
  
 -      ACPI_FUNCTION_TRACE("acpi_memory_device_add");
  
        if (!device)
 -              return_VALUE(-EINVAL);
 +              return -EINVAL;
  
        mem_device = kmalloc(sizeof(struct acpi_memory_device), GFP_KERNEL);
        if (!mem_device)
 -              return_VALUE(-ENOMEM);
 +              return -ENOMEM;
        memset(mem_device, 0, sizeof(struct acpi_memory_device));
  
+       INIT_LIST_HEAD(&mem_device->res_list);
        mem_device->handle = device->handle;
        sprintf(acpi_device_name(device), "%s", ACPI_MEMORY_DEVICE_NAME);
        sprintf(acpi_device_class(device), "%s", ACPI_MEMORY_DEVICE_CLASS);
        result = acpi_memory_get_device_resources(mem_device);
        if (result) {
                kfree(mem_device);
 -              return_VALUE(result);
 +              return result;
        }
  
        /* Set the device state */
  
        printk(KERN_INFO "%s \n", acpi_device_name(device));
  
 -      return_VALUE(result);
 +      return result;
  }
  
  static int acpi_memory_device_remove(struct acpi_device *device, int type)
  {
        struct acpi_memory_device *mem_device = NULL;
  
 -      ACPI_FUNCTION_TRACE("acpi_memory_device_remove");
  
        if (!device || !acpi_driver_data(device))
 -              return_VALUE(-EINVAL);
 +              return -EINVAL;
  
        mem_device = (struct acpi_memory_device *)acpi_driver_data(device);
        kfree(mem_device);
  
 -      return_VALUE(0);
 +      return 0;
  }
  
 -      ACPI_FUNCTION_TRACE("acpi_memory_device_start");
 -
+ static int acpi_memory_device_start (struct acpi_device *device)
+ {
+       struct acpi_memory_device *mem_device;
+       int result = 0;
 -      return_VALUE(result);
+       mem_device = acpi_driver_data(device);
+       if (!acpi_memory_check_device(mem_device)) {
+               /* call add_memory func */
+               result = acpi_memory_enable_device(mem_device);
+               if (result)
+                       ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
+                               "Error in acpi_memory_enable_device\n"));
+       }
++      return result;
+ }
  /*
   * Helper function to check for memory device
   */
@@@ -383,15 -477,16 +459,15 @@@ static acpi_status is_memory_device(acp
        struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL };
        struct acpi_device_info *info;
  
 -      ACPI_FUNCTION_TRACE("is_memory_device");
  
        status = acpi_get_object_info(handle, &buffer);
        if (ACPI_FAILURE(status))
 -              return_ACPI_STATUS(AE_ERROR);
 +              return status;
  
        info = buffer.pointer;
        if (!(info->valid & ACPI_VALID_HID)) {
                acpi_os_free(buffer.pointer);
 -              return_ACPI_STATUS(AE_ERROR);
 +              return AE_ERROR;
        }
  
        hardware_id = info->hardware_id.value;
                status = AE_ERROR;
  
        acpi_os_free(buffer.pointer);
 -      return_ACPI_STATUS(status);
 +      return status;
  }
  
  static acpi_status
@@@ -409,17 -504,21 +485,17 @@@ acpi_memory_register_notify_handler(acp
  {
        acpi_status status;
  
 -      ACPI_FUNCTION_TRACE("acpi_memory_register_notify_handler");
  
        status = is_memory_device(handle);
 -      if (ACPI_FAILURE(status))
 -              return_ACPI_STATUS(AE_OK);      /* continue */
 +      if (ACPI_FAILURE(status)){
 +              ACPI_EXCEPTION((AE_INFO, status, "handle is no memory device"));
 +              return AE_OK;   /* continue */
 +      }
  
        status = acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY,
                                             acpi_memory_device_notify, NULL);
 -      if (ACPI_FAILURE(status)) {
 -              ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
 -                                "Error installing notify handler\n"));
 -              return_ACPI_STATUS(AE_OK);      /* continue */
 -      }
 -
 -      return_ACPI_STATUS(status);
 +      /* continue */
 +      return AE_OK;
  }
  
  static acpi_status
@@@ -428,18 -527,22 +504,18 @@@ acpi_memory_deregister_notify_handler(a
  {
        acpi_status status;
  
 -      ACPI_FUNCTION_TRACE("acpi_memory_deregister_notify_handler");
  
        status = is_memory_device(handle);
 -      if (ACPI_FAILURE(status))
 -              return_ACPI_STATUS(AE_OK);      /* continue */
 +      if (ACPI_FAILURE(status)){
 +              ACPI_EXCEPTION((AE_INFO, status, "handle is no memory device"));
 +              return AE_OK;   /* continue */
 +      }
  
        status = acpi_remove_notify_handler(handle,
                                            ACPI_SYSTEM_NOTIFY,
                                            acpi_memory_device_notify);
 -      if (ACPI_FAILURE(status)) {
 -              ACPI_DEBUG_PRINT((ACPI_DB_ERROR,
 -                                "Error removing notify handler\n"));
 -              return_ACPI_STATUS(AE_OK);      /* continue */
 -      }
  
 -      return_ACPI_STATUS(status);
 +      return AE_OK;   /* continue */
  }
  
  static int __init acpi_memory_device_init(void)
        int result;
        acpi_status status;
  
 -      ACPI_FUNCTION_TRACE("acpi_memory_device_init");
  
        result = acpi_bus_register_driver(&acpi_memory_device_driver);
  
        if (result < 0)
 -              return_VALUE(-ENODEV);
 +              return -ENODEV;
  
        status = acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
                                     ACPI_UINT32_MAX,
                                     NULL, NULL);
  
        if (ACPI_FAILURE(status)) {
 -              ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "walk_namespace failed\n"));
 +              ACPI_EXCEPTION((AE_INFO, status, "walk_namespace failed"));
                acpi_bus_unregister_driver(&acpi_memory_device_driver);
 -              return_VALUE(-ENODEV);
 +              return -ENODEV;
        }
  
 -      return_VALUE(0);
 +      return 0;
  }
  
  static void __exit acpi_memory_device_exit(void)
  {
        acpi_status status;
  
 -      ACPI_FUNCTION_TRACE("acpi_memory_device_exit");
  
        /*
         * Adding this to un-install notification handlers for all the device
                                     NULL, NULL);
  
        if (ACPI_FAILURE(status))
 -              ACPI_DEBUG_PRINT((ACPI_DB_ERROR, "walk_namespace failed\n"));
 +              ACPI_EXCEPTION((AE_INFO, status, "walk_namespace failed"));
  
        acpi_bus_unregister_driver(&acpi_memory_device_driver);
  
 -      return_VOID;
 +      return;
  }
  
  module_init(acpi_memory_device_init);