split ifconfig out and return resonable status

diff --git a/lib/PXElator/network.pm b/lib/PXElator/network.pm
index 49f9cd1..d97a0d8 100644 (file)
--- a/lib/PXElator/network.pm
+++ b/lib/PXElator/network.pm
@@ -7,6 +7,11 @@ use File::Slurp;
 
 use server;
 
+sub ifconfig {
+       my $dev = shift;
+       `/sbin/ifconfig $dev`
+}
+
 sub tap {
 
        my $interfaces = read_file '/etc/network/interfaces';
@@ -28,9 +33,8 @@ sub tap {
 
        }
 
-       `/sbin/ifconfig tap0 2>/dev/null` =~ m{UP} || system "sudo ifup tap0";
-
-       1;
+       ifconfig('tap0') =~ m{UP}               &&      return 'up';
+       system("sudo ifup tap0") == 0   &&      return 'started';
 }
 
 1;

diff --git a/lib/PXElator/t/network.t b/lib/PXElator/t/network.t
index d74a5b7..8db5204 100755 (executable)
--- a/lib/PXElator/t/network.t
+++ b/lib/PXElator/t/network.t
@@ -9,5 +9,6 @@ use Data::Dump qw/dump/;
 
 use_ok 'network';
 
-ok( network::tap(), 'tap' );
+ok( my $status = network::tap(), 'tap' );
+diag $status;