Bug 17879: Use image filename if no image name is entered
authorAleisha Amohia <aleishaamohia@hotmail.com>
Tue, 10 Jan 2017 22:20:40 +0000 (22:20 +0000)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 13 Jan 2017 11:46:08 +0000 (11:46 +0000)
This patch changes the code to use the filename of the uploaded image if
no specific image name is entered.

To test:
1) Go to Tools -> Patron card creator -> Manage images
2) Upload an image and leave the image name field empty
3) Notice this works and 'Name' is left empty.
4) Apply patch and refresh page
5) Upload an image and leave the image name field empty
6) Notice the image name is given the filename so that 'Name' is no
longer empty.

Sponsored-by: Catalyst IT
Signed-off-by: Claire Gravely <claire_gravely@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
patroncards/image-manage.pl

index 78f0463..ed0302c 100755 (executable)
@@ -26,8 +26,8 @@ my ($template, $loggedinuser, $cookie) = get_template_and_user({
                     debug               => 0,
                     });
 
-my $image_name = $cgi->param('image_name') || '';
 my $file_name = $cgi->param('uploadfile') || '';
+my $image_name = $cgi->param('image_name') || $file_name;
 my $upload_file = $cgi->upload('uploadfile') || '';
 my $op = $cgi->param('op') || 'none';
 my @image_ids = $cgi->multi_param('image_id') if $cgi->param('image_id');