Bug 21596: (follow-up) Handle updated_on
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 25 Oct 2018 13:24:46 +0000 (10:24 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Thu, 25 Oct 2018 15:18:32 +0000 (15:18 +0000)
Default value should only used if not exist.
We got a failing test with the previous patch:
 #   Failed test 'borrowers.updated_on should have been kept to what we set on creating'
 #   at t/db_dependent/Patrons.t line 78.
 #          got: '1'
 #     expected: '0'

Test plan:
prove -r t/Auth_with_shibboleth.t t/db_dependent/Patrons.t t/db_dependent/Koha/Patron*

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Koha/Patron.pm

index ec13bb0..c3ea18f 100644 (file)
@@ -200,7 +200,7 @@ sub store {
 
             if ( defined $self->updated_on and not $self->updated_on ) {
                 $self->updated_on(undef);
-            } else {
+            } elsif ( not $self->updated_on ) {
                 # This is bad we should use columns_info instead
                 # But it will avoid unecessary processing
                 $self->updated_on(\"current_timestamp");