Bug 13019 [QA Followup] - Allow chaining

By returning the object itself instead of a boolean, we can chain
methods together while retaining the exact same functionality.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

diff --git a/Koha/Object.pm b/Koha/Object.pm
index bc2746f..a77eb5c 100644 (file)
--- a/Koha/Object.pm
+++ b/Koha/Object.pm
@@ -106,7 +106,7 @@ Returns:
 sub store {
     my ($self) = @_;
 
-    return $self->_result()->update_or_insert() ? 1 : 0;
+    return $self->_result()->update_or_insert() ? $self : undef;
 }
 
 =head3 $object->in_storage();
@@ -190,7 +190,7 @@ sub set {
         }
     }
 
-    return $self->_result()->set_columns($properties) ? 1 : undef;
+    return $self->_result()->set_columns($properties) ? $self : undef;
 }
 
 =head3 $object->id();

diff --git a/Koha/Objects.pm b/Koha/Objects.pm
index 5413fb6..6b3100a 100644 (file)
--- a/Koha/Objects.pm
+++ b/Koha/Objects.pm
@@ -80,6 +80,8 @@ my $object = Koha::Objects->find( { keypart1 => $keypart1, keypart2 => $keypart2
 sub find {
     my ( $self, $id ) = @_;
 
+    return unless $id;
+
     my $result = $self->_resultset()->find($id);
 
     my $object = $self->object_class()->_new_from_dbic( $result );