Bug 5549 : fixed non-cloned date object in Add date for calendar, also removed erouno...
authorElliott Davis <tdavis@uttyler.edu>
Mon, 19 Mar 2012 21:56:44 +0000 (16:56 -0500)
committerChris Cormack <chrisc@catalyst.net.nz>
Tue, 20 Mar 2012 00:41:49 +0000 (13:41 +1300)
C4/Circulation.pm
Koha/Calendar.pm

index 6a9affa..d2aa9b6 100644 (file)
@@ -996,12 +996,12 @@ sub AddIssue {
                # check if we just renew the issue.
                #
                if ($actualissue->{borrowernumber} eq $borrower->{'borrowernumber'}) {
-                       $datedue = AddRenewal(
-                               $borrower->{'borrowernumber'},
-                               $item->{'itemnumber'},
-                               $branch,
-                               $datedue,
-                $issuedate, # here interpreted as the renewal date
+                   $datedue = AddRenewal(
+                       $borrower->{'borrowernumber'},
+                       $item->{'itemnumber'},
+                       $branch,
+                       $datedue,
+                       $issuedate, # here interpreted as the renewal date
                        );
                }
                else {
@@ -1016,7 +1016,6 @@ sub AddIssue {
                        }
 
             MoveReserve( $item->{'itemnumber'}, $borrower->{'borrowernumber'}, $cancelreserve );
-
                        # Starting process for transfer job (checking transfert and validate it if we have one)
             my ($datesent) = GetTransfers($item->{'itemnumber'});
             if ($datesent) {
index a3ad60c..1e7299c 100644 (file)
@@ -83,7 +83,8 @@ sub _init {
 }
 
 sub addDate {
-    my ( $self, $base_date, $add_duration, $unit ) = @_;
+    my ( $self, $startdate, $add_duration, $unit ) = @_;
+    my $base_date = $startdate->clone();
     if ( ref $add_duration ne 'DateTime::Duration' ) {
         $add_duration = DateTime::Duration->new( days => $add_duration );
     }