Bug 6679 : Enable Critic tests for authorities and fixed resulting warnings

Signed-off-by: Ian <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

diff --git a/authorities/authorities.pl b/authorities/authorities.pl
index d4f1601..44387d9 100755 (executable)
--- a/authorities/authorities.pl
+++ b/authorities/authorities.pl
@@ -47,7 +47,7 @@ builds list, depending on authorised value...
 
 =cut
 
-sub build_authorized_values_list ($$$$$$$) {
+sub build_authorized_values_list {
     my ( $tag, $subfield, $value, $dbh, $authorised_values_sth,$index_tag,$index_subfield ) = @_;
 
     my @authorised_values;
@@ -321,11 +321,11 @@ Create a random value to set it into the input name
 
 =cut
 
-sub CreateKey(){
+sub CreateKey {
     return int(rand(1000000));
 }
 
-sub build_tabs ($$$$$) {
+sub build_tabs {
     my ( $template, $record, $dbh, $encoding,$input ) = @_;
 
     # fill arrays
@@ -499,7 +499,7 @@ sub build_tabs ($$$$$) {
 }
 
 
-sub build_hidden_data () {
+sub build_hidden_data {
     # build hidden data =>
     # we store everything, even if we show only requested subfields.
 

diff --git a/authorities/detail.pl b/authorities/detail.pl
index 57e0737..d4f2c67 100755 (executable)
--- a/authorities/detail.pl
+++ b/authorities/detail.pl
@@ -50,7 +50,7 @@ use C4::Koha;
 
 our ($tagslib);
 
-sub build_tabs ($$$$$) {
+sub build_tabs {
     my ( $template, $record, $dbh, $encoding,$input ) = @_;
 
     # fill arrays

diff --git a/t/00-testcritic.t b/t/00-testcritic.t
index bc7a3cd..19e53fb 100755 (executable)
--- a/t/00-testcritic.t
+++ b/t/00-testcritic.t
@@ -16,7 +16,7 @@ my @all_koha_dirs = qw( acqui admin authorities basket C4 catalogue cataloguing
 labels members misc offline_circ opac patroncards reports reserve reviews rotating_collections
 serials sms suggestion t tags test tools virtualshelves);
 
-my @dirs = qw( acqui admin basket circ debian errors offline_circ reserve reviews rotating_collections
+my @dirs = qw( acqui admin authorities basket circ debian errors offline_circ reserve reviews rotating_collections
 serials sms virtualshelves );
 
 if ( not $ENV{TEST_QA} ) {