Bug 10664 [QA Followup] - fix error in overdue_notices.pl if there is no active currency
authorKyle M Hall <kyle@bywatersolutions.com>
Fri, 16 Aug 2013 11:21:10 +0000 (07:21 -0400)
committerGalen Charlton <gmc@esilibrary.com>
Fri, 16 Aug 2013 14:39:02 +0000 (14:39 +0000)
Fixes the following koha-qa.pl error:
 FAIL   misc/cronjobs/overdue_notices.pl
    OK     pod
    OK     forbidden patterns
    OK     valid
    FAIL   critic
               # Variables::ProhibitConditionalDeclarations:

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
misc/cronjobs/overdue_notices.pl

index 04ccf5a..0f263c4 100755 (executable)
@@ -689,7 +689,8 @@ sub parse_letter {
     }
 
     my $currencies = GetCurrency();
-    my $currency_format = $currencies->{currency} if defined($currencies);
+    my $currency_format;
+    $currency_format = $currencies->{currency} if defined($currencies);
 
     my @item_tables;
     if ( my $i = $params->{'items'} ) {