Replaced expressions of the form "$x = $x <op> $y" with "$x <op>= $y".

Thus, $x = $x+2 becomes $x += 2, and so forth.

diff --git a/C4/Accounts.pm b/C4/Accounts.pm
index ac7dcc5..ec4265a 100755 (executable)
--- a/C4/Accounts.pm
+++ b/C4/Accounts.pm
@@ -132,8 +132,7 @@ sub reconcileaccount {
     $line= $data->{'accountno'}." ".$data->{'date'}." ".$data->{'accounttype'}." ";
     my $title = $itemdata->{'title'};
     if (length($title) > 15 ) {$title = substr($title,0,15);}
-    $line= $line.$itemdata->{'barcode'}." $title ".$data->{'description'};
-                               # FIXME - .=
+    $line .= $itemdata->{'barcode'}." $title ".$data->{'description'};
     $line = fmtstr($env,$line,"L65")." ".fmtdec($env,$amount,"52");
     push @accountlines,$line;
     $i++;
@@ -173,8 +172,7 @@ sub recordpayment{
   while (($accdata=$sth->fetchrow_hashref) and ($amountleft>0)){
      if ($accdata->{'amountoutstanding'} < $amountleft) {
         $newamtos = 0;
-       $amountleft = $amountleft - $accdata->{'amountoutstanding'};
-                               # FIXME - -=
+       $amountleft -= $accdata->{'amountoutstanding'};
      }  else {
         $newamtos = $accdata->{'amountoutstanding'} - $amountleft;
        $amountleft = 0;

diff --git a/C4/Accounts2.pm b/C4/Accounts2.pm
index 56564f4..40e81ae 100755 (executable)
--- a/C4/Accounts2.pm
+++ b/C4/Accounts2.pm
@@ -98,8 +98,7 @@ sub recordpayment{
   while (($accdata=$sth->fetchrow_hashref) and ($amountleft>0)){
      if ($accdata->{'amountoutstanding'} < $amountleft) {
         $newamtos = 0;
-       $amountleft = $amountleft - $accdata->{'amountoutstanding'};
-                               # FIXME - -=
+       $amountleft -= $accdata->{'amountoutstanding'};
      }  else {
         $newamtos = $accdata->{'amountoutstanding'} - $amountleft;
        $amountleft = 0;
@@ -375,8 +374,7 @@ sub fixcredit{
     $sth->finish;
     if ($accdata->{'amountoutstanding'} < $amountleft) {
         $newamtos = 0;
-       $amountleft = $amountleft - $accdata->{'amountoutstanding'};
-                               # FIXME - -=
+       $amountleft -= $accdata->{'amountoutstanding'};
      }  else {
         $newamtos = $accdata->{'amountoutstanding'} - $amountleft;
        $amountleft = 0;
@@ -407,8 +405,7 @@ sub fixcredit{
   while (($accdata=$sth->fetchrow_hashref) and ($amountleft>0)){
      if ($accdata->{'amountoutstanding'} < $amountleft) {
         $newamtos = 0;
-       $amountleft = $amountleft - $accdata->{'amountoutstanding'};
-                               # FIXME - -=
+       $amountleft -= $accdata->{'amountoutstanding'};
      }  else {
         $newamtos = $accdata->{'amountoutstanding'} - $amountleft;
        $amountleft = 0;
@@ -460,8 +457,7 @@ sub refund{
   while (($accdata=$sth->fetchrow_hashref) and ($amountleft<0)){
      if ($accdata->{'amountoutstanding'} > $amountleft) {
         $newamtos = 0;
-       $amountleft = $amountleft - $accdata->{'amountoutstanding'};
-                               # FIXME - -=
+       $amountleft -= $accdata->{'amountoutstanding'};
      }  else {
         $newamtos = $accdata->{'amountoutstanding'} - $amountleft;
        $amountleft = 0;

diff --git a/C4/Acquisitions.pm b/C4/Acquisitions.pm
index 92bae36..529297a 100644 (file)
--- a/C4/Acquisitions.pm
+++ b/C4/Acquisitions.pm
@@ -822,7 +822,7 @@ or catalogueentry like '% $subject[$i]')";
 
         $sth2->execute;
         while (my $data = $sth2->fetchrow_hashref) {
-          $error = $error."<br>$data->{'catalogueentry'}";     # FIXME - .=
+          $error .= "<br>$data->{'catalogueentry'}";
         } # while
         $sth2->finish;
       } # else
@@ -1266,7 +1266,7 @@ sub curconvert {
   if ($cur==0){
     $cur=1;
   }
-  $price=$price / $cur;                # FIXME - /=
+  $price /= $cur;
   return($price);
 }
 
@@ -1578,7 +1578,7 @@ sub delitem{
   $sth->finish;
   $query="Insert into deleteditems values (";
   foreach my $temp (@data){
-    $query=$query."'$temp',";          # FIXME - .=
+    $query .= "'$temp',";
   }
   $query=~ s/\,$/\)/;
 #  print $query;
@@ -1665,7 +1665,7 @@ sub delbiblio{
     $query="Insert into deletedbiblio values (";
     foreach my $temp (@data){
       $temp=~ s/\'/\\\'/g;
-      $query=$query."'$temp',";                # FIXME - .=
+      $query .= "'$temp',";
     }
     $query=~ s/\,$/\)/;
 #   print $query;

diff --git a/C4/Biblio.pm b/C4/Biblio.pm
index 72ff0ab..16bb804 100644 (file)
--- a/C4/Biblio.pm
+++ b/C4/Biblio.pm
@@ -1,6 +1,10 @@
 package C4::Biblio;
 # $Id$
 # $Log$
+# Revision 1.21  2002/10/13 11:34:14  arensb
+# Replaced expressions of the form "$x = $x <op> $y" with "$x <op>= $y".
+# Thus, $x = $x+2 becomes $x += 2, and so forth.
+#
 # Revision 1.20  2002/10/13 08:28:32  arensb
 # Deleted unused variables.
 # Removed trailing whitespace.
@@ -1202,7 +1206,7 @@ sub OLDmodsubject {
 
         $sth2->execute;
         while (my $data = $sth2->fetchrow_hashref) {
-          $error = $error."<br>$data->{'catalogueentry'}";     # FIXME - .=
+          $error .= "<br>$data->{'catalogueentry'}";
         } # while
         $sth2->finish;
       } # else
@@ -1466,7 +1470,7 @@ sub OLDdelitem{
   $sth->finish;
   $query="Insert into deleteditems values (";
   foreach my $temp (@data){
-    $query=$query."'$temp',";          # FIXME - .=
+    $query .= "'$temp',";
   }
   $query=~ s/\,$/\)/;
 #  print $query;
@@ -1535,7 +1539,7 @@ sub OLDdelbiblio{
     $query="Insert into deletedbiblio values (";
     foreach my $temp (@data){
       $temp=~ s/\'/\\\'/g;
-      $query=$query."'$temp',";                # FIXME - .=
+      $query .= "'$temp',";
     }
     $query=~ s/\,$/\)/;
 #   print $query;

diff --git a/C4/Circulation/Circ2.pm b/C4/Circulation/Circ2.pm
index 3e1ae50..fa4bd3c 100755 (executable)
--- a/C4/Circulation/Circ2.pm
+++ b/C4/Circulation/Circ2.pm
@@ -1107,8 +1107,7 @@ sub fixaccountforlostandreturned {
            while (($accdata=$msth->fetchrow_hashref) and ($amountleft>0)){
                if ($accdata->{'amountoutstanding'} < $amountleft) {
                    $newamtos = 0;
-                   # FIXME - -=
-                   $amountleft = $amountleft - $accdata->{'amountoutstanding'};
+                   $amountleft -= $accdata->{'amountoutstanding'};
                }  else {
                    $newamtos = $accdata->{'amountoutstanding'} - $amountleft;
                    $amountleft = 0;
@@ -1569,8 +1568,7 @@ sub checkaccount  {
   $sth->execute;
   my $total=0;
   while (my $data=$sth->fetchrow_hashref){
-    # FIXME = +=
-    $total=$total+$data->{'sum(amountoutstanding)'};
+    $total += $data->{'sum(amountoutstanding)'};
   }
   $sth->finish;
   # output(1,2,"borrower owes $total");

diff --git a/C4/Circulation/Issues.pm b/C4/Circulation/Issues.pm
index 0cf7bcb..c78919f 100755 (executable)
--- a/C4/Circulation/Issues.pm
+++ b/C4/Circulation/Issues.pm
@@ -199,13 +199,13 @@ sub formatitem {
      my $dewey = $item->{'dewey'};
      $dewey =~ s/0*$//;
      $dewey =~ s/\.$//;
-     $iclass = $iclass.$dewey.$item->{'subclass'};     # FIXME - .=
+     $iclass .= $dewey.$item->{'subclass'};
    };
    my $llen = 65 - length($iclass);
    my $line = fmtstr($env,$line,"L".$llen);
                # FIXME - Use sprintf() instead of &fmtstr.
-   my $line = $line." $iclass ";               # FIXME - .=
-   my $line = $line.fmtdec($env,$charge,"22"); # FIXME - .=
+   my $line .= " $iclass ";
+   my $line .= fmtdec($env,$charge,"22");
    return $line;
 }
 
@@ -284,8 +284,7 @@ sub issueitem{
         $btsh->execute;
         my $resborrower = $btsh->fetchrow_hashref;
         my $msgtxt = chr(7)."Res for $resborrower->{'cardnumber'},";
-         $msgtxt = $msgtxt." $resborrower->{'initials'} $resborrower->{'surname'}";
-               # FIXME - .=
+         $msgtxt .= " $resborrower->{'initials'} $resborrower->{'surname'}";
          my $ans = msg_ny($env,$msgtxt,"Allow issue?");
         if ($ans eq "N") {
            # print a docket;

diff --git a/C4/Circulation/Renewals.pm b/C4/Circulation/Renewals.pm
index 65a1e16..809718d 100755 (executable)
--- a/C4/Circulation/Renewals.pm
+++ b/C4/Circulation/Renewals.pm
@@ -202,19 +202,17 @@ sub bulkrenew {
      my ($resbor,$resrec) = C4::Circulation::Main::checkreserve($env,
         $dbh,$issrec->{'itemnumber'});
      if ($resbor ne "") {
-       $line = $line."R";              # FIXME - .=
+       $line .= "R";
        $rstatuses[$x] ="R";
      } elsif ($renewstatus == 0) {
-       $line = $line."N";              # FIXME - .=
+       $line .= "N";
        $rstatuses[$x] = "N";
      } else {
-       $line = $line."Y";              # FIXME - .=
+       $line .= "Y";
        $rstatuses[$x] = "Y";
      }
-     $line = $line.fmtdec($env,$issrec->{'renewals'},"20")." ";
-                                       # FIXME - .=
-     $line = $line.$itemdata->{'barcode'}." ".$itemdata->{'itemtype'}." ".$itemdata->{'title'};
-                                       # FIXME - .=
+     $line .= fmtdec($env,$issrec->{'renewals'},"20")." ";
+     $line .= $itemdata->{'barcode'}." ".$itemdata->{'itemtype'}." ".$itemdata->{'title'};
      $items[$x] = $line;
      #debug_msg($env,$line);
      $issues[$x] = $issrec;

diff --git a/C4/Circulation/Renewals2.pm b/C4/Circulation/Renewals2.pm
index 5b41587..be3393c 100755 (executable)
--- a/C4/Circulation/Renewals2.pm
+++ b/C4/Circulation/Renewals2.pm
@@ -287,8 +287,7 @@ sub calc_charges {
     $sth2->execute;
     if (my$data2=$sth2->fetchrow_hashref) {
       my $discount = $data2->{'rentaldiscount'};
-      # FIXME - *=
-      $charge = ($charge *(100 - $discount)) / 100;
+      $charge *= (100 - $discount) / 100;
     }
     $sth2->finish;
   }

diff --git a/C4/Format.pm b/C4/Format.pm
index f7d6ed9..0bf917b 100755 (executable)
--- a/C4/Format.pm
+++ b/C4/Format.pm
@@ -213,11 +213,11 @@ sub fmtdec {
   }
   # Right-pad the decimal part to the given number of digits.
   if ($right > 0) {
-     $tempdec = $tempdec.("0"x$right); # FIXME - .=
+     $tempdec .= "0"x$right;
      $tempdec = substr($tempdec,0,$right);
-     $fnumb = $fnumb.".".$tempdec;     # FIXME - .=
+     $fnumb .= ".".$tempdec;
   }
-  return ($fnumb);     # FIXME - Shouldn't return a list.
+  return $fnumb;       # FIXME - Shouldn't return a list.
 }
 
 1;

diff --git a/C4/Input.pm b/C4/Input.pm
index 87abce1..d50cc2a 100644 (file)
--- a/C4/Input.pm
+++ b/C4/Input.pm
@@ -136,15 +136,10 @@ sub checkvalidisbn {
                 my $digit=substr($q,$i,1);
                 $c+=$digit*(10-$i);
             }
-           $c=$c%11;  # % is the modulus function
-                       # FIXME - %=
+           $c %= 11;
             ($c==10) && ($c='X');
             # FIXME - $isbngood = $c eq $checksum;
-            if ($c eq $checksum) {
-                $isbngood=1;
-            } else {
-                $isbngood=0;
-            }
+            $isbngood = $c eq $checksum;
         } else {
             # FIXME - Put "return 0 if $length($q) != 10" near the
             # top, so we don't have to indent the rest of the function

diff --git a/C4/Maintainance.pm b/C4/Maintainance.pm
index af9cca5..965db67 100644 (file)
--- a/C4/Maintainance.pm
+++ b/C4/Maintainance.pm
@@ -196,7 +196,7 @@ sub undeletebib{
     $query="Insert into biblio values (";
     foreach my $temp (@data){
       $temp=~ s/\'/\\\'/g;
-      $query=$query."'$temp',";                # FIXME - .=
+      $query .= "'$temp',";
     }
     $query=~ s/\,$/\)/;
     #   print $query;

diff --git a/C4/Output.pm b/C4/Output.pm
index 787c3a3..facf0fb 100644 (file)
--- a/C4/Output.pm
+++ b/C4/Output.pm
@@ -459,7 +459,7 @@ sub mktablerow {
       }
       $i++;
   }
-  $string=$string."</tr>\n";           # FIXME - .=
+  $string .= "</tr>\n";
   return($string);
 }
 
@@ -481,7 +481,7 @@ sub mktableft() {
 sub mkform{
   my ($action,%inputs)=@_;
   my $string="<form action=$action method=post>\n";
-  $string=$string.mktablehdr();                # FIXME - .=
+  $string .= mktablehdr();
   my $key;
   my @keys=sort keys %inputs;
 
@@ -492,8 +492,7 @@ sub mkform{
     my @data=split('\t',$value);
     #my $posn = shift(@data);
     if ($data[0] eq 'hidden'){
-      $string=$string."<input type=hidden name=$keys[$i2] value=\"$data[1]\">\n";
-                                       # FIXME - .=
+      $string .= "<input type=hidden name=$keys[$i2] value=\"$data[1]\">\n";
     } else {
       my $text;
       if ($data[0] eq 'radio') {
@@ -511,22 +510,20 @@ sub mkform{
        my $i=1;
                while ($data[$i] ne "") {
          my $val = $data[$i+1];
-         $text = $text."<option value=$data[$i]>$val";         # FIXME - .=
-         $i = $i+2;            # FIXME - +=
+         $text .= "<option value=$data[$i]>$val";
+         $i += 2;
        }
-       $text=$text."</select>";
-                               # FIXME - .=
+       $text .= "</select>";
       }
-      $string=$string.mktablerow(2,'white',$keys[$i2],$text);  # FIXME - .=
+      $string .= mktablerow(2,'white',$keys[$i2],$text);
       #@order[$posn] =mktablerow(2,'white',$keys[$i2],$text);
     }
     $i2++;
   }
   #$string=$string.join("\n",@order);
-  $string=$string.mktablerow(2,'white','<input type=submit>','<input type=reset>');
-                               # FIXME - .=
-  $string=$string.mktableft;   # FIXME - .=
-  $string=$string."</form>";   # FIXME - .=
+  $string .= mktablerow(2,'white','<input type=submit>','<input type=reset>');
+  $string .= mktableft;
+  $string .= "</form>";
 }
 
 =item mkform3
@@ -633,10 +630,10 @@ sub mkform3 {
        my $i=1;
                while ($data[$i] ne "") {
          my $val = $data[$i+1];
-         $text = $text."<option value=$data[$i]>$val";         # FIXME - .=
-         $i = $i+2;            # FIXME - Use $i += 2.
+         $text .= "<option value=$data[$i]>$val";
+         $i += 2;
        }
-       $text=$text."</select>";        # FIXME - .=
+       $text .= "</select>";
       }
 #      $string=$string.mktablerow(2,'white',$keys[$i2],$text);
       $order[$posn]=mktablerow(2,'white',$keys[$i2],$text);
@@ -644,10 +641,10 @@ sub mkform3 {
     $i2++;
   }
   my $temp=join("\n",@order);
-  $string=$string.$temp;                                       # FIXME - .=
-  $string=$string.mktablerow(1,'white','<input type=submit>'); # FIXME - .=
-  $string=$string.mktableft;                                   # FIXME - .=
-  $string=$string."</form>";                                   # FIXME - .=
+  $string .= $temp;
+  $string .= mktablerow(1,'white','<input type=submit>');
+  $string .= mktableft;
+  $string .= "</form>";
   # FIXME - A return statement, while not strictly necessary, would be nice.
 }
 
@@ -718,31 +715,25 @@ sub mkformnotable{
   my $count=@inputs;
   for (my $i=0; $i<$count; $i++){
     if ($inputs[$i][0] eq 'hidden'){
-      $string=$string."<input type=hidden name=$inputs[$i][1] value=\"$inputs[$i][2]\">\n";
-                               # FIXME - .=
+      $string .= "<input type=hidden name=$inputs[$i][1] value=\"$inputs[$i][2]\">\n";
     }
     if ($inputs[$i][0] eq 'radio') {
-      $string.="<input type=radio name=$inputs[1] value=$inputs[$i][2]>$inputs[$i][2]";
-                               # FIXME - .=
+      $string .= "<input type=radio name=$inputs[1] value=$inputs[$i][2]>$inputs[$i][2]";
     }
     if ($inputs[$i][0] eq 'text') {
-      $string.="<input type=$inputs[$i][0] name=$inputs[$i][1] value=\"$inputs[$i][2]\">";
-                               # FIXME - .=
+      $string .= "<input type=$inputs[$i][0] name=$inputs[$i][1] value=\"$inputs[$i][2]\">";
     }
     if ($inputs[$i][0] eq 'textarea') {
-        $string.="<textarea name=$inputs[$i][1] wrap=physical cols=40 rows=4>$inputs[$i][2]</textarea>";
-                               # FIXME - .=
+        $string .= "<textarea name=$inputs[$i][1] wrap=physical cols=40 rows=4>$inputs[$i][2]</textarea>";
     }
     if ($inputs[$i][0] eq 'reset'){
-      $string.="<input type=reset name=$inputs[$i][1] value=\"$inputs[$i][2]\">";
-                               # FIXME - .=
+      $string .= "<input type=reset name=$inputs[$i][1] value=\"$inputs[$i][2]\">";
     }
     if ($inputs[$i][0] eq 'submit'){
-      $string.="<input type=submit name=$inputs[$i][1] value=\"$inputs[$i][2]\">";
-                               # FIXME - .=
+      $string .= "<input type=submit name=$inputs[$i][1] value=\"$inputs[$i][2]\">";
     }
   }
-  $string=$string."</form>";   # FIXME - .=
+  $string .= "</form>";
 }
 
 =item mkform2
@@ -829,7 +820,7 @@ sub mkform2{
     #   functions
   my ($action,%inputs)=@_;
   my $string="<form action=$action method=post>\n";
-  $string=$string.mktablehdr();                # FIXME - .=
+  $string .= mktablehdr();
   my $key;
   my @order;
   while ( my ($key, $value) = each %inputs) {
@@ -838,8 +829,7 @@ sub mkform2{
     my $reqd = shift(@data);
     my $ltext = shift(@data);
     if ($data[0] eq 'hidden'){
-      $string=$string."<input type=hidden name=$key value=\"$data[1]\">\n";
-                                       # FIXME - .=
+      $string .= "<input type=hidden name=$key value=\"$data[1]\">\n";
     } else {
       my $text;
       if ($data[0] eq 'radio') {
@@ -864,26 +854,25 @@ sub mkform2{
        my $i=2;
                while ($data[$i] ne "") {
          my $val = $data[$i+1];
-                 $text = $text."<option value=\"$data[$i]\"";  # FIXME - .=
+                 $text .= "<option value=\"$data[$i]\"";
          if ($data[$i] eq $sel) {
-            $text = $text." selected";                 # FIXME - .=
+            $text .= " selected";
          }
-          $text = $text.">$val";                       # FIXME - .=
-         $i = $i+2;                                    # FIXME - +=
+          $text .= ">$val";
+          $i += 2;
        }
-       $text=$text."</select>";                        # FIXME - .=
+       $text .= "</select>";
       }
       if ($reqd eq "R") {
-        $ltext = $ltext." (Req)";                      # FIXME - .=
+        $ltext .= " (Req)";
        }
       $order[$posn] =mktablerow(2,'white',$ltext,$text);
     }
   }
-  $string=$string.join("\n",@order);                   # FIXME - .=
-  $string=$string.mktablerow(2,'white','<input type=submit>','<input type=reset>');
-                                                       # FIXME - .=
-  $string=$string.mktableft;                           # FIXME - .=
-  $string=$string."</form>";                           # FIXME - .=
+  $string .= join("\n",@order);
+  $string .= mktablerow(2,'white','<input type=submit>','<input type=reset>');
+  $string .= mktableft;
+  $string .= "</form>";
 }
 
 =item endpage

diff --git a/C4/Search.pm b/C4/Search.pm
index 5b76f03..cde818c 100755 (executable)
--- a/C4/Search.pm
+++ b/C4/Search.pm
@@ -567,8 +567,7 @@ sub KeywordSearch2 {
   biblio.biblionumber=bibliosubtitle.biblionumber and
   (((title like '$key[0]%' or title like '% $key[0]%')";
   while ($i < $count){
-    $query=$query." and (title like '$key[$i]%' or title like '% $key[$i]%')";
-                               # FIXME - .=
+    $query .= " and (title like '$key[$i]%' or title like '% $key[$i]%')";
     $i++;
   }
   $query.= ") or ((subtitle like '$key[0]%' or subtitle like '% $key[0]%')";
@@ -603,7 +602,7 @@ sub KeywordSearch2 {
     seriestitle like 'new zealand%' or seriestitle like '% new zealand %'
     or seriestitle like '% new zealand')"
   }
-  $query=$query."))";          # FIXME - .=
+  $query .= "))";
   if ($search->{'class'} ne ''){
     my @temp=split(/\|/,$search->{'class'});
     my $count=@temp;
@@ -886,22 +885,20 @@ sub CatSearch  {
         like '% $key[0]%'
                 )";
         while ($i < $count){
-           $query=$query." and (
+           $query .= " and (
           biblio.author like '$key[$i]%' or biblio.author like '% $key[$i]%' or
           additionalauthors.author like '$key[$i]%' or additionalauthors.author like '% $key[$i]%'
           )";
-                               # FIXME - .= <<EOT
            $i++;
         }
-        $query=$query.")";     # FIXME - .=
+        $query .= ")";
          if ($search->{'title'} ne ''){
           my @key=split(' ',$search->{'title'});
           my $count=@key;
            my $i=0;
           $query.= " and (((title like '$key[0]%' or title like '% $key[0]%' or title like '% $key[0]')";
             while ($i<$count){
-             $query=$query." and (title like '$key[$i]%' or title like '% $key[$i]%' or title like '% $key[$i]')";
-                               # FIXME - .=
+             $query .= " and (title like '$key[$i]%' or title like '% $key[$i]%' or title like '% $key[$i]')";
               $i++;
            }
 #          $query.=") or ((subtitle like '$key[0]%' or subtitle like '% $key[0] %' or subtitle like '% $key[0]')";
@@ -916,7 +913,7 @@ sub CatSearch  {
             for ($i=1;$i<$count;$i++){
                $query.=" and (unititle like '$key[$i]%' or unititle like '% $key[$i]%')";
             }
-           $query=$query."))";         # FIXME - .=
+           $query .= "))";
           #$query=$query. " and (title like '%$search->{'title'}%'
           #or seriestitle like '%$search->{'title'}%')";
         }
@@ -952,8 +949,7 @@ sub CatSearch  {
            where
            (((title like '$key[0]%' or title like '% $key[0]%' or title like '% $key[0]')";
            while ($i<$count){
-             $query=$query." and (title like '$key[$i]%' or title like '% $key[$i]%' or title like '% $key[$i]')";
-                                       # FIXME - .=
+             $query .= " and (title like '$key[$i]%' or title like '% $key[$i]%' or title like '% $key[$i]')";
              $i++;
            }
            $query.=") or ((subtitle like '$key[0]%' or subtitle like '% $key[0]%' or subtitle like '% $key[0]')";
@@ -968,7 +964,7 @@ sub CatSearch  {
            for ($i=1;$i<$count;$i++){
              $query.=" and (unititle like '$key[$i]%' or unititle like '% $key[$i]%')";
            }
-           $query=$query."))";         # FIXME - .=
+           $query .= "))";
           }
           if ($search->{'abstract'} ne ''){
            $query.= " and (abstract like '%$search->{'abstract'}%')";
@@ -1092,13 +1088,13 @@ sub CatSearch  {
 #print $query;
 if ($type ne 'precise' && $type ne 'subject'){
   if ($search->{'author'} ne ''){
-      $query=$query." order by biblio.author,title";   # FIXME - .=
+      $query .= " order by biblio.author,title";
   } else {
-      $query=$query." order by title";                 # FIXME - .=
+      $query .= " order by title";
   }
 } else {
   if ($type eq 'subject'){
-      $query=$query." order by subject";               # FIXME - .=
+      $query .= " order by subject";
   }
 }
 #print STDERR "$query\n";
@@ -1324,9 +1320,9 @@ sub ItemInfo {
       $dewey='';
     }
     $dewey=~ s/\.$//;
-    $class = $class.$dewey;                    # FIXME - .=
+    $class .= $dewey;
     if ($dewey ne ''){
-      $class = $class.$data->{'subclass'};     # FIXME - .=
+      $class .= $data->{'subclass'};
     }
  #   $results[$i]="$data->{'title'}\t$data->{'barcode'}\t$datedue\t$data->{'branchname'}\t$data->{'dewey'}";
     # FIXME - If $data->{'datelastseen'} is NULL, perhaps it'd be prettier
@@ -1395,20 +1391,20 @@ sub GetItems {
       my $dewey = $data->{'dewey'};
       $dewey =~ s/0+$//;
       my $line = $data->{'biblioitemnumber'}."\t".$data->{'itemtype'};
-      $line = $line."\t$data->{'classification'}\t$dewey";     # FIXME - .=
-      $line = $line."\t$data->{'subclass'}\t$data->{isbn}";    # FIXME - .=
-      $line = $line."\t$data->{'volume'}\t$data->{number}";    # FIXME - .=
+      $line .= "\t$data->{'classification'}\t$dewey";
+      $line .= "\t$data->{'subclass'}\t$data->{isbn}";
+      $line .= "\t$data->{'volume'}\t$data->{number}";
       my $isth= $dbh->prepare("select * from items where biblioitemnumber = $data->{'biblioitemnumber'}");
       $isth->execute;
       while (my $idata = $isth->fetchrow_hashref) {
         my $iline = $idata->{'barcode'}."[".$idata->{'holdingbranch'}."[";
        if ($idata->{'notforloan'} == 1) {
-         $iline = $iline."NFL ";                               # FIXME - .=
+         $iline .= "NFL ";
        }
        if ($idata->{'itemlost'} == 1) {
-         $iline = $iline."LOST ";                              # FIXME - .=
+         $iline .= "LOST ";
        }
-        $line = $line."\t$iline";                              # FIXME - .=
+        $line .= "\t$iline";
       }
       $isth->finish;
       $results[$i] = $line;
@@ -1996,7 +1992,7 @@ borrowernumber=$params->{'borrowernumber'} order by date desc,timestamp desc";
  #     }
       $acctlines[$numlines] = $data;
       $numlines++;
-      $total = $total+ $data->{'amountoutstanding'};   # FIXME - +=
+      $total += $data->{'amountoutstanding'};
    }
    $sth->finish;
    return ($numlines,\@acctlines,$total);

diff --git a/C4/Stats.pm b/C4/Stats.pm
index 3551824..9828b21 100644 (file)
--- a/C4/Stats.pm
+++ b/C4/Stats.pm
@@ -165,7 +165,7 @@ sub TotalOwing{
   my $dbh = C4::Context->dbh;
   my $query="Select sum(amountoutstanding) from accountlines";
   if ($type eq 'fine'){
-    $query=$query." where accounttype='F' or accounttype='FN'";        # FIXME - .=
+    $query .= " where accounttype='F' or accounttype='FN'";
   }
   my $sth=$dbh->prepare($query);
 #  print $query;
@@ -184,7 +184,7 @@ sub TotalPaid {
 or accounttype ='W')
   and accountlines.borrowernumber = borrowers.borrowernumber";
   if ($time eq 'today'){
-    $query=$query." and date = now()";                         # FIXME - .=
+    $query .= " and date = now()";
   } else {
     $query.=" and date='$time'";
   }

diff --git a/acqui.simple/processz3950queue b/acqui.simple/processz3950queue
index bb64540..e006419 100755 (executable)
--- a/acqui.simple/processz3950queue
+++ b/acqui.simple/processz3950queue
@@ -196,7 +196,7 @@ while (1) {
                                                $result.=$marcdata;
                                            }
                                            my $scantimerend=time();
-                                           ($numresults<$numrecords+40) ? ($numrecords=$numresults) : ($numrecords=$numrecords+40); # FIXME - +=
+                                           ($numresults<$numrecords+40) ? ($numrecords=$numresults) : ($numrecords += 40);
                                            my $elapsed=$scantimerend-$scantimerstart;
                                            if ($elapsed) {
                                                my $speed=int($numresults/$elapsed*100)/100;

diff --git a/acqui/finishreceive.pl b/acqui/finishreceive.pl
index fbfec7b..4e05ebd 100755 (executable)
--- a/acqui/finishreceive.pl
+++ b/acqui/finishreceive.pl
@@ -66,7 +66,7 @@ my $biblio = {
 }; # my $biblio
 
 if ($quantrec != 0){
-  $cost=$cost / $quantrec;             # FIXME - /=
+  $cost /= $quantrec;
 }
 
 my $gst=$input->param('gst');

diff --git a/acqui/newbasket2.pl b/acqui/newbasket2.pl
index 956f89c..75e1d93 100755 (executable)
--- a/acqui/newbasket2.pl
+++ b/acqui/newbasket2.pl
@@ -164,51 +164,51 @@ while ($i < $count2){
       my ($count,$lcount,$nacount,$fcount,$scount,$lostcount,$mending,$transit)=C4::Search::itemcount($env,$result->{'biblionumber'},$type);
       $itemcount=$count;
       if ($nacount > 0){
-        $location=$location."On Loan";         # FIXME - .=
+        $location .= "On Loan";
        if ($nacount >1 ){
-         $location=$location." ($nacount)";    # FIXME - .=
+         $location .= " ($nacount)";
          }
         $location.=" ";
       }
       if ($lcount > 0){
-         $location=$location."Levin";          # FIXME - .=
+         $location .= "Levin";
          if ($lcount >1 ){
-         $location=$location." ($lcount)";     # FIXME - .=
+         $location .= " ($lcount)";
          }
         $location.=" ";
       }
       if ($fcount > 0){
-        $location=$location."Foxton";          # FIXME - .=
+        $location .= "Foxton";
          if ($fcount >1 ){
-         $location=$location." ($fcount)";     # FIXME - .=
+         $location .= " ($fcount)";
          }
         $location.=" ";
       }
       if ($scount > 0){
-        $location=$location."Shannon";         # FIXME - .=
+        $location .= "Shannon";
          if ($scount >1 ){
-         $location=$location." ($scount)";     # FIXME - .=
+         $location .= " ($scount)";
          }
         $location.=" ";
       }
       if ($lostcount > 0){
-        $location=$location."Lost";            # FIXME - .=
+        $location .= "Lost";
          if ($lostcount >1 ){
-         $location=$location." ($lostcount)";  # FIXME - .=
+         $location .= " ($lostcount)";
          }
         $location.=" ";
       }
       if ($mending > 0){
-        $location=$location."Mending";         # FIXME - .=
+        $location .= "Mending";
          if ($mending >1 ){
-         $location=$location." ($mending)";    # FIXME - .=
+         $location .= " ($mending)";
          }
         $location.=" ";
       }
       if ($transit > 0){
-        $location=$location."In Transiit";     # FIXME - .=
+        $location .= "In Transit";
          if ($transit >1 ){
-         $location=$location." ($transit)";    # FIXME - .=
+         $location .= " ($transit)";
          }
         $location.=" ";
       }

diff --git a/deletemem.pl b/deletemem.pl
index ae60e86..d9d1b97 100755 (executable)
--- a/deletemem.pl
+++ b/deletemem.pl
@@ -83,7 +83,7 @@ sub delmember{
   $sth->finish;
   $query="Insert into deletedborrowers values (";
   foreach my $temp (@data){
-    $query=$query."'$temp',";          # FIXME - .=
+    $query .= "'$temp',";
   }
   $query=~ s/\,$/\)/;
   #  print $query;

diff --git a/memberentry.pl b/memberentry.pl
index ec95459..4a6d469 100755 (executable)
--- a/memberentry.pl
+++ b/memberentry.pl
@@ -95,8 +95,7 @@ if ($delete){
       my $temp1 = $weightings[$i];     # read weightings, left to right, 1 char at a time
       my $temp2 = substr($cardnumber,$i,1);    # sequence left to right, 1 char at a time
   #print "$temp2<br>";
-      $sum = $sum + ($temp1*$temp2);   # mult each char 1-7 by its corresponding weighting
-                                       # FIXME - +=
+      $sum += $temp1*$temp2;   # mult each char 1-7 by its corresponding weighting
       $i++;                            # increment counter
     }
     my $rem = ($sum%11);                       # remainder of sum/11 (eg. 9999999/11, remainder=2)

diff --git a/search.pl b/search.pl
index 546edec..f939530 100755 (executable)
--- a/search.pl
+++ b/search.pl
@@ -133,31 +133,31 @@ foreach my $result (@results) {
 my $search="num=20";
 my $searchdesc='';
 if ($keyword){
-    $search=$search."&keyword=$keyword";               # FIXME - .=
+    $search .= "&keyword=$keyword";
     $searchdesc.="keyword $keyword, ";
 }
 if (my $subjectitems=$query->param('subjectitems')){
-    $search=$search."&subjectitems=$subjectitems";     # FIXME - .=
+    $search .= "&subjectitems=$subjectitems";
     $searchdesc.="subject $subjectitems, ";
 }
 if ($subject){
-    $search=$search."&subject=$subject";               # FIXME - .=
+    $search .= "&subject=$subject";
     $searchdesc.="subject $subject, ";
 }
 if ($author){
-    $search=$search."&author=$author";                 # FIXME - .=
+    $search .= "&author=$author";
     $searchdesc.="author $author, ";
 }
 if ($class){
-    $search=$search."&class=$class";                   # FIXME - .=
+    $search .= "&class=$class";
     $searchdesc.="class $class, ";
 }
 if ($title){
-    $search=$search."&title=$title";                   # FIXME - .=
+    $search .= "&title=$title";
     $searchdesc.="title $title, ";
 }
 if ($dewey){
-    $search=$search."&dewey=$dewey";                   # FIXME - .=
+    $search .= "&dewey=$dewey";
     $searchdesc.="dewey $dewey, ";
 }
 $search.="&ttype=$ttype";

diff --git a/thesaurus_popup.pl b/thesaurus_popup.pl
index 3443dd2..422df35 100755 (executable)
--- a/thesaurus_popup.pl
+++ b/thesaurus_popup.pl
@@ -42,7 +42,7 @@ my $dbh = C4::Context->dbh;
 # make the page ...
 print $input->header;
 if ($op eq "select") {
-       $subject = $subject."|$freelib_text";           # FIXME - .=
+       $subject .= "|$freelib_text";
 }
 print <<"EOF";
        <html>