Bug 18946 [QA Followup] - code cleanup
authorKyle M Hall <kyle@bywatersolutions.com>
Fri, 1 Sep 2017 12:41:51 +0000 (08:41 -0400)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 1 Sep 2017 16:02:26 +0000 (13:02 -0300)
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
opac/opac-changelanguage.pl

index 689f4d4..133e58e 100755 (executable)
 # You should have received a copy of the GNU General Public License
 # along with Koha; if not, see <http://www.gnu.org/licenses>.
 
-use strict;
-use warnings;
+use Modern::Perl;
+
 use C4::Templates;
 use CGI qw ( -utf8 );
 
 my $query    = new CGI;
 my $language = $query->param('language');
+
 # Detect where the user came from and save that url
-my $requestedUrl = $query->url(-base => 1) ;
+my $requestedUrl = $query->url( -base => 1 );
+
 # Use referer url if it matches $requestedUrl else use $requestedUrl as the url .
-my $url = $query->referer()=~$requestedUrl  ? $query->referer()  : $requestedUrl;
+my $url =
+  $query->referer() =~ $requestedUrl ? $query->referer() : $requestedUrl;
 
 # warn "Language : $query // $language // $url";
 
@@ -33,6 +36,6 @@ my $url = $query->referer()=~$requestedUrl  ? $query->referer()  : $requestedUrl
 # 'language=' should be removed from url string, otherwise
 # the language picker will not work
 $url =~ s|(.)language=[\w-]*&?|$1|;
-$url =~ s|(&\|\?)$||; # Remove extraneous ? or &
+$url =~ s|(&\|\?)$||;    # Remove extraneous ? or &
 
 C4::Templates::setlanguagecookie( $query, $language, $url );