Bug fixing : serial collection on OPAC were not correctly displayed.

Call to PrepareSerialsData on Serial information
Adding receivedlist and missing list to brief display
Modifying js to use display:block/display:none rather than visibility attribute.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tmpl
index 5e2d611..1e00579 100644 (file)
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tmpl
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tmpl
@@ -24,7 +24,8 @@
     </div>
 
     <!-- TMPL_LOOP NAME="years" -->
-    <div name="yeardata" id="<!-- TMPL_VAR NAME="year" -->" class="tabsub" <!--TMPL_IF Name="first" -->style="visibility:visible"<!--/TMPL_IF -->>
+  <!--TMPL_IF Name="first" -->  
+    <div name="yeardata" id="<!-- TMPL_VAR NAME="year" -->" class="tabsub" style="display:block"><!--TMPL_ELSE --><div name="yeardata" id="<!-- TMPL_VAR NAME="year" -->" class="tabsub" style="display:none"><!--/TMPL_IF -->
         <table width="400px">
             <tr>
                 <th>Date
@@ -64,9 +65,9 @@ function showlayer(numlayer)
     for (i=0; i<yeardata.length; i++ ) {
         ong=yeardata[i].getAttribute('id');
         if (numlayer==ong) {
-            yeardata[i].style.visibility="visible";
+            yeardata[i].style.display="block";
         } else {
-            yeardata[i].style.visibility="hidden";
+            yeardata[i].style.display="none";
         }
     }
 }

diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-serial-issues.tmpl b/koha-tmpl/opac-tmpl/prog/en/modules/opac-serial-issues.tmpl
index 5f91a93..0d0e5fa 100644 (file)
--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-serial-issues.tmpl
+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-serial-issues.tmpl
@@ -84,6 +84,24 @@
                        
                since <!-- TMPl_VAR name="startdate" -->
                </p>
+  <!-- TMPL_IF name="recievedlist" -->
+    <h2>Available Issues</h2>
+    <p>
+      <!-- TMPL_VAR name="recievedlist" -->
+    </p>
+  <!-- /TMPL_IF -->
+  <!-- TMPL_IF name="missinglist" -->
+    <h2>Unavailable Issues</h2>
+    <p>
+      <!-- TMPL_VAR name="missinglist" -->
+    </p>
+  <!-- /TMPL_IF -->
+  <!-- TMPL_IF name="opacnote" -->
+    <h2>Issues summary</h2>
+    <p>
+      <!-- TMPL_VAR name="opacnote" -->
+    </p>
+  <!-- /TMPL_IF -->
                <p><!-- TMPL_VAR name="notes" --></p>
        <!-- TMPL_IF name="opacnote" -->
                <h2>Issues summary</h2>

diff --git a/opac/opac-serial-issues.pl b/opac/opac-serial-issues.pl
index d54ebdb..4aceed9 100755 (executable)
--- a/opac/opac-serial-issues.pl
+++ b/opac/opac-serial-issues.pl
@@ -42,6 +42,7 @@ my ( $template, $loggedinuser, $cookie );
 my $biblionumber = $query->param('biblionumber');
 if ( $selectview eq "full" ) {
     my $subscriptions = GetFullSubscriptionsFromBiblionumber($biblionumber);
+    my $subscriptioninformation=PrepareSerialsData($subscriptions);
 
     my $title   = $subscriptions->[0]{bibliotitle};
     my $yearmin = $subscriptions->[0]{year};
@@ -62,7 +63,7 @@ if ( $selectview eq "full" ) {
 
     $template->param(
         biblionumber   => $query->param('biblionumber'),
-        years          => $subscriptions,
+        years          => $subscriptioninformation,
         yearmin        => $yearmin,
         yearmax        => $yearmax,
         bibliotitle    => $title,