Bug 18276: [QA Follow-up] Fix two new calls
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 7 Jul 2017 07:04:21 +0000 (09:04 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 10 Jul 2017 16:02:54 +0000 (13:02 -0300)
Found two calls in opac-issue-note.pl and svc/patron_notes.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
opac/opac-issue-note.pl
opac/svc/patron_notes

index becd708..832e365 100755 (executable)
@@ -53,11 +53,11 @@ $template->param(
 my $issue_id = $query->param('issue_id');
 my $issue = Koha::Checkouts->find( $issue_id );
 my $itemnumber = $issue->itemnumber;
-my $biblio = GetBiblioFromItemNumber($itemnumber);
+my $biblio = $issue->item->biblio;
 $template->param(
     issue_id   => $issue_id,
-    title      => $biblio->{'title'},
-    author     => $biblio->{'author'},
+    title      => $biblio->title,
+    author     => $biblio->author,
     note       => $issue->note,
     itemnumber => $issue->itemnumber,
 );
@@ -75,7 +75,7 @@ if ( $action eq 'issuenote' && C4::Context->preference('AllowCheckoutNotes') ) {
                 letter_code => 'PATRON_NOTE',
                 branchcode => $branch,
                 tables => {
-                    'biblio' => $biblio->{biblionumber},
+                    'biblio' => $biblio->biblionumber,
                     'borrowers' => $member->{borrowernumber},
                 },
             );
index d241f0c..d68bb69 100755 (executable)
@@ -79,13 +79,13 @@ if ($is_ajax) {
             $issue->set({ notedate => dt_from_string(), note => $clean_note })->store;
             if($clean_note) { # only send email if note not empty
                 my $branch = Koha::Libraries->find( $issue->branchcode );
-                my $biblio = GetBiblioFromItemNumber($issue->itemnumber);
+                my $biblionumber = $issue->item->biblionumber;
                 my $letter = C4::Letters::GetPreparedLetter (
                     module => 'circulation',
                     letter_code => 'PATRON_NOTE',
                     branchcode => $branch,
                     tables => {
-                        'biblio' => $biblio->{biblionumber},
+                        'biblio' => $biblionumber,
                         'borrowers' => $member->{borrowernumber},
                     },
                 );