Bug 9896 - Show vendor in subscription search when creating an order for a subscription
authorAndreas Roussos <arouss1980@gmail.com>
Tue, 13 Sep 2016 14:41:16 +0000 (17:41 +0300)
committerKyle M Hall <kyle@bywatersolutions.com>
Sun, 25 Sep 2016 14:09:56 +0000 (14:09 +0000)
In the staff client, when creating an order from a subscription
the vendor name should be shown in a separate column.

This patch adds that feature. The 'Vendor' column is added before
the 'Library' column since they appear in that order in Advanced
search.

Test plan:
0) [PREREQUISITES] In the Staff client, under Acquisitions, create
   a Vendor and associated Basket if you don't already have them.
   Then, under Serials, add a new Subscription using the Vendor
   you've just created.
1) Go to Acquisitions, and under 'Manage orders' search for a vendor,
   then click on 'Add to basket' and select 'From a subscription'.
2) Click 'Search' on the left hand side to search for all subscriptions.
   Notice how there is no 'Vendor' column in the results table.
3) Apply the patch.
4) Repeat step 2. Confirm that the patch works, i.e. there is now
   a 'Vendor' column which displays the vendor name.

Followed test plan, works as expected.

Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Serials.pm
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt

index 3c76cd8..543b1dc 100644 (file)
@@ -553,6 +553,7 @@ sub SearchSubscriptions {
             biblio.title,
             biblio.author,
             biblio.biblionumber,
+            aqbooksellers.name AS vendorname,
             biblioitems.issn
         FROM subscription
             LEFT JOIN subscriptionhistory USING(subscriptionid)
index f68d361..b97b20a 100644 (file)
@@ -60,6 +60,7 @@
                                 <th>ISSN</th>
                                 <th class="anti-the">Title</th>
                                 <th> Notes </th>
+                                <th>Vendor</th>
                                 <th>Library</th>
                                 <th>Call number</th>
                                 <th class="title-string">Expiration date</th>
@@ -77,6 +78,9 @@
                                 <td>[% IF (sub.publicnotes) %][% sub.publicnotes %][% END %]
                                     [% IF (sub.internalnotes) %]([% sub.internalnotes %])[% END %]
                                 </td>
+                                <td>
+                                    [% IF (sub.vendorname) %][% sub.vendorname %][% END %]
+                                </td>
                                 <td>
                                     [% IF (sub.branchcode) %][% Branches.GetName( sub.branchcode ) %][% END %]
                                 </td>