Bug 20456: Remove the C4::Serials::GetSubscriptionsFromBorrower
authorKatrin Fischer <katrin.fischer.83@web.de>
Fri, 16 Mar 2018 09:13:19 +0000 (10:13 +0100)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 22 Jun 2018 15:02:46 +0000 (15:02 +0000)
Bug 20400 added a routing list tab to the patron account in the
OPAC using Koha::Object. After changing the staff view too,
we can now safely remove GetSubscriptionsFromBorrower as it
is no longer used.

To test:
- Make sure that GetSubscriptionsFromBorrower is no longer used.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/Serials.pm

index ac21dad..0f6256e 100644 (file)
@@ -85,7 +85,6 @@ BEGIN {
       &check_routing &updateClaim
       &CountIssues
       HasItems
-      &GetSubscriptionsFromBorrower
       &subscriptionCurrentlyOnOrder
 
     );
@@ -2198,41 +2197,6 @@ sub in_array {    # used in next sub down
     return 0;
 }
 
-=head2 GetSubscriptionsFromBorrower
-
-($count,@routinglist) = GetSubscriptionsFromBorrower($borrowernumber)
-
-this gets the info from subscriptionroutinglist for each $subscriptionid
-
-return :
-a count of the serial subscription routing lists to which a patron belongs,
-with the titles of those serial subscriptions as an array. Each element of the array
-contains a hash_ref with subscriptionID and title of subscription.
-
-=cut
-
-sub GetSubscriptionsFromBorrower {
-    my ($borrowernumber) = @_;
-    my $dbh              = C4::Context->dbh;
-    my $sth              = $dbh->prepare(
-        "SELECT subscription.subscriptionid, biblio.title
-            FROM subscription
-            JOIN biblio ON biblio.biblionumber = subscription.biblionumber
-            JOIN subscriptionroutinglist USING (subscriptionid)
-            WHERE subscriptionroutinglist.borrowernumber = ? ORDER BY title ASC
-                               "
-    );
-    $sth->execute($borrowernumber);
-    my @routinglist;
-    my $count = 0;
-    while ( my $line = $sth->fetchrow_hashref ) {
-        $count++;
-        push( @routinglist, $line );
-    }
-    return ( $count, @routinglist );
-}
-
-
 =head2 GetFictiveIssueNumber
 
 $issueno = GetFictiveIssueNumber($subscription, $publishedate);