Bug 9335 - humanMsg popups don't disapear in webkit browsers

The popup message that appears after saving changes to system
preferences should dissapear upon any user actions (i.e mouse
click, mouse move, typing) but this does not happen in modern
webkit based browsers since jQuery was updated.

This patch adds the suggested fix to the jQuery plugin code as
suggested on https://code.google.com/p/humanmsg/issues/detail?id=9

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Tested with Google Chrome on Windows 7

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Tested with Google Chrome 22 and Firefox on Debian
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Tested with the following browsers:
  Mac: Chrome 23, Firefox 16.0.2, Opera 11.61, Safari 5.1.7
  Windows: IE8, Firefox 3.6.26

diff --git a/koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/humanmsg.js b/koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/humanmsg.js
index af37c88..4a2d62c 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/humanmsg.js
+++ b/koha-tmpl/intranet-tmpl/prog/en/lib/jquery/plugins/humanmsg.js
@@ -84,9 +84,9 @@ var humanMsg = {
                        .unbind('click', humanMsg.removeMsg)
                        .unbind('keypress', humanMsg.removeMsg)
 
-               // If message is fully transparent, fade it out
-               if (jQuery('#'+humanMsg.msgID).css('opacity') == humanMsg.msgOpacity)
-                       jQuery('#'+humanMsg.msgID).animate({ opacity: 0 }, 500, function() { jQuery(this).hide() })
+                // If message is fully transparent, fade it out
+                if ( Math.abs(jQuery('#'+humanMsg.msgID).css('opacity') - humanMsg.msgOpacity ) < 0.00001 )
+                        jQuery('#'+humanMsg.msgID).animate({ opacity: 0 }, 500, function() { jQuery(this).hide() })
        }
 };