Bug 5374 [SIGNED-OFF] Followup: adds conditional check to unit test for late orders
authorIan Walls <koha.sekjal@gmail.com>
Mon, 19 Mar 2012 23:16:48 +0000 (19:16 -0400)
committerPaul Poulain <paul.poulain@biblibre.com>
Wed, 18 Apr 2012 15:01:24 +0000 (17:01 +0200)
If there are no late orders in the database, the 5th unit test for C4/Acquisition.pm
fails, since no date is returned (and today's date is expected)

This patch adds a conditional check around whether any late orders are actually returned
by GetLateOrders. If so, tests proceed, if not, they're skipped.  This seems to quiet
the failures in the automated test suite.

http://bugs.koha-community.org/show_bug.cgi?id=5347

signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

t/db_dependent/Acquisition.t

index ab0b6d0..6e845f8 100755 (executable)
@@ -33,10 +33,13 @@ my $orders = GetPendingOrders( $supplierid, $grouped );
 isa_ok( $orders, 'ARRAY' );
 
 my @lateorders = GetLateOrders(0);
-my $order = $lateorders[0];
-AddClaim( $order->{ordernumber} );
-my $neworder = GetOrder( $order->{ordernumber} );
-is( $neworder->{claimed_date}, strftime( "%Y-%m-%d", localtime(time) ), "AddClaim : Check claimed_date" );
+SKIP: {
+   skip 'No Late Orders, cannot test AddClaim', 1 unless @lateorders;
+   my $order = $lateorders[0];
+   AddClaim( $order->{ordernumber} );
+   my $neworder = GetOrder( $order->{ordernumber} );
+   is( $neworder->{claimed_date}, strftime( "%Y-%m-%d", localtime(time) ), "AddClaim : Check claimed_date" );
+}
 
 SKIP: {
     skip 'No relevant orders in database, cannot test baskets', 33 unless( scalar @$orders );
@@ -56,7 +59,7 @@ SKIP: {
                              entrydate
                              firstname
                              freight
-                             gst
+                             gstrate
                              listprice
                              notes
                              ordernumber