From: Ian Walls <sekjal@Samael.local>
Date: Mon, 25 Apr 2011 22:30:22 +0000 (-0400)
Subject: Bug 6259: AllowHoldPolicyOverride causes every hold to need override
X-Git-Url: http://git.rot13.org/?a=commitdiff_plain;ds=sidebyside;h=6059599fac4cfd0b12af48348a6d349974205697;p=koha.git

Bug 6259: AllowHoldPolicyOverride causes every hold to need override

Adds a check to make sure that the item is actually unavailable before requiring the override

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
---

diff --git a/reserve/request.pl b/reserve/request.pl
index c3c7a36b42..0b3bebca85 100755
--- a/reserve/request.pl
+++ b/reserve/request.pl
@@ -443,7 +443,7 @@ foreach my $biblionumber (@biblionumbers) {
                     $num_override++;
             }
             # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules
-            if (C4::Context->preference( 'AllowHoldPolicyOverride' ) ) {
+            if (C4::Context->preference( 'AllowHoldPolicyOverride' ) && !$item->{available} ) {
                 $item->{override} = 1;
                 $num_override++;
             }