From: srowen <srowen@59b500cc-1b3d-0410-9834-0bbf25fbcc57>
Date: Tue, 20 Nov 2007 18:19:18 +0000 (+0000)
Subject: Increase maximum desired zoom to 2.5x
X-Git-Url: http://git.rot13.org/?a=commitdiff_plain;ds=sidebyside;h=e91791406d391a360fdb0f1c1ef3f6c5b4fe4393;p=zxing.git

Increase maximum desired zoom to 2.5x

git-svn-id: http://zxing.googlecode.com/svn/trunk@61 59b500cc-1b3d-0410-9834-0bbf25fbcc57
---

diff --git a/javame/src/com/google/zxing/client/j2me/ZXingMIDlet.java b/javame/src/com/google/zxing/client/j2me/ZXingMIDlet.java
index ba375f84..fa10cb5d 100644
--- a/javame/src/com/google/zxing/client/j2me/ZXingMIDlet.java
+++ b/javame/src/com/google/zxing/client/j2me/ZXingMIDlet.java
@@ -40,7 +40,8 @@ import java.io.IOException;
  */
 public final class ZXingMIDlet extends MIDlet {
 
-  private static final int MAX_ZOOM = 200;
+  private static final int NO_ZOOM = 100;
+  private static final int MAX_ZOOM = 250;
 
   private Canvas canvas;
   private Player player;
@@ -76,15 +77,17 @@ public final class ZXingMIDlet extends MIDlet {
   }
 
   private static void setZoom(Player player) {
-    // zoom up to 2x if possible
     ZoomControl zoomControl = (ZoomControl) player.getControl("javax.microedition.amms.control.camera.ZoomControl");
     if (zoomControl != null) {
+      // We zoom in if possible to encourage the viewer to take a snapshot from a greater distance.
+      // This is a crude way of dealing with the fact that many phone cameras will not focus at a
+      // very close range.
       int maxZoom = zoomControl.getMaxOpticalZoom();
-      if (maxZoom > 100) {
+      if (maxZoom > NO_ZOOM) {
         zoomControl.setOpticalZoom(maxZoom > MAX_ZOOM ? MAX_ZOOM : maxZoom);
       } else {
         int maxDigitalZoom = zoomControl.getMaxDigitalZoom();
-        if (maxDigitalZoom > 100) {
+        if (maxDigitalZoom > NO_ZOOM) {
           zoomControl.setDigitalZoom(maxDigitalZoom > MAX_ZOOM ? MAX_ZOOM : maxDigitalZoom);
         }
       }