From: leppoc <leppoc@59b500cc-1b3d-0410-9834-0bbf25fbcc57>
Date: Fri, 19 Dec 2008 16:24:20 +0000 (+0000)
Subject: Allow the + character in phone numbers. In the same time, fix a bug where other non... 
X-Git-Url: http://git.rot13.org/?a=commitdiff_plain;ds=sidebyside;h=fcd3a7ac9684c5b7a05aebe2835d40d26b16e55c;p=zxing.git

Allow the + character in phone numbers. In the same time, fix a bug where other non allowed characters (such as /, or &) in url attributes would generate a non valid url.



git-svn-id: http://zxing.googlecode.com/svn/trunk@795 59b500cc-1b3d-0410-9834-0bbf25fbcc57
---

diff --git a/zxing.appspot.com/generator/src/com/google/zxing/web/generator/client/Generator.java b/zxing.appspot.com/generator/src/com/google/zxing/web/generator/client/Generator.java
index 94b06626..05cb0c03 100644
--- a/zxing.appspot.com/generator/src/com/google/zxing/web/generator/client/Generator.java
+++ b/zxing.appspot.com/generator/src/com/google/zxing/web/generator/client/Generator.java
@@ -181,7 +181,7 @@ public class Generator implements EntryPoint {
     result += "x";
     result += sizeY;
     result += "&chl=";
-    result += URL.encode(content);
+    result += URL.encodeComponent(content);
     return result;
   }
   
diff --git a/zxing.appspot.com/generator/src/com/google/zxing/web/generator/client/Validators.java b/zxing.appspot.com/generator/src/com/google/zxing/web/generator/client/Validators.java
index 51646bfb..99458e4f 100644
--- a/zxing.appspot.com/generator/src/com/google/zxing/web/generator/client/Validators.java
+++ b/zxing.appspot.com/generator/src/com/google/zxing/web/generator/client/Validators.java
@@ -24,11 +24,11 @@ package com.google.zxing.web.generator.client;
  */
 public final class Validators {
   public static String filterNumber(String number) {
-    return number.replaceAll("[ +\\.,\\-\\(\\)]", "");
+    return number.replaceAll("[ \\.,\\-\\(\\)]", "");
   }
   
   public static void validateNumber(String number) throws GeneratorException {    
-    if (!number.matches("[0-9]+")) {
+    if (!number.matches("\\+?[0-9]+")) {
       throw new GeneratorException("Phone number must be digits only.");
     }
   }