From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Sat, 29 Sep 2018 19:04:56 +0000 (-0300)
Subject: Bug 21448: Fix copy repeated subfields when linking an authority with 6xx
X-Git-Url: http://git.rot13.org/?a=commitdiff_plain;h=08386cd3f05c5bc4dc6306e3a1d6c4878cce7c86;p=koha.git

Bug 21448: Fix copy repeated subfields when linking an authority with 6xx

The reported issue was:
On field 606, if I use an Authority with multiple "x" subfields, it will
add just the first "x"

Error in the logs:
Odd number of elements in anonymous hash at /home/vagrant/kohaclone/authorities/blinddetail-biblio-search.pl line 97.

We should pass a ref (!), caused by
  commit a7df1f9f8eb9ed16246964d94dd8a69b756b6551
  Bug 18904: (follow-up) Retrieve subfield in the order they are stored

Test plan:
Edit an authority and add several $x to 600
Link this authority to a bibliographic record
=> Without this patch only the first subfield is copied
=> With this patch applied they are all copied

Signed-off-by: José Anjos <joseanjos@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---

diff --git a/authorities/blinddetail-biblio-search.pl b/authorities/blinddetail-biblio-search.pl
index f8ae22b242..73d2fcf160 100755
--- a/authorities/blinddetail-biblio-search.pl
+++ b/authorities/blinddetail-biblio-search.pl
@@ -94,7 +94,7 @@ if ($authid) {
         $letter ||= '@';
         next if defined $done_subfields{$letter};
         my @values = $field->subfield($letter);
-        push @subfield_loop, {marc_subfield => $letter, marc_values => @values };
+        push @subfield_loop, {marc_subfield => $letter, marc_values => \@values };
         $done_subfields{$letter} = 1;
     }