From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Thu, 15 Nov 2018 13:35:33 +0000 (-0500)
Subject: Bug 21495: Regression in hold override functionality
X-Git-Url: http://git.rot13.org/?a=commitdiff_plain;h=398704662487a0c8a3f848a2ae23618ee96406ff;p=koha.git

Bug 21495: Regression in hold override functionality

The changes caused by the patches for bug 11512 have broken existing
workflows for many libraries and are widely considered to be a bad move.
We should revert this behavior.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Rhonda Kuiper <kuiper@roundrocktexas.gov>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
index 32448b6bca..2d80bdd5c7 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
@@ -582,7 +582,7 @@ Circulation:
               choices:
                   yes: Allow
                   no: "Don't allow"
-            - staff to force addition of holds even if the patron already has the maximum number of holds allowed.
+            - staff to override hold policies when placing holds.
         -
             - pref: AllowHoldsOnDamagedItems
               choices:
diff --git a/reserve/request.pl b/reserve/request.pl
index 2534fe2580..91b6ffdd95 100755
--- a/reserve/request.pl
+++ b/reserve/request.pl
@@ -490,7 +490,7 @@ foreach my $biblionumber (@biblionumbers) {
 
                     push( @available_itemtypes, $item->{itype} );
                 }
-                elsif ( $can_item_be_reserved->{status} eq 'tooManyReserves' && C4::Context->preference('AllowHoldPolicyOverride') ) {
+                elsif ( C4::Context->preference('AllowHoldPolicyOverride') ) {
                     # If AllowHoldPolicyOverride is set, it should override EVERY restriction, not just branch item rules
                     $item->{override} = 1;
                     $num_override++;