From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 14 Aug 2018 19:26:39 +0000 (-0300)
Subject: Bug 21221: Shortcut memberentry scripts if patron does not exist
X-Git-Url: http://git.rot13.org/?a=commitdiff_plain;h=51933c7753f04cdc7baa745037919e601ec3d798;p=koha.git

Bug 21221: Shortcut memberentry scripts if patron does not exist

If borrowernumber is passed and that it does not refer to a valid patron
in DB, we should not continue the script and display an error instead.

Test plan:
Create a patron
Edit a patron
=> Both should work ok
You can also test the other action memberentry.pl manage.

Edit it again but modify the borrowernumber parameter
=> You should see a friendly user message saying that the patron does
not exist.

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---

diff --git a/members/memberentry.pl b/members/memberentry.pl
index 3618c4ffbe..2bf1a02f19 100755
--- a/members/memberentry.pl
+++ b/members/memberentry.pl
@@ -78,6 +78,10 @@ my ($template, $loggedinuser, $cookie)
 my $borrowernumber = $input->param('borrowernumber');
 my $patron         = Koha::Patrons->find($borrowernumber);
 
+if ( $borrowernumber and not $patron ) {
+    output_and_exit( $input, $cookie, $template,  'unknown_patron' );
+}
+
 if ( C4::Context->preference('SMSSendDriver') eq 'Email' ) {
     my @providers = Koha::SMS::Providers->search();
     $template->param( sms_providers => \@providers );