From: Stefan Richter <stefanr@s5r6.in-berlin.de>
Date: Tue, 10 Oct 2006 19:11:43 +0000 (+0200)
Subject: ieee1394: lock smaller region by host_num_alloc mutex
X-Git-Tag: v2.6.20-rc1~15^2~2^2~6^2~48
X-Git-Url: http://git.rot13.org/?a=commitdiff_plain;h=5c37dcbe138ed3239c5e8b6c2626ce773a7cea2e;p=powerpc.git

ieee1394: lock smaller region by host_num_alloc mutex

We need the mutex only around the iteration over existing hosts.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---

diff --git a/drivers/ieee1394/hosts.c b/drivers/ieee1394/hosts.c
index b935e08695..25573bad81 100644
--- a/drivers/ieee1394/hosts.c
+++ b/drivers/ieee1394/hosts.c
@@ -157,10 +157,9 @@ struct hpsb_host *hpsb_alloc_host(struct hpsb_host_driver *drv, size_t extra,
 	h->speed_map = (u8 *)(h->csr.speed_map + 2);
 
 	mutex_lock(&host_num_alloc);
-
 	while (nodemgr_for_each_host(&hostnum, alloc_hostnum_cb))
 		hostnum++;
-
+	mutex_unlock(&host_num_alloc);
 	h->id = hostnum;
 
 	memcpy(&h->device, &nodemgr_dev_template_host, sizeof(h->device));
@@ -175,8 +174,6 @@ struct hpsb_host *hpsb_alloc_host(struct hpsb_host_driver *drv, size_t extra,
 	class_device_register(&h->class_dev);
 	get_device(&h->device);
 
-	mutex_unlock(&host_num_alloc);
-
 	return h;
 }