From: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Date: Sun, 11 Apr 2010 18:40:57 +0000 (+0200)
Subject: MT3289 : check_sysprefs.pl case sensitive variable names
X-Git-Url: http://git.rot13.org/?a=commitdiff_plain;h=641616ef7fd43600864d46f39b938ef3cd8cd4f3;p=koha.git

MT3289 : check_sysprefs.pl case sensitive variable names

Variable names for systempreferences are now case sensitive.
Changing check_sysprefs in relation with this change

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
---

diff --git a/misc/check_sysprefs.pl b/misc/check_sysprefs.pl
index 0d06fde901..91d007511e 100755
--- a/misc/check_sysprefs.pl
+++ b/misc/check_sysprefs.pl
@@ -15,29 +15,31 @@ use C4::Context;
 @ARGV = qw(.) unless @ARGV;
 
 sub check_sys_pref {
-	my $dbh = C4::Context->dbh();
-	my $query = "SELECT * FROM systempreferences WHERE variable = ?";
-	my $sth = $dbh->prepare($query);	
-	if (! -d _ ){
-		my $name=$File::Find::name;
-		if ($name =~ /(\.pl|\.pm)$/){
-			open (FILE,"$_") || die "cant open $name";
-			while (my $inp = <FILE>){
-				if ($inp =~ /C4::Context->preference\((.*?)\)/){
-					my $variable = $1;
-					$variable =~s /\'|\"//g;
-					$sth->execute($variable);
-					if (my $data=$sth->fetchrow_hashref()){
-					}
-					else {
-						print "$name has a reference to $variable, this does not exist in the database\n";
-					}
-				}
-			}
-			close FILE;
-		}
-	}
-	$sth->finish();
+    my $dbh   = C4::Context->dbh();
+    my $query = "SELECT * FROM systempreferences WHERE variable = ?";
+    my $sth   = $dbh->prepare($query);
+    if ( !-d _ ) {
+        my $name = $File::Find::name;
+        if ( $name =~ /(\.pl|\.pm)$/ ) {
+            open( FILE, "$_" ) || die "cant open $name";
+            while ( my $inp = <FILE> ) {
+                if ( $inp =~ /C4::Context->preference\((.*?)\)/ ) {
+                    my $variable = $1;
+                    $variable =~ s /\'|\"//g;
+                    $sth->execute($variable);
+                    if ( my $data = $sth->fetchrow_hashref() ) {
+                        if ( $data->{variable} eq $variable ) {
+                            next;
+                        }
+                    }
+                    print
+"$name has a reference to $variable, this does not exist in the database\n";
+                }
+            }
+            close FILE;
+        }
+    }
+    $sth->finish();
 }
 
-find(\&check_sys_pref,@ARGV);
+find( \&check_sys_pref, @ARGV );