From: Colin Campbell <colin.campbell@ptfs-europe.com>
Date: Sat, 15 May 2010 12:40:18 +0000 (+0100)
Subject: Bug 2505 enable warnings in serials/reorder_members.pl
X-Git-Url: http://git.rot13.org/?a=commitdiff_plain;h=7d875359dc32e9db5184fc6ea0bfc9fd997279e7;p=koha.git

Bug 2505 enable warnings in serials/reorder_members.pl

The only serials routine without warnings enabled was a
script with the least code to generate them
removed the numerous Module use declarations that were not
required
aligned the parameters for a more aesthetically pleasing effect

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
---

diff --git a/serials/reorder_members.pl b/serials/reorder_members.pl
index c42823df9c..66d4ab2f17 100755
--- a/serials/reorder_members.pl
+++ b/serials/reorder_members.pl
@@ -14,27 +14,21 @@
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
-
 # Routing.pl script used to create a routing list for a serial subscription
 # In this instance it is in fact a setting up of a list of reserves for the item
 # where the hierarchical order can be changed on the fly and a routing list can be
 # printed out
 use strict;
-#use warnings; FIXME - Bug 2505
+use warnings;
 use CGI;
-use C4::Auth;
-use C4::Context;
-use C4::Output;
-use C4::Koha;
-use C4::Acquisition;
-use C4::Serials;
 
-my $query = new CGI;
+my $query          = CGI->new;
 my $subscriptionid = $query->param('subscriptionid');
-my $routingid = $query->param('routingid');
-my $rank = $query->param('rank');
+my $routingid      = $query->param('routingid');
+my $rank           = $query->param('rank');
 
-reorder_members($subscriptionid,$routingid,$rank);
+reorder_members( $subscriptionid, $routingid, $rank );
 
-print $query->redirect("/cgi-bin/koha/serials/routing.pl?subscriptionid=$subscriptionid");
+print $query->redirect(
+    "/cgi-bin/koha/serials/routing.pl?subscriptionid=$subscriptionid");