From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Date: Fri, 22 Dec 2017 10:20:13 +0000 (+0100)
Subject: Bug 19200: (QA follow-up) Simplify call to GetBasketAsCSV
X-Git-Url: http://git.rot13.org/?a=commitdiff_plain;h=7e21ffe6c5e09ad1f5a1023e32be88f5a43a9d68;p=koha.git

Bug 19200: (QA follow-up) Simplify call to GetBasketAsCSV

If no profile_id is passed, GetBasketAsCSV will fallback to default itself.
No need to make the distinction in basket.pl.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---

diff --git a/acqui/basket.pl b/acqui/basket.pl
index 8df5f8b6ea..92fae60a0a 100755
--- a/acqui/basket.pl
+++ b/acqui/basket.pl
@@ -171,13 +171,7 @@ if ( $op eq 'delete_confirm' ) {
         -attachment => 'basket' . $basket->{'basketno'} . '.csv',
     );
     my $csv_profile_id = $query->param('csv_profile');
-    if (defined $csv_profile_id) {
-        # using a csv profile
-        print GetBasketAsCSV(scalar $query->param('basketno'), $query, $csv_profile_id);
-    } else {
-        # using default
-        print GetBasketAsCSV(scalar $query->param('basketno'), $query);
-    }
+    print GetBasketAsCSV( scalar $query->param('basketno'), $query, $csv_profile_id ); # if no csv_profile_id passed, using default rows
     exit;
 } elsif ($op eq 'email') {
     my $err = eval {