From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Date: Fri, 14 Dec 2018 09:46:56 +0000 (+0100)
Subject: Bug 18736: (QA follow-up) Resolve uninitialized warn from Biblio.pm L3334
X-Git-Url: http://git.rot13.org/?a=commitdiff_plain;h=876323cf5bb5185834a875f3da29ac33f7760ef4;p=koha.git

Bug 18736: (QA follow-up) Resolve uninitialized warn from Biblio.pm L3334

Running t/db/Budgets.t:
Use of uninitialized value in join or string at C4/Biblio.pm line 3334.

Test plan:
Run again. Verify no warnings left.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---

diff --git a/C4/Biblio.pm b/C4/Biblio.pm
index fc23bb5994..13926ef939 100644
--- a/C4/Biblio.pm
+++ b/C4/Biblio.pm
@@ -3336,7 +3336,7 @@ sub ModBiblioMarc {
     my $userenv = C4::Context->userenv;
     if ($userenv) {
         my $borrowernumber = $userenv->{number};
-        my $borrowername = join ' ', @$userenv{qw(firstname surname)};
+        my $borrowername = join ' ', map { $_ // q{} } @$userenv{qw(firstname surname)};
         unless ($m_rs->in_storage) {
             Koha::Util::MARC::set_marc_field($record, C4::Context->preference('MarcFieldForCreatorId'), $borrowernumber);
             Koha::Util::MARC::set_marc_field($record, C4::Context->preference('MarcFieldForCreatorName'), $borrowername);