From: KAMBAROV, ZAUR <kambarov@berkeley.edu>
Date: Fri, 8 Jul 2005 00:57:05 +0000 (-0700)
Subject: [PATCH] coverity: fix fbsysfs null pointer check
X-Git-Tag: v2.6.13-rc3~242
X-Git-Url: http://git.rot13.org/?a=commitdiff_plain;h=8f96c95680bfe66ff00c91859d4c73edf539b854;p=powerpc.git

[PATCH] coverity: fix fbsysfs null pointer check

Correctly test for a null pointer before going and dereferencing it.

This defect was found automatically by Coverity Prevent, a static analysis
tool.

Signed-off-by: Zaur Kambarov <zkambarov@coverity.com>
Cc: <linux-fbdev-devel@lists.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/drivers/video/fbsysfs.c b/drivers/video/fbsysfs.c
index 7dfbf39b4e..ddc9443254 100644
--- a/drivers/video/fbsysfs.c
+++ b/drivers/video/fbsysfs.c
@@ -256,7 +256,7 @@ static ssize_t show_cmap(struct class_device *class_device, char *buf)
 	unsigned int offset = 0, i;
 
 	if (!fb_info->cmap.red || !fb_info->cmap.blue ||
-	    fb_info->cmap.green || fb_info->cmap.transp)
+	    !fb_info->cmap.green || !fb_info->cmap.transp)
 		return -EINVAL;
 
 	for (i = 0; i < fb_info->cmap.len; i++) {