From: Kyle M Hall <kyle@bywatersolutions.com>
Date: Mon, 11 Jun 2012 08:45:57 +0000 (-0400)
Subject: Bug 8223 - Properly format SQL query in C4::Bookseller::GetBookSeller
X-Git-Url: http://git.rot13.org/?a=commitdiff_plain;h=9dc42e9ec4bb6ab0511000018adaa0f7883c905f;p=koha.git

Bug 8223 - Properly format SQL query in C4::Bookseller::GetBookSeller

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
---

diff --git a/C4/Bookseller.pm b/C4/Bookseller.pm
index 4b8e2a5149..5874a93681 100644
--- a/C4/Bookseller.pm
+++ b/C4/Bookseller.pm
@@ -63,9 +63,12 @@ aqbooksellers table in the Koha database.
 sub GetBookSeller {
     my $searchstring = shift;
     $searchstring = q{%} . $searchstring . q{%};
-    my $query =
-'select aqbooksellers.*, count(*) as basketcount from aqbooksellers left join aqbasket '
-      . 'on aqbasket.booksellerid = aqbooksellers.id where name like ? group by aqbooksellers.id order by name';
+    my $query = "
+        SELECT aqbooksellers.*, count(*) AS basketcount
+        FROM aqbooksellers
+        LEFT JOIN aqbasket ON aqbasket.booksellerid = aqbooksellers.id
+        WHERE name LIKE ? GROUP BY aqbooksellers.id ORDER BY name
+    ";
 
     my $dbh           = C4::Context->dbh;
     my $sth           = $dbh->prepare($query);