From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Fri, 12 Feb 2016 11:47:22 +0000 (+0000)
Subject: Bug 15747: Do not use CGI->param in list context - Auth.pm
X-Git-Url: http://git.rot13.org/?a=commitdiff_plain;h=d9c19c6d45ad3f62119e3a29f37e227f635cb85c;p=koha.git

Bug 15747: Do not use CGI->param in list context - Auth.pm

Test plan:
Log you in!
Without this patch applied, you will get a warning
"Fetching the value or values of a single named parameter"
With this patch applied, the warning from C4::Auth line 401 should not
appear anymore in the log file.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Note: no warnings for older CGI versions.

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
---

diff --git a/C4/Auth.pm b/C4/Auth.pm
index 7655a4ff79..d891105a2b 100644
--- a/C4/Auth.pm
+++ b/C4/Auth.pm
@@ -398,7 +398,7 @@ sub get_template_and_user {
         $template->param( dateformat => C4::Context->preference('dateformat') );
     }
 
-    $template->param(auth_forwarded_hash => $in->{'query'}->param('auth_forwarded_hash'));
+    $template->param(auth_forwarded_hash => scalar $in->{'query'}->param('auth_forwarded_hash'));
 
     # these template parameters are set the same regardless of $in->{'type'}