From: Chris Cormack Date: Thu, 5 Apr 2012 02:28:06 +0000 (+1200) Subject: Bug 7613 follow up to fix perlcritic errors X-Git-Url: http://git.rot13.org/?a=commitdiff_plain;h=e3669815a00c158be92ea95f66b87fbe2c2ff78f;p=koha.git Bug 7613 follow up to fix perlcritic errors Signed-off-by: Paul Poulain --- diff --git a/misc/bin/connexion_import_daemon.pl b/misc/bin/connexion_import_daemon.pl index ffc1bcf7bc..9d32f8ac14 100755 --- a/misc/bin/connexion_import_daemon.pl +++ b/misc/bin/connexion_import_daemon.pl @@ -112,11 +112,11 @@ sub parse_config { my $config_file = $self->{config_file}; - open CONF, $config_file or die "Cannot open config file $config: $!"; + open (my $conf_fh, '<', $config_file) or die "Cannot open config file $config: $!"; my %param; my $line = 0; - while () { + while (<$conf_fh>) { $line++; chomp; s/\s*#.*//o; # remove comments @@ -145,7 +145,7 @@ sub parse_config { my $log_fh; close $self->{log_fh} if $self->{log_fh}; if (my $logfile = delete $param{log}) { - open $log_fh, ">>$logfile" or die "Cannot open $logfile for write: $!"; + open ($log_fh, '>>', $logfile) or die "Cannot open $logfile for write: $!"; } else { $log_fh = \*STDERR; }