From: Nick Clemens <nick@bywatersolutions.com>
Date: Tue, 18 Dec 2018 18:30:28 +0000 (+0000)
Subject: Bug 22022: Correct ordering for authorised values
X-Git-Url: http://git.rot13.org/?a=commitdiff_plain;h=e6cec898e078fc04d87e2faf26badba10fa6f348;p=koha.git

Bug 22022: Correct ordering for authorised values

To test:
1 - Add a shelving location with code "ZZZZ" and lib "Awake"
2 - Load some items in batch modification
3 - Note shelving location dropdown is wrong
4 - Apply patch
5 - Reload page
6 - Note order is correct

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
---

diff --git a/tools/batchMod.pl b/tools/batchMod.pl
index 1380d61c2a..afb2d293b7 100755
--- a/tools/batchMod.pl
+++ b/tools/batchMod.pl
@@ -388,7 +388,7 @@ foreach my $tag (sort keys %{$tagslib}) {
       else {
           push @authorised_values, ""; # unless ( $tagslib->{$tag}->{$subfield}->{mandatory} );
 
-          my @avs = Koha::AuthorisedValues->search({ category => $tagslib->{$tag}->{$subfield}->{authorised_value}, branchcode => $branch_limit });
+          my @avs = Koha::AuthorisedValues->search({ category => $tagslib->{$tag}->{$subfield}->{authorised_value}, branchcode => $branch_limit },{order_by=>'lib'});
           for my $av ( @avs ) {
               push @authorised_values, $av->authorised_value;
               $authorised_lib{$av->authorised_value} = $av->lib;