srowen [Tue, 2 Dec 2008 00:10:46 +0000 (00:10 +0000)]
Some formatting changes, and a few tiny optimizations
git-svn-id: http://zxing.googlecode.com/svn/trunk@768
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Mon, 1 Dec 2008 21:36:58 +0000 (21:36 +0000)]
Some formatting changes, and a few tiny optimizations
git-svn-id: http://zxing.googlecode.com/svn/trunk@767
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Mon, 1 Dec 2008 16:10:28 +0000 (16:10 +0000)]
Added a specific message for unsearchable books, and changed the Exit button in the help to Done to be a little clearer.
git-svn-id: http://zxing.googlecode.com/svn/trunk@766
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 26 Nov 2008 16:39:34 +0000 (16:39 +0000)]
Added a new QR Code unit test of real world photos of t-shirts. These are notoriously difficult because the barcodes don't lie completely flat. We're able to decode 33/48 which is better than I thought, although most of the images which fail look within reach.
git-svn-id: http://zxing.googlecode.com/svn/trunk@764
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 26 Nov 2008 15:30:34 +0000 (15:30 +0000)]
Bumped the version number to create v2.4 beta 1.
git-svn-id: http://zxing.googlecode.com/svn/trunk@763
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 25 Nov 2008 22:12:02 +0000 (22:12 +0000)]
Created an HTML help system, which is hooked up to the Menu/Help button. It also runs automatically the first time a new version of the app is run on a particular device. I wrote up a bunch of pages, which feature great art by Joseph, including a What's New page that we can edit for every release.
git-svn-id: http://zxing.googlecode.com/svn/trunk@761
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Tue, 25 Nov 2008 21:14:55 +0000 (21:14 +0000)]
Reduce alert timeout in J2ME client to 5 seconds from forever
git-svn-id: http://zxing.googlecode.com/svn/trunk@760
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Sat, 22 Nov 2008 01:20:25 +0000 (01:20 +0000)]
Made phone numbers hyphenated in the display below the encoded QR Code.
git-svn-id: http://zxing.googlecode.com/svn/trunk@759
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 21 Nov 2008 21:04:11 +0000 (21:04 +0000)]
Added great new artwork from Joseph for the Share UI. Also renamed the Share menu item to be clearer.
git-svn-id: http://zxing.googlecode.com/svn/trunk@758
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 21 Nov 2008 17:06:52 +0000 (17:06 +0000)]
Made Java naming changes to BitVector.
git-svn-id: http://zxing.googlecode.com/svn/trunk@757
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
kev.sully [Fri, 21 Nov 2008 16:40:40 +0000 (16:40 +0000)]
ISSUE: code.google.com/p/zxing/issues/detail?id=110
Changes to fix high nbr of false positives.
- Removed requirement that the barcode fills the viewfinder
- Extended the check on the lenght of decoded barcode - now only 6, 10 and 14 digit barcodes are supported.
git-svn-id: http://zxing.googlecode.com/svn/trunk@756
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
kev.sully [Fri, 21 Nov 2008 11:25:45 +0000 (11:25 +0000)]
ISSUE: code.google.com/p/zxing/issues/detail?id=110
Changes to fix high nbr of false positives.
- Fixed up the quiet zone checks.
- Validate that the barcode fills the viewfinder
- Check that decoded barcode is min 6 digits
git-svn-id: http://zxing.googlecode.com/svn/trunk@755
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
kev.sully [Fri, 21 Nov 2008 09:40:13 +0000 (09:40 +0000)]
ISSUE: code.google.com/p/zxing/issues/detail?id=110
Commented out references to ITFReader until it is validated as production ready.
git-svn-id: http://zxing.googlecode.com/svn/trunk@754
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 20 Nov 2008 22:43:20 +0000 (22:43 +0000)]
Removed some logging from the QR encoder. Nothing in core should be printf'ing - we can always inspect these with a debugger if needed. Also removed the temporary README about this package not compiling.
git-svn-id: http://zxing.googlecode.com/svn/trunk@753
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 20 Nov 2008 22:39:31 +0000 (22:39 +0000)]
Ported and rewrote the Renderer unit test to test QRCodeWriter. We encode several barcodes looking for good behavior, and several others which are compared pixel by pixel to golden results stored in PNGs. I'm happy to say we nail the three images Satoru created to the dot!
Along the way, I added support for encoder hints, and no longer hardcode the error correction level.
git-svn-id: http://zxing.googlecode.com/svn/trunk@752
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 20 Nov 2008 21:05:50 +0000 (21:05 +0000)]
Forced the Android client to only decode the existing 7 formats, thereby excluding ITF for the time being.
git-svn-id: http://zxing.googlecode.com/svn/trunk@751
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 20 Nov 2008 19:58:33 +0000 (19:58 +0000)]
Added support for encoding multiple email addresses and phone numbers using the new constants I added to the Contacts app for Android 1.1.
git-svn-id: http://zxing.googlecode.com/svn/trunk@750
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
kev.sully [Thu, 20 Nov 2008 17:34:23 +0000 (17:34 +0000)]
ISSUE: code.google.com/p/zxing/issues/detail?id=110
Renamed test cases dir to itf-1 (removed 14 specific reference)
git-svn-id: http://zxing.googlecode.com/svn/trunk@749
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
kev.sully [Thu, 20 Nov 2008 17:33:20 +0000 (17:33 +0000)]
ISSUE: code.google.com/p/zxing/issues/detail?id=110
Renamed test cases dir to itf-1 (removed 14 specific reference)
git-svn-id: http://zxing.googlecode.com/svn/trunk@748
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
kev.sully [Thu, 20 Nov 2008 17:29:22 +0000 (17:29 +0000)]
ISSUE: code.google.com/p/zxing/issues/detail?id=110
Added more test cases for ITF.
git-svn-id: http://zxing.googlecode.com/svn/trunk@747
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
kev.sully [Thu, 20 Nov 2008 17:28:52 +0000 (17:28 +0000)]
ISSUE: code.google.com/p/zxing/issues/detail?id=110
Added more test cases for ITF.
git-svn-id: http://zxing.googlecode.com/svn/trunk@746
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
kev.sully [Thu, 20 Nov 2008 17:27:12 +0000 (17:27 +0000)]
ISSUE: code.google.com/p/zxing/issues/detail?id=110
Renamed ITF14Reader to ITFReader. ITFReader now reads arbitrary number of digits. Added a QuietZone check. Removed checksum validation. Added more test cases.
git-svn-id: http://zxing.googlecode.com/svn/trunk@745
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
kev.sully [Thu, 20 Nov 2008 17:26:34 +0000 (17:26 +0000)]
ISSUE: code.google.com/p/zxing/issues/detail?id=110
Renamed ITF14Reader to ITFReader. ITFReader now reads arbitrary number of digits. Added a QuietZone check. Removed checksum validation. Added more test cases.
git-svn-id: http://zxing.googlecode.com/svn/trunk@744
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Thu, 20 Nov 2008 17:10:44 +0000 (17:10 +0000)]
git-svn-id: zxing.googlecode.com/svn/trunk@743
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 20 Nov 2008 17:08:30 +0000 (17:08 +0000)]
Ported over the BitVector bug fix and new unit test from Satoru.
git-svn-id: http://zxing.googlecode.com/svn/trunk@742
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Thu, 20 Nov 2008 14:07:19 +0000 (14:07 +0000)]
Added ITF-14 decoder from Kevin. Not enabled yet as we need to think a bit about how to handle this first. Also, the unit tests aren't passing for me but are for Kevin so I have commented them for the moment.
git-svn-id: http://zxing.googlecode.com/svn/trunk@741
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Thu, 20 Nov 2008 12:26:20 +0000 (12:26 +0000)]
Remove Debug and switch to eceptions in Encoder / Writer API
git-svn-id: http://zxing.googlecode.com/svn/trunk@740
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 19 Nov 2008 20:54:39 +0000 (20:54 +0000)]
Updated the Android client to use native/local QR Code encoding. For now it still runs on a thread and has a temporary "Working..." dialog. As I optimize a bit further, these may not be necessary.
git-svn-id: http://zxing.googlecode.com/svn/trunk@739
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 19 Nov 2008 20:12:38 +0000 (20:12 +0000)]
Changed the Writer interface to provide contents as a String instead of a byte array.
git-svn-id: http://zxing.googlecode.com/svn/trunk@738
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 19 Nov 2008 19:16:16 +0000 (19:16 +0000)]
Fixed more unit tests.
git-svn-id: http://zxing.googlecode.com/svn/trunk@737
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 19 Nov 2008 18:55:28 +0000 (18:55 +0000)]
Fixed testIsValidKanjiSequence(). Looks like the data arrays got copied over wrong from the C++ hex strings.
git-svn-id: http://zxing.googlecode.com/svn/trunk@736
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 19 Nov 2008 18:50:51 +0000 (18:50 +0000)]
Deleted a big honking polynomial table that was unused, and a related class.
git-svn-id: http://zxing.googlecode.com/svn/trunk@735
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 19 Nov 2008 18:35:10 +0000 (18:35 +0000)]
Did some optimization and cleanup.
git-svn-id: http://zxing.googlecode.com/svn/trunk@734
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 19 Nov 2008 16:39:59 +0000 (16:39 +0000)]
Added the quiet zone to the QRCodeWriter.
git-svn-id: http://zxing.googlecode.com/svn/trunk@733
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 19 Nov 2008 16:04:48 +0000 (16:04 +0000)]
Fixed testInterleaveWithECBytes().
git-svn-id: http://zxing.googlecode.com/svn/trunk@732
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 19 Nov 2008 15:51:44 +0000 (15:51 +0000)]
Fixed two more tests.
git-svn-id: http://zxing.googlecode.com/svn/trunk@731
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Wed, 19 Nov 2008 12:39:18 +0000 (12:39 +0000)]
Corrected logic to handle case where remainder polynomial has leading 0 coefficients.
git-svn-id: http://zxing.googlecode.com/svn/trunk@730
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
ccmysen [Wed, 19 Nov 2008 09:26:54 +0000 (09:26 +0000)]
Changes to the matrix and debug classes to make some tests pass.
I'm not super happy about making LOG_INFO a noop, but I don't know the general
solution off hand.
In any case, MatrixUtilTestCase and MaskUtilTestCase both pass now.
git-svn-id: http://zxing.googlecode.com/svn/trunk@729
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 19 Nov 2008 01:58:31 +0000 (01:58 +0000)]
Fixed a bunch more tests, and commented out all of the Renderer tests for now so everything compiles.
Sean, try commenting out testEncode(). It'll let you run a bit further to see a genuine problem that testInterleaveWithECBytes() finds.
git-svn-id: http://zxing.googlecode.com/svn/trunk@728
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 18 Nov 2008 23:01:42 +0000 (23:01 +0000)]
Moved ByteArray up to core/common now that it has no dependencies on qrcode/encoder.
git-svn-id: http://zxing.googlecode.com/svn/trunk@727
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 18 Nov 2008 22:54:04 +0000 (22:54 +0000)]
Made several good fixes to and because of the unit tests. Turns out the EC array was never being set to the right size. I've now established that the Reed Solomon code is generating one fewer coefficient than the layer above it asked for.
git-svn-id: http://zxing.googlecode.com/svn/trunk@726
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 18 Nov 2008 21:46:24 +0000 (21:46 +0000)]
Created a WriterException class and updated a bunch of documentation.
git-svn-id: http://zxing.googlecode.com/svn/trunk@725
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 18 Nov 2008 21:34:17 +0000 (21:34 +0000)]
Made some incremental progress on the Encoder unit test. I think we've now hit the first real bug in the code.
git-svn-id: http://zxing.googlecode.com/svn/trunk@724
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 18 Nov 2008 21:31:35 +0000 (21:31 +0000)]
Added support for adding a contact with multiple email addresses and phone numbers. This change requires Android 1.1 to work, but is harmless on 1.0.
git-svn-id: http://zxing.googlecode.com/svn/trunk@723
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Tue, 18 Nov 2008 21:18:10 +0000 (21:18 +0000)]
Finally submit tiny change to comments here
git-svn-id: http://zxing.googlecode.com/svn/trunk@722
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Tue, 18 Nov 2008 21:15:30 +0000 (21:15 +0000)]
Replace IllegalStateException; still want to make it WriterException
git-svn-id: http://zxing.googlecode.com/svn/trunk@721
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 18 Nov 2008 19:44:25 +0000 (19:44 +0000)]
Made a small change to allow discovery of multiple email addresses within a Docomo MECARD.
git-svn-id: http://zxing.googlecode.com/svn/trunk@720
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
ccmysen [Tue, 18 Nov 2008 18:56:19 +0000 (18:56 +0000)]
Adding in the rest of the qrcode test cases.
Most of them seem to be having run errors right now, but most of the major
syntax errors are now gone. The main missing feature right now is the use of
the GaloisField polynomial and a working Renderer class.
git-svn-id: http://zxing.googlecode.com/svn/trunk@719
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
ccmysen [Tue, 18 Nov 2008 18:17:22 +0000 (18:17 +0000)]
Add testdata for the qrcode encoder tests (mainly part of the renderer testcase).
git-svn-id: http://zxing.googlecode.com/svn/trunk@718
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 18 Nov 2008 15:34:45 +0000 (15:34 +0000)]
My BitVector implementation was totally buggy. I rewrote a lot of it and ported the test case, which now passes.
Now I'm tracking down an assertion in Encoder.InterleaveWithECBytes().
git-svn-id: http://zxing.googlecode.com/svn/trunk@717
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Mon, 17 Nov 2008 22:10:45 +0000 (22:10 +0000)]
Created the base Writer object for all barcode encoding, then wrote a QR Code version. A Writer encodes a series of raw bytes into a 2D greyscale bitmap, represented by a ByteArray. This seems like a better container than MonochromeBitmapSource, because we may want shades of grey when encoding future formats. The next step is to hook this up to the Android client.
git-svn-id: http://zxing.googlecode.com/svn/trunk@716
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Mon, 17 Nov 2008 20:49:10 +0000 (20:49 +0000)]
Fixed the build.
git-svn-id: http://zxing.googlecode.com/svn/trunk@715
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Mon, 17 Nov 2008 17:56:31 +0000 (17:56 +0000)]
move to singleton ReaderException for a bit more performance
git-svn-id: http://zxing.googlecode.com/svn/trunk@714
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Mon, 17 Nov 2008 17:53:05 +0000 (17:53 +0000)]
Latent bug I think from earlier change to List from Vector
git-svn-id: http://zxing.googlecode.com/svn/trunk@713
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Sun, 16 Nov 2008 12:46:18 +0000 (12:46 +0000)]
Add a bit of a hack to better detect UTF-8 in the wild, versus ISO88591
git-svn-id: http://zxing.googlecode.com/svn/trunk@712
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Sun, 16 Nov 2008 12:03:11 +0000 (12:03 +0000)]
Change assert to an exception since this facility would not be available in J2ME. I vote for removing use of Debug anyway.
git-svn-id: http://zxing.googlecode.com/svn/trunk@711
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Sun, 16 Nov 2008 10:20:20 +0000 (10:20 +0000)]
Appear to have fixed the URL escaping issues this time without regression
git-svn-id: http://zxing.googlecode.com/svn/trunk@710
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Sat, 15 Nov 2008 20:23:32 +0000 (20:23 +0000)]
Now uses new Reed Solomon encoder code
git-svn-id: http://zxing.googlecode.com/svn/trunk@709
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Sat, 15 Nov 2008 13:50:18 +0000 (13:50 +0000)]
Add to result the raw, but parsed, bytes of byte segments in 2D barcodes
git-svn-id: http://zxing.googlecode.com/svn/trunk@708
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Sat, 15 Nov 2008 12:58:36 +0000 (12:58 +0000)]
Bug fix to unrandomization routine from sanfordsquires
git-svn-id: http://zxing.googlecode.com/svn/trunk@707
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Sat, 15 Nov 2008 00:07:25 +0000 (00:07 +0000)]
Remove my old email address from files. Might as well save spammers the trouble.
git-svn-id: http://zxing.googlecode.com/svn/trunk@706
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 14 Nov 2008 21:51:26 +0000 (21:51 +0000)]
Wrote a new ByteArray class to replace StringPiece and fixed all uses of it. Also converted all uses of stl::string (which was being used as vector<unsigned char>) to ByteArray. Everything in the Encoder but the Reed Solomon related code compiles now.
ByteArray could certainly move up to the common package, although it currently has a dependency on BitVector. We'll have to figure out what to do with the latter first.
This is the first set of changes I've made which are error prone. They involved a lot of pointer conversion, signed/unsigned semantics, etc. These diffs may have clues for later bugs.
git-svn-id: http://zxing.googlecode.com/svn/trunk@705
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 14 Nov 2008 18:43:54 +0000 (18:43 +0000)]
Huge progress on the Encoder. I'm down to StringPiece errors (that class hasn't been replaced yet) and a few nasty methods, which call into Reed Solomon (not done yet).
git-svn-id: http://zxing.googlecode.com/svn/trunk@704
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Fri, 14 Nov 2008 18:34:19 +0000 (18:34 +0000)]
More enhancements to Reed-Solomon tests
git-svn-id: http://zxing.googlecode.com/svn/trunk@703
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 14 Nov 2008 16:21:05 +0000 (16:21 +0000)]
Got MatrixUtil to compile, and refactored some methods out of it, and into Matrix where they belong.
git-svn-id: http://zxing.googlecode.com/svn/trunk@702
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 14 Nov 2008 15:40:38 +0000 (15:40 +0000)]
Did a bunch of comments cleanup.
git-svn-id: http://zxing.googlecode.com/svn/trunk@701
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Fri, 14 Nov 2008 14:13:45 +0000 (14:13 +0000)]
Added note about dex's issue with post-optimization debug symbol table
git-svn-id: http://zxing.googlecode.com/svn/trunk@700
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Fri, 14 Nov 2008 12:40:55 +0000 (12:40 +0000)]
Added Reed-Solomon encoder, suitable for QR Code encoding
git-svn-id: http://zxing.googlecode.com/svn/trunk@699
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 13 Nov 2008 21:59:08 +0000 (21:59 +0000)]
Wrote a reasonable implementation of BitVector which now compiles.
git-svn-id: http://zxing.googlecode.com/svn/trunk@698
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 13 Nov 2008 21:18:56 +0000 (21:18 +0000)]
Wrote a Matrix class and fixed all uses of it, as well as other small fixes like StringBuffer. MaskUtil and QRCode now compile with no errors.
git-svn-id: http://zxing.googlecode.com/svn/trunk@697
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Thu, 13 Nov 2008 19:08:25 +0000 (19:08 +0000)]
Comment out QR code encoder package for the moment
git-svn-id: http://zxing.googlecode.com/svn/trunk@696
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 13 Nov 2008 17:12:53 +0000 (17:12 +0000)]
Converted the Mode and ECLevel enums in QRCode.java.
git-svn-id: http://zxing.googlecode.com/svn/trunk@695
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 13 Nov 2008 16:14:44 +0000 (16:14 +0000)]
Began porting the QR Code encoder from ChartServer to Java/ZXing. Some important comments are flagged with JAVAPORT. I've done the following so far:
- Created Java files with our headers, packages, etc.
- Converted includes to imports, or commented out the unresolved dependencies
- Merged all the .h and .cpp contents into Java classes
- Fixed most of the formatting
- Did all the simple transformations (bool, NULL, const, struct, string, ::, ->)
- Created a Debug class to handle all the asserts and logging
- Fixed about half of the static arrays
- Removed some pthread cruft
IMPORTANT:
- Please do not start hacking this code up as I'm going to keep making large changes to it. In particular, we need to leave the trailing underscores on member variables for now. Once everything is compiling with no errors, we can revisit stylistic issues.
- There will be a number of similar classes within the encoder and in the rest of ZXing. We should refactor those later (BitVector and BitArray come to mind). In the mean time, I want to get everything working and the tests passing before we do that.
git-svn-id: http://zxing.googlecode.com/svn/trunk@694
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Thu, 13 Nov 2008 13:14:53 +0000 (13:14 +0000)]
making stuff final, weakening types, etc. per IntelliJ analysis
git-svn-id: http://zxing.googlecode.com/svn/trunk@693
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 12 Nov 2008 16:21:19 +0000 (16:21 +0000)]
Made a small change to the KDDI AU parsing code to handle pronunciation (aka Furigana) specifically.
git-svn-id: http://zxing.googlecode.com/svn/trunk@692
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 12 Nov 2008 15:42:44 +0000 (15:42 +0000)]
Wrote a new bookmark picker activity for use by the Share button, because I couldn't get the platform version to work.
git-svn-id: http://zxing.googlecode.com/svn/trunk@691
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 12 Nov 2008 14:40:23 +0000 (14:40 +0000)]
Fixed a regression in the QR Code encoder. The contents do not need to be run through URLEncoder first.
git-svn-id: http://zxing.googlecode.com/svn/trunk@690
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Wed, 12 Nov 2008 13:47:45 +0000 (13:47 +0000)]
Updates from sanfordsquires to fix RS decoding for Datamatrix
git-svn-id: http://zxing.googlecode.com/svn/trunk@689
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Wed, 12 Nov 2008 12:59:47 +0000 (12:59 +0000)]
Updates from sanfordsquires to fix RS decoding for Datamatrix
git-svn-id: http://zxing.googlecode.com/svn/trunk@688
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 11 Nov 2008 19:19:11 +0000 (19:19 +0000)]
Changed the ChartServer and Search Book Contents URLs back to google.com instead of using the LocaleManager, as they are API calls, not user-facing websites.
git-svn-id: http://zxing.googlecode.com/svn/trunk@687
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 11 Nov 2008 16:31:27 +0000 (16:31 +0000)]
Added support for Furigana using the SOUND field in MECARD. AddressBookParsedResult now has a pronunciation field to represent this. I'm not aware of whether this is supported in other formats like VCARD, so they all pass null for now.
git-svn-id: http://zxing.googlecode.com/svn/trunk@686
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Tue, 11 Nov 2008 15:32:31 +0000 (15:32 +0000)]
Now attempts to use locale-specific Google property in client. Also made some stuff final that can be.
git-svn-id: http://zxing.googlecode.com/svn/trunk@685
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 11 Nov 2008 14:48:11 +0000 (14:48 +0000)]
Somehow the IntelliJ Subversion integration did not commit these deleted files when I did the rename.
git-svn-id: http://zxing.googlecode.com/svn/trunk@684
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Mon, 10 Nov 2008 22:47:09 +0000 (22:47 +0000)]
Hid the Share menu if the results screen was showing, since it didn't make sense. Also change the autofocus delay to 1.5 seconds, to make it hunt a little less, and give the autoexposure system more time to run.
git-svn-id: http://zxing.googlecode.com/svn/trunk@683
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Mon, 10 Nov 2008 20:50:34 +0000 (20:50 +0000)]
Did a bunch of renaming, there was no need for the Barcodes prefix.
git-svn-id: http://zxing.googlecode.com/svn/trunk@682
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Mon, 10 Nov 2008 20:35:33 +0000 (20:35 +0000)]
First pass at adding a UI for sharing data via QR Codes. There's now a Share button in the main capture menu which leads to a choice of contacts, bookmarks, and clipboard contents, which will be encoded and shown full screen. Launching the bookmarks picker currently crashes with a permission problem, which I'm investigating.
git-svn-id: http://zxing.googlecode.com/svn/trunk@681
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Sun, 9 Nov 2008 16:22:43 +0000 (16:22 +0000)]
Partially addressed Reed-Solomon decoding issue for Datamatrix, but not entirely. Still some small issue that prevents correcting as many errors as possible.
git-svn-id: http://zxing.googlecode.com/svn/trunk@680
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Sun, 9 Nov 2008 16:20:15 +0000 (16:20 +0000)]
Made new array fields final
git-svn-id: http://zxing.googlecode.com/svn/trunk@679
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Sat, 8 Nov 2008 14:27:08 +0000 (14:27 +0000)]
Address a small but clear bug in detector logic
git-svn-id: http://zxing.googlecode.com/svn/trunk@678
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Sat, 8 Nov 2008 14:25:36 +0000 (14:25 +0000)]
Attempt to make encoding detection slightly more accurate -- rule out Shift_JIS in a few more cases
git-svn-id: http://zxing.googlecode.com/svn/trunk@677
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 7 Nov 2008 15:07:54 +0000 (15:07 +0000)]
Renamed launcher icon.
git-svn-id: http://zxing.googlecode.com/svn/trunk@676
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 6 Nov 2008 19:55:38 +0000 (19:55 +0000)]
Fixed two leaks when using AndroidHttpClient.
git-svn-id: http://zxing.googlecode.com/svn/trunk@675
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Thu, 6 Nov 2008 19:14:48 +0000 (19:14 +0000)]
Small additional error check in decoder
git-svn-id: http://zxing.googlecode.com/svn/trunk@674
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 6 Nov 2008 17:17:07 +0000 (17:17 +0000)]
Added support for landscape mode when encoding QR Codes, and made some small layout improvements.
git-svn-id: http://zxing.googlecode.com/svn/trunk@672
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 6 Nov 2008 16:25:39 +0000 (16:25 +0000)]
Finished renaming UPC --> Product in a few places.
git-svn-id: http://zxing.googlecode.com/svn/trunk@671
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 6 Nov 2008 16:13:16 +0000 (16:13 +0000)]
Added support for supplying a postal address when encoding a QR Code.
git-svn-id: http://zxing.googlecode.com/svn/trunk@670
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 5 Nov 2008 19:16:27 +0000 (19:16 +0000)]
Made some temporary changes to make throwing ReaderExceptions more efficient. Long term, we need to delete this class and change the decoders to return errors instead of throwing.
git-svn-id: http://zxing.googlecode.com/svn/trunk@669
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Tue, 4 Nov 2008 12:08:19 +0000 (12:08 +0000)]
Renamed UPC result type to Product, and introduced an idea of 'product ID' and 'normalized product ID' to account for UPC-E, where the actual visible ID is different from what we may want to search for as a key. Updated clients to use this too.
git-svn-id: http://zxing.googlecode.com/svn/trunk@668
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Mon, 3 Nov 2008 16:13:56 +0000 (16:13 +0000)]
Fixed Search Book Contents when built under ProGuard.
git-svn-id: http://zxing.googlecode.com/svn/trunk@667
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Sun, 2 Nov 2008 16:10:54 +0000 (16:10 +0000)]
Fixed the ZXing Test camera mode when using ProGuard.
git-svn-id: http://zxing.googlecode.com/svn/trunk@666
59b500cc-1b3d-0410-9834-
0bbf25fbcc57