srowen [Mon, 14 Sep 2009 10:17:17 +0000 (10:17 +0000)]
Fix for old logic error in seeking format information -- actually was comparing unmasked rather than masked values, though it ended up working
git-svn-id: http://zxing.googlecode.com/svn/trunk@1052
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 11 Sep 2009 16:11:47 +0000 (16:11 +0000)]
Added some comments to public methods.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1051
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 11 Sep 2009 14:02:39 +0000 (14:02 +0000)]
This should have been deleted in the last change.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1050
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 10 Sep 2009 22:18:58 +0000 (22:18 +0000)]
Lots of updates:
- Added support for new YUYV preview buffer format.
- Made the preview rectangle larger.
- Added support for high resolution screens.
- Updated for Donut but still runs on Cupcake.
- Converted to standard Java coding style for member variables.
- Added many comments and author tags.
- Removed some Petit Four hacks and vestigial code.
*** The app must be built with the Donut SDK from now on.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1049
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 3 Sep 2009 20:37:38 +0000 (20:37 +0000)]
Final changes for Barcode Scanner 2.93.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1046
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 2 Sep 2009 21:06:00 +0000 (21:06 +0000)]
Added a new feature to the test app, which captures all the device info and default camera parameters, then bundles them up into an email. This will make it very easy to get some important info about new devices from users (e.g. the HTC Hero which I don't have).
Also did a lot of other cleanup, added an about box, and prepared the app to be released on the Market.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1045
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Fri, 28 Aug 2009 13:31:16 +0000 (13:31 +0000)]
SImplified optimization a bit and made it more aggressive.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1044
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Wed, 26 Aug 2009 21:48:52 +0000 (21:48 +0000)]
Revert to pre-Cupcake preview callback system since seems to be some collision between the new one and auto-focus callback that stops scanning in some cases. Also, remove a bad version number from search activity?
git-svn-id: http://zxing.googlecode.com/svn/trunk@1042
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Tue, 25 Aug 2009 21:29:39 +0000 (21:29 +0000)]
Tiny code adjustments from inspection
git-svn-id: http://zxing.googlecode.com/svn/trunk@1041
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Mon, 24 Aug 2009 06:49:57 +0000 (06:49 +0000)]
Issue 230
git-svn-id: http://zxing.googlecode.com/svn/trunk@1040
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Sun, 23 Aug 2009 15:32:01 +0000 (15:32 +0000)]
Improve detector logic to throw out false positive finder patterns in a more reasonable manner. Current logic didn't quite achieve its goal in some corner cases and needed rethinking and some simplification. Fixes a reported failure from the group list. Net change in passed test cases is -1 otherwise (for 270 degree rotation -- not vital) so I consider it a net tiny win.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1039
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Sat, 22 Aug 2009 15:16:36 +0000 (15:16 +0000)]
Miscellaneous changes from FindBugs analysis
git-svn-id: http://zxing.googlecode.com/svn/trunk@1038
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Fri, 21 Aug 2009 16:17:50 +0000 (16:17 +0000)]
Update to final HTTP Client binaries
git-svn-id: http://zxing.googlecode.com/svn/trunk@1037
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 21 Aug 2009 14:18:31 +0000 (14:18 +0000)]
Made another fix for the Samsung Galaxy, and bumped the version to 2.92.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1036
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 19 Aug 2009 14:52:16 +0000 (14:52 +0000)]
Made a new fix to turn off the Samsung Galaxy flash, and cut release 2.91.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1035
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Thu, 13 Aug 2009 11:11:48 +0000 (11:11 +0000)]
Make web app work on Servlet/JSP 2.3/1.2 and fix some other mistakes
git-svn-id: http://zxing.googlecode.com/svn/trunk@1034
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Wed, 12 Aug 2009 09:15:52 +0000 (09:15 +0000)]
Issue 224, remove Christian's info since it seems to prevent the build from working for developers?
git-svn-id: http://zxing.googlecode.com/svn/trunk@1033
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Tue, 4 Aug 2009 21:59:24 +0000 (21:59 +0000)]
Boneheaded mistake: was writing transparent pixels
git-svn-id: http://zxing.googlecode.com/svn/trunk@1032
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Tue, 4 Aug 2009 15:57:37 +0000 (15:57 +0000)]
Need to use 1.5 jar location
git-svn-id: http://zxing.googlecode.com/svn/trunk@1031
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Tue, 4 Aug 2009 08:54:02 +0000 (08:54 +0000)]
Disable email-based decoding -- won't be able to support it soon and it is very rarely used by anyone. Leaving code in for future reference though.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1030
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Tue, 4 Aug 2009 08:53:05 +0000 (08:53 +0000)]
Fix issue 221
git-svn-id: http://zxing.googlecode.com/svn/trunk@1029
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Thu, 30 Jul 2009 08:58:57 +0000 (08:58 +0000)]
Add MatrixToImageWriter convenience class, small code tweaks in javase/, make ByteMatrix width/height property getters names standard
git-svn-id: http://zxing.googlecode.com/svn/trunk@1028
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 23 Jul 2009 22:10:43 +0000 (22:10 +0000)]
Fixed some long lines over 100 columns.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1027
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Wed, 22 Jul 2009 10:40:18 +0000 (10:40 +0000)]
Added error correction level to Result
git-svn-id: http://zxing.googlecode.com/svn/trunk@1026
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Wed, 22 Jul 2009 10:36:11 +0000 (10:36 +0000)]
Re-enable ProGuard, and finally identified the workaround that seems to make 4.4 work with our code without a VerifyError
git-svn-id: http://zxing.googlecode.com/svn/trunk@1025
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 21 Jul 2009 21:36:33 +0000 (21:36 +0000)]
Set a camera parameter to force the flash off. Also fixed the uninstall build targets.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1024
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 21 Jul 2009 19:33:25 +0000 (19:33 +0000)]
Converted the Android client and the test app to use the Android 1.5 SDK, and to use a more efficient preview frame mechanism too. We now require devices to be running Cupcake or a newer version of the platform. This change temporarily removes the Proguard step, which Sean is going to add back.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1023
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Tue, 21 Jul 2009 09:39:31 +0000 (09:39 +0000)]
Small detector simplification that addresses issue 215 and picks up a net +4 more images decoded in tests
git-svn-id: http://zxing.googlecode.com/svn/trunk@1022
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Fri, 17 Jul 2009 09:30:46 +0000 (09:30 +0000)]
Another tweak to get some valid ISO-8859-1 strings like "frédéric" to be guessed correctly
git-svn-id: http://zxing.googlecode.com/svn/trunk@1021
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 15 Jul 2009 18:32:01 +0000 (18:32 +0000)]
Added an optimization to the Android client's LuminanceSource implementation, and removed manual array copies in favor of System.arraycopy().
git-svn-id: http://zxing.googlecode.com/svn/trunk@1020
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 10 Jul 2009 18:55:04 +0000 (18:55 +0000)]
Added Germany to the list of Google Product Search locales.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1019
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 9 Jul 2009 15:20:42 +0000 (15:20 +0000)]
Created v2.9 of Barcode Scanner, and added Japanese translations.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1018
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 8 Jul 2009 21:17:52 +0000 (21:17 +0000)]
More x, y cleanup and 100 column fixes.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1017
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 8 Jul 2009 20:38:21 +0000 (20:38 +0000)]
Modified my skew correction code to also work upside down, meaning we now decode three more inverted PDF 417 images.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1016
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 2 Jul 2009 20:07:09 +0000 (20:07 +0000)]
I noticed that the codeword coordinates in PDF 417 barcodes were a few pixels off if there was skew or rotation in the image. I added a simple method to correct the vertical component of these points, and the units tests went from 8/23 to 11/23.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1015
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 1 Jul 2009 19:42:52 +0000 (19:42 +0000)]
Got 180 degree rotation working for PDF 417, and turned on the appropriate unit tests as a result.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1014
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 1 Jul 2009 16:35:05 +0000 (16:35 +0000)]
Cleaned up a number of comments and code to fit in 100 columns and added some TODO items.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1013
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 1 Jul 2009 16:13:25 +0000 (16:13 +0000)]
Converted the last user of the old MonochromeBitmapSource-style calls over to BitMatrix, and removed these deprecated methods.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1012
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 1 Jul 2009 15:13:44 +0000 (15:13 +0000)]
Added the second PDF 417 test to the AllPositiveBlackBoxTester.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1011
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 30 Jun 2009 21:55:19 +0000 (21:55 +0000)]
- Converted parts of the PDF 417 reader to use BitMatrix.
- Changed the PDF 417 detector to search the image more broadly, instead of assuming the barcode starts in the left 1/4 and ends in the right 1/4. We now get 8/23 on the real-world blackbox test, and we'll probably do even better with further improvements here.
- Added a quiet zone to two of the unit test images and updated a golden result for one of them. We now get 3/7 on the first test.
- Tried to fix some bugs in the upside down code but it still doesn't work.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1010
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 30 Jun 2009 18:51:43 +0000 (18:51 +0000)]
Added the PDF 417 blackbox tests to the test-blackbox Ant target.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1009
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 30 Jun 2009 18:47:34 +0000 (18:47 +0000)]
Created a new blackbox unit test of real-world PDF 417 images taken with an Android device. Currently we decode 0/23.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1008
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 30 Jun 2009 17:32:12 +0000 (17:32 +0000)]
Added a few computer-generated PDF 417 barcodes to the blackbox tests. The current code doesn't seem to handle more advanced error correction modes.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1007
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Mon, 29 Jun 2009 22:08:38 +0000 (22:08 +0000)]
Added the previous Android benchmark I've been using to track performance, as well as a new one which uses wider images and therefore twice as many pixels.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1006
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Mon, 29 Jun 2009 21:57:59 +0000 (21:57 +0000)]
Added slightly better blackbox unit test stats.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1005
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Mon, 29 Jun 2009 15:49:42 +0000 (15:49 +0000)]
- Got the DataMatrix decoder compiling again with a quick bandaid.
- Fixed two bugs in the LocalBlockBinarizer sharpening routine. It can now decode 2132 images in our blackbox tests, compared to 2103 using the global histogram approach.
- Added the PDF 417 blackbox test to AllPositiveBlackBoxTester, and allowed it to complete even if the tests fail.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1004
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Sun, 28 Jun 2009 16:33:02 +0000 (16:33 +0000)]
Code analysis tweaks
git-svn-id: http://zxing.googlecode.com/svn/trunk@1003
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
christian.brunschen [Sat, 27 Jun 2009 13:22:03 +0000 (13:22 +0000)]
* Throw the actual exception objects, rather than pointers to them, i.e.:
- replace |throw new FooException()| with |throw FooException()|
- replace |catch (FooException *ex)| with |catch (FooExceptio ex)|
- update all uses of caught exceptions appropriately:
. replace |ex->foo| with |ex.foo|
. remove all attempts to delete the caught exception(s)
* Add 'const' to the 'char *' declarations for character encoding names
git-svn-id: http://zxing.googlecode.com/svn/trunk@1002
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 26 Jun 2009 21:18:58 +0000 (21:18 +0000)]
Whoops, fixed long-standing bug in the benchmark. Never noticed before because we always used square images.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1001
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 26 Jun 2009 20:03:10 +0000 (20:03 +0000)]
Modified the CommandLineRunner to use all available decoders, even the ones which aren't considered production quality yet.
git-svn-id: http://zxing.googlecode.com/svn/trunk@1000
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Fri, 26 Jun 2009 19:22:48 +0000 (19:22 +0000)]
Remove use of BinaryBitmap in QR Code, DM
git-svn-id: http://zxing.googlecode.com/svn/trunk@999
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 26 Jun 2009 19:04:12 +0000 (19:04 +0000)]
Sean had a good idea to add @deprecated Javadoc comments to these three methods to help track down their usage. We can't use a Java @Deprecated annotation because core builds against Java 1.2.
git-svn-id: http://zxing.googlecode.com/svn/trunk@998
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Fri, 26 Jun 2009 19:03:04 +0000 (19:03 +0000)]
Fix an (old?) compile error
git-svn-id: http://zxing.googlecode.com/svn/trunk@997
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 26 Jun 2009 18:48:14 +0000 (18:48 +0000)]
Updated the Android Test app to use a wider viewfinder, to save images as PNGs instead of JPEGs, and to work on phones without a shutter button.
git-svn-id: http://zxing.googlecode.com/svn/trunk@996
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Fri, 26 Jun 2009 18:08:05 +0000 (18:08 +0000)]
Updates for appspot
git-svn-id: http://zxing.googlecode.com/svn/trunk@995
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Fri, 26 Jun 2009 18:01:31 +0000 (18:01 +0000)]
Nevermind, removing javadoc
git-svn-id: http://zxing.googlecode.com/svn/trunk@994
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 26 Jun 2009 17:49:45 +0000 (17:49 +0000)]
Refactored the MonochromeBitmapSource class hierarchy into LuminanceSource, Binarizer, and BinaryBitmap classes. The unit tests pass and I believe the change is complete, but there are some clients like J2ME and Bug that I can't build.
This change will allow new thresholding algorithms to be developed and tested, as well as implemented per platform if needed (e.g. in JNI on Android). It should also perform better when multiple 2D Readers are installed, because the underlying image will only be converted to 1 bit once. It also allows some platforms to return luminance data without a copy.
The current state of this checkin is to use the old black point algorithm, which now lives in GlobalHistogramBinarizer. This will be our benchmark and fallback for slower platforms. Going forward we will begin to use LocalBlockBinarizer as I shake out the edge cases and tune it for performance. Currently it is unused.
IMPORTANT: I have temporarily included three methods from MonochromeBitmapSource at the end of BinaryBitmap as a way to make this change in stages. They are deprecated and will be removed soon. All of the Reader classes will need to change the way they examine 1 bit pixels to use the new getBlackRow() and getBlackMatrix() calls.
git-svn-id: http://zxing.googlecode.com/svn/trunk@993
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Fri, 26 Jun 2009 17:47:15 +0000 (17:47 +0000)]
Try adding current javadoc to SVN
git-svn-id: http://zxing.googlecode.com/svn/trunk@992
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
kev.sully [Fri, 26 Jun 2009 14:34:16 +0000 (14:34 +0000)]
ISSUE: code.google.com/p/zxing/issues/detail?id=42
Added PDF417 to list of readers. Will be used only if its specified in a Hint.
git-svn-id: http://zxing.googlecode.com/svn/trunk@987
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 25 Jun 2009 19:46:49 +0000 (19:46 +0000)]
Fixed some code which was ignoring the result of MonochromeBitmapSource calls, which may work in some cases but isn't legal and failed and in some experiments.
git-svn-id: http://zxing.googlecode.com/svn/trunk@986
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Wed, 24 Jun 2009 13:19:53 +0000 (13:19 +0000)]
Style changes mostly
git-svn-id: http://zxing.googlecode.com/svn/trunk@985
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
kev.sully [Wed, 24 Jun 2009 10:03:37 +0000 (10:03 +0000)]
ISSUE: code.google.com/p/zxing/issues/detail?id=42
Added PDF417 to list of readers. Will be used only if its specified in a Hint.
git-svn-id: http://zxing.googlecode.com/svn/trunk@984
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
kev.sully [Wed, 24 Jun 2009 10:02:58 +0000 (10:02 +0000)]
ISSUE: code.google.com/p/zxing/issues/detail?id=42
Added PDF417 to list of readers. Will be used only if its specified in a Hint.
git-svn-id: http://zxing.googlecode.com/svn/trunk@983
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
kev.sully [Wed, 24 Jun 2009 10:02:27 +0000 (10:02 +0000)]
ISSUE: code.google.com/p/zxing/issues/detail?id=42
Added PDF417 to list of readers. Will be used only if its specified in a Hint.
git-svn-id: http://zxing.googlecode.com/svn/trunk@982
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
kev.sully [Wed, 24 Jun 2009 10:02:04 +0000 (10:02 +0000)]
ISSUE: code.google.com/p/zxing/issues/detail?id=42
Added PDF417 to list of readers. Will be used only if its specified in a Hint.
git-svn-id: http://zxing.googlecode.com/svn/trunk@981
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
kev.sully [Wed, 24 Jun 2009 10:01:47 +0000 (10:01 +0000)]
ISSUE: code.google.com/p/zxing/issues/detail?id=42
Added PDF417 to list of readers. Will be used only if its specified in a Hint.
git-svn-id: http://zxing.googlecode.com/svn/trunk@980
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 23 Jun 2009 21:05:09 +0000 (21:05 +0000)]
Added a clear() method to BitMatrix.
git-svn-id: http://zxing.googlecode.com/svn/trunk@979
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Mon, 22 Jun 2009 21:03:34 +0000 (21:03 +0000)]
Rewrote BitMatrix to allow rectangular 2D arrays, and so that every row begins with a new int, which makes it fast to copy out rows into BitArrays. This will be the basis of the upcoming bitmap refactoring for 1D Readers.
git-svn-id: http://zxing.googlecode.com/svn/trunk@978
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Mon, 22 Jun 2009 19:52:51 +0000 (19:52 +0000)]
Continuing with the x, y coordinate push, BitMatrix is now standardized. I also converted DataMask back to i, j for now to be consistent with the rest of the QR module, and made sure all the tests still pass.
git-svn-id: http://zxing.googlecode.com/svn/trunk@977
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Mon, 22 Jun 2009 17:48:37 +0000 (17:48 +0000)]
Remove getBits()
git-svn-id: http://zxing.googlecode.com/svn/trunk@976
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Mon, 22 Jun 2009 15:50:08 +0000 (15:50 +0000)]
Used IntelliJ's amazing refactoring functions to change the argument ordering of ByteMatrix. I want to standardize this across ZXing: the first component should always be horizontal and the second vertical, whether supplying an x, y point or a width, height pair. Also, we should always use x and y as variables with x being the horizontal component to avoid confusion.
git-svn-id: http://zxing.googlecode.com/svn/trunk@975
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Mon, 22 Jun 2009 15:32:59 +0000 (15:32 +0000)]
Modified some comments to reflect that these objects are thread-safe but not reentrant.
git-svn-id: http://zxing.googlecode.com/svn/trunk@974
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 19 Jun 2009 19:08:31 +0000 (19:08 +0000)]
Updated some comments about thread safety and fixed one easy case. Sean, please have a look.
git-svn-id: http://zxing.googlecode.com/svn/trunk@973
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Fri, 19 Jun 2009 13:23:09 +0000 (13:23 +0000)]
Issue 198
git-svn-id: http://zxing.googlecode.com/svn/trunk@972
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 18 Jun 2009 20:55:42 +0000 (20:55 +0000)]
Wrote a quick command line app to calculate how many total images are passing our blackbox unit tests. This could use some improvement but it's a start.
git-svn-id: http://zxing.googlecode.com/svn/trunk@971
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 18 Jun 2009 15:51:18 +0000 (15:51 +0000)]
Changed "Search book" back to "Search book contents" for clarity, since it's too confusing next to the "Book Search" button. The "Custom search" button will wrap in this case but it still fits fine.
git-svn-id: http://zxing.googlecode.com/svn/trunk@970
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 16 Jun 2009 18:47:34 +0000 (18:47 +0000)]
Added a new blackbox test with extreme shadows and highlights. We do pretty poorly on this, but I've been experimenting with local thresholding algorithms which are a night and day improvement.
Also made the ImageConverter app ignore some kinds of files.
git-svn-id: http://zxing.googlecode.com/svn/trunk@969
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Thu, 11 Jun 2009 13:42:39 +0000 (13:42 +0000)]
Added getBlackDiagonal() which I likely want to use later
git-svn-id: http://zxing.googlecode.com/svn/trunk@968
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Wed, 10 Jun 2009 16:40:56 +0000 (16:40 +0000)]
Issue 155: allow custom product search, and, other small tweaks I think nobody will yell at me for
git-svn-id: http://zxing.googlecode.com/svn/trunk@967
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Mon, 8 Jun 2009 19:17:34 +0000 (19:17 +0000)]
Calculated total time taken by the benchmark, and also reported it in the UI (in addition to logcat).
git-svn-id: http://zxing.googlecode.com/svn/trunk@966
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Mon, 8 Jun 2009 17:00:09 +0000 (17:00 +0000)]
Don't use books.google.cn for Book Search -- doesn't exist. Also a few tiny tweaks.
git-svn-id: http://zxing.googlecode.com/svn/trunk@965
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Sat, 6 Jun 2009 19:50:27 +0000 (19:50 +0000)]
Updates to compile against 1.5; figuring we will shortly need to be 1.5-friendly
git-svn-id: http://zxing.googlecode.com/svn/trunk@964
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Fri, 29 May 2009 00:05:48 +0000 (00:05 +0000)]
Added hypest who apparently actually wrote the C# port
git-svn-id: http://zxing.googlecode.com/svn/trunk@963
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 28 May 2009 18:59:11 +0000 (18:59 +0000)]
Wrote a usage message for the CommandLineRunner.
git-svn-id: http://zxing.googlecode.com/svn/trunk@962
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 28 May 2009 18:45:48 +0000 (18:45 +0000)]
Created a new QR blackbox test with difficult exposures, mostly self-shadowing cases. We only get 34 out of 120 tests, which is about what I expected. To fix these we will have to move away from a global black point and towards a more sophisticated local thresholding algorithm.
git-svn-id: http://zxing.googlecode.com/svn/trunk@961
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 28 May 2009 16:03:28 +0000 (16:03 +0000)]
Cut Barcode Scanner v2.8 for Android.
git-svn-id: http://zxing.googlecode.com/svn/trunk@960
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Thu, 28 May 2009 12:05:01 +0000 (12:05 +0000)]
Small tweaks, use more friendly content type
git-svn-id: http://zxing.googlecode.com/svn/trunk@959
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 27 May 2009 21:11:10 +0000 (21:11 +0000)]
Only allocate a StringBuffer if the start pattern has been found successfully in the ITFReader.
git-svn-id: http://zxing.googlecode.com/svn/trunk@958
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Wed, 27 May 2009 18:10:47 +0000 (18:10 +0000)]
Made the Android Test app debuggable so I can examine memory allocation patterns using DDMS (part of the Android SDK).
git-svn-id: http://zxing.googlecode.com/svn/trunk@957
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Wed, 27 May 2009 10:03:23 +0000 (10:03 +0000)]
Fixed an old misspelling and a few tiny tweaks
git-svn-id: http://zxing.googlecode.com/svn/trunk@956
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Wed, 27 May 2009 09:14:17 +0000 (09:14 +0000)]
Improvement to Shift_JIS encoding detector to avoid detecting some UTF-8 strings as Shift_JIS
git-svn-id: http://zxing.googlecode.com/svn/trunk@955
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 26 May 2009 18:12:22 +0000 (18:12 +0000)]
You can now dump the black point for URLs to the pwd.
git-svn-id: http://zxing.googlecode.com/svn/trunk@954
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Tue, 26 May 2009 16:39:00 +0000 (16:39 +0000)]
Extended the command line tool to dump the results of black point calculation. You can now use the flag --dump_black_point to generate a PNG which contains the original image, the row scanning monochrome version, and the 2D scanning monochrome version side by side. It will be saved as originalfilename.mono.png.
git-svn-id: http://zxing.googlecode.com/svn/trunk@953
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Sun, 24 May 2009 13:06:51 +0000 (13:06 +0000)]
Oops, one more fix to rotateCounterClockwise() here
git-svn-id: http://zxing.googlecode.com/svn/trunk@952
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Sat, 23 May 2009 10:33:53 +0000 (10:33 +0000)]
More intelligence to avoid very deep recursion
git-svn-id: http://zxing.googlecode.com/svn/trunk@951
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Fri, 22 May 2009 20:59:15 +0000 (20:59 +0000)]
Changed the 2D histogram calculation to sample four rows spread across the image rather than taking a diagonal. We get a net increase of 63 blackbox tests with this change.
git-svn-id: http://zxing.googlecode.com/svn/trunk@950
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Fri, 22 May 2009 08:19:11 +0000 (08:19 +0000)]
Off by one error in last change
git-svn-id: http://zxing.googlecode.com/svn/trunk@949
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
srowen [Fri, 22 May 2009 07:55:32 +0000 (07:55 +0000)]
Make some stuff to public to compile
git-svn-id: http://zxing.googlecode.com/svn/trunk@948
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 21 May 2009 21:18:27 +0000 (21:18 +0000)]
Added better logging for our blackbox tests. It now displays the number of images which passes per test out of the total, and the percentage. It also warns when a blackbox test is too lax (i.e. we've made decoding improvements but haven't raised the high water mark).
git-svn-id: http://zxing.googlecode.com/svn/trunk@947
59b500cc-1b3d-0410-9834-
0bbf25fbcc57
dswitkin [Thu, 21 May 2009 20:29:56 +0000 (20:29 +0000)]
Fixed a typo in our golden results.
git-svn-id: http://zxing.googlecode.com/svn/trunk@946
59b500cc-1b3d-0410-9834-
0bbf25fbcc57