Lars Wirzenius [Thu, 27 May 2010 00:08:06 +0000 (12:08 +1200)]
Merge branch 'master' of git://git.koha-community.org/koha
Lars Wirzenius [Thu, 27 May 2010 00:07:30 +0000 (12:07 +1200)]
Merge branch 'master' of git+ssh://git.catalyst.net.nz/git/public/koha
Owen Leonard [Wed, 26 May 2010 18:32:41 +0000 (14:32 -0400)]
Whitespace removal, removal of U+FEFF character
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Cindy Murdock Ames [Wed, 26 May 2010 16:56:26 +0000 (12:56 -0400)]
Added "dialog alert" class to "No Results Found" message on the patron
search so the alert stands out. Previously no css was applied to it so
it was just plain text. Librarians weren't noticing it.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nahuel ANGELINETTI [Wed, 26 May 2010 14:06:45 +0000 (16:06 +0200)]
(MT #2565) fix aqplan csv export, and turn off debug
This fix the csv export that doesn't export correctly the budget name, it's empty column.
And it turn off some SQL debug that slow down the result of the page and the csv export.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Wed, 26 May 2010 14:51:09 +0000 (10:51 -0400)]
bug 4508: fix crash when editing patron attributes or message prefs
When editing patron attributes or messaging preferences on the
patron editor, Koha would crash with the following error:
Software error:
Can't use an undefined value as an ARRAY reference at
/home/koha/kohaclone/C4/SQLHelper.pm line 186.
This would occur only when editing the specific attribute
or message preferences section, not when editing the entire
patron record.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Wed, 26 May 2010 06:52:58 +0000 (18:52 +1200)]
Set upload target to squeeze-dev.
Since we're uploading a git snapshot, this is not meant for
production, and thus it should not be uploaded to squeeze,
but for squeeze-dev.
Documentation for the pockets will appear in the apt
repository or the wiki once it is ready.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Wed, 26 May 2010 06:53:00 +0000 (18:53 +1200)]
Update README.Debian for koha-common with post-install setup.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Wed, 26 May 2010 06:53:01 +0000 (18:53 +1200)]
Update README.Debian for koha.deb package.
One bug fix (three steps, not two, are automated in koha-post-install-setup).
Also add a note about the need to possibly edit ports.conf.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Wed, 26 May 2010 06:52:57 +0000 (18:52 +1200)]
Use a native Debian package.
Since the packaging is part of the upstream source, there's no point
in having a Debian version.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Wed, 26 May 2010 06:52:59 +0000 (18:52 +1200)]
Add dependency on apache2-mpm-itk for koha-common.
The way things are set up, each Koha instance runs under its own
user account. At least for now, this requires apache2-mpm-itk.
Later we can investigate other possibilities.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Wed, 26 May 2010 04:18:34 +0000 (16:18 +1200)]
Make sure the temporary version number comes before 3.2.
This way, upgrades from the temporary ones to the final release
will happen automatically.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Wed, 26 May 2010 03:27:20 +0000 (23:27 -0400)]
bug 4816: require authentication for placerequest.pl
Otherwise, it was possible to construct a URL to place
hold requests without authorization.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Wed, 26 May 2010 03:27:21 +0000 (23:27 -0400)]
bug 4386: fix email hold filled notifications
Call to GetMembers() was using the old parameter style.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 25 May 2010 21:32:19 +0000 (17:32 -0400)]
removed needless imports of the YAML module
Removed instances of 'use YAML' that were either completely
unnecessary or which were used only in debug code. Also
removed a needless import of Data::Dumper.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Sat, 22 May 2010 19:01:20 +0000 (15:01 -0400)]
Bug 4199: Adds ability to print routing slip. Patch 2.
Previous patch added an invalid XHTML element. This patch fixes it.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Sat, 22 May 2010 18:54:46 +0000 (14:54 -0400)]
Bug 4199: Adds ability to print routing slip from serials-collection.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Sun, 23 May 2010 23:55:26 +0000 (19:55 -0400)]
Bug 4805: Fixes multiple subscriptionid's being passed to serials-collection.
This is a replacement patch for my previous patch.
This patch insures that only unique subscriptionids are defined in the serials-edit form. Multiple ids are passed to serials-collection, but not multiple copies of the same id.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 25 May 2010 19:23:49 +0000 (15:23 -0400)]
fix another link to koha-community.org
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 25 May 2010 18:38:38 +0000 (14:38 -0400)]
fix a common "developement" typo
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 25 May 2010 16:36:03 +0000 (12:36 -0400)]
bug 4377: ensure HOLD_PRINT letter added during installation and upgrade (DBrev 135)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 25 May 2010 15:00:29 +0000 (11:00 -0400)]
bug 4311: respect OPACXSLTResultsDisplay
Check OPACXSLTResultsDisplay instead of XSLTResultsDisplay when
determining whether to use the XSLT bib results stylesheet for
OPAC search results.
In the process, added a new $search_context parameter to
C4::Search::searchResults() to specify whether results
are to be served up for the staff interface or for the
OPAC.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 25 May 2010 13:21:24 +0000 (09:21 -0400)]
bug 4018: remove duplicate unAPI link when XSLT bib details display on
The unAPI link is now added only in opac-detail.tmpl. More than
one unAPI link in the same page was causing a bit of indigestion
for Zotero, which interprets multiple unAPI links as specifying
more than one resource on a given page.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:27 +0000 (13:44 +1200)]
Install the admin scripts.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:26 +0000 (13:44 +1200)]
Make koha-create be able to handle manual database creation.
This is necessary if we do not have access to DB server with sufficient
permissions. The DB server is used for other things, that may well be
the case.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:25 +0000 (13:44 +1200)]
Add support for a remote mysql server.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:24 +0000 (13:44 +1200)]
Use /etc/mysql/koha-common.cnf instead of the Debian one.
koha-common.postinst now creates a symlink to the Debian one.
The sysadmin may replace that manually with something that allows
Koha to access a remote mysql server.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:22 +0000 (13:44 +1200)]
Add koha-foreach, a script to run a command for each Koha instance.
Use script to enable the build_Holds_queue.pl cron job.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:21 +0000 (13:44 +1200)]
Centralize creation of Koha instance dirs.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:20 +0000 (13:44 +1200)]
Add scripts to start, stop, restart Zebra, and rebuild its indexes.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:19 +0000 (13:44 +1200)]
Add koha-upgrade-schema, a script to upgrade the database schema.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:18 +0000 (13:44 +1200)]
Add koha-dump-defaults, a script to dump a defaults file.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:17 +0000 (13:44 +1200)]
Add koha-reset-passwd, a script for resetting a user's password.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:16 +0000 (13:44 +1200)]
Add koha-enable, a script to re-enable a Koha instance.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:15 +0000 (13:44 +1200)]
Add koha-disable, a script to disable a Koha instance.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:14 +0000 (13:44 +1200)]
Add koha-restore, a script to restore a Koha instance from a dump.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:13 +0000 (13:44 +1200)]
Add koha-list, a script to list all Koha instances.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:12 +0000 (13:44 +1200)]
Add koha-dump, a script to dump a Koha site.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:11 +0000 (13:44 +1200)]
Add koha-remove, a script to remove a Koha instance.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:10 +0000 (13:44 +1200)]
Add koha-create, a script to create a new Koha instance.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:09 +0000 (13:44 +1200)]
Add koha-post-install-setup, a script to be run by sysadmin post-install.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:08 +0000 (13:44 +1200)]
Replace dependencies on koha-dev-env with list of packages.
The dependencies are needed both at build time and at run time. Build
time needs them for running tests. To avoid duplicating the (long!)
list of dependencies, we do a little bit of trickery, and generate
a koha:Depends substvar, from all build dependencies (except debhelper),
and use ${koha:Depends} in the koha-common (not koha) Depends header.
A little bit tricky, but works.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:07 +0000 (13:44 +1200)]
Split off koha-common.
koha-common will be suitable for hosts with multiple Koha instances,
or those that otherwise need to do thing differently from the main
koha package.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:06 +0000 (13:44 +1200)]
Set version number in debian/changelog to indicate upcoming 3.2.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:05 +0000 (13:44 +1200)]
Convert debian/copyright file to the DEP5 format.
The DEP5 format is machine-parseable, which will help keep track of
things in the future.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:04 +0000 (13:44 +1200)]
Switch to native source format.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:03 +0000 (13:44 +1200)]
Bugfix: Install old yui stylesheets, since Koha needs them.
Also fix paths, since we can't install them where Koha expects them,
since that location is used by the Debian packaged yui.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:02 +0000 (13:44 +1200)]
Bugfix: Create the jquery.js symlink for opac to the right target.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:01 +0000 (13:44 +1200)]
Bugfix: Remove Debian packaging files remaining from old packaging effort.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:00 +0000 (13:44 +1200)]
Bugfix: Remove pointless executable bits from sql files.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Wed, 26 May 2010 04:14:04 +0000 (16:14 +1200)]
merged from upstream master
Galen Charlton [Wed, 26 May 2010 03:27:20 +0000 (23:27 -0400)]
bug 4816: require authentication for placerequest.pl
Otherwise, it was possible to construct a URL to place
hold requests without authorization.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Wed, 26 May 2010 03:27:21 +0000 (23:27 -0400)]
bug 4386: fix email hold filled notifications
Call to GetMembers() was using the old parameter style.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 25 May 2010 21:32:19 +0000 (17:32 -0400)]
removed needless imports of the YAML module
Removed instances of 'use YAML' that were either completely
unnecessary or which were used only in debug code. Also
removed a needless import of Data::Dumper.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Sat, 22 May 2010 19:01:20 +0000 (15:01 -0400)]
Bug 4199: Adds ability to print routing slip. Patch 2.
Previous patch added an invalid XHTML element. This patch fixes it.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Sat, 22 May 2010 18:54:46 +0000 (14:54 -0400)]
Bug 4199: Adds ability to print routing slip from serials-collection.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Garry Collum [Sun, 23 May 2010 23:55:26 +0000 (19:55 -0400)]
Bug 4805: Fixes multiple subscriptionid's being passed to serials-collection.
This is a replacement patch for my previous patch.
This patch insures that only unique subscriptionids are defined in the serials-edit form. Multiple ids are passed to serials-collection, but not multiple copies of the same id.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 25 May 2010 19:23:49 +0000 (15:23 -0400)]
fix another link to koha-community.org
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 25 May 2010 18:38:38 +0000 (14:38 -0400)]
fix a common "developement" typo
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 25 May 2010 16:36:03 +0000 (12:36 -0400)]
bug 4377: ensure HOLD_PRINT letter added during installation and upgrade (DBrev 135)
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 25 May 2010 15:00:29 +0000 (11:00 -0400)]
bug 4311: respect OPACXSLTResultsDisplay
Check OPACXSLTResultsDisplay instead of XSLTResultsDisplay when
determining whether to use the XSLT bib results stylesheet for
OPAC search results.
In the process, added a new $search_context parameter to
C4::Search::searchResults() to specify whether results
are to be served up for the staff interface or for the
OPAC.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Tue, 25 May 2010 13:21:24 +0000 (09:21 -0400)]
bug 4018: remove duplicate unAPI link when XSLT bib details display on
The unAPI link is now added only in opac-detail.tmpl. More than
one unAPI link in the same page was causing a bit of indigestion
for Zotero, which interprets multiple unAPI links as specifying
more than one resource on a given page.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:27 +0000 (13:44 +1200)]
Install the admin scripts.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:26 +0000 (13:44 +1200)]
Make koha-create be able to handle manual database creation.
This is necessary if we do not have access to DB server with sufficient
permissions. The DB server is used for other things, that may well be
the case.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:25 +0000 (13:44 +1200)]
Add support for a remote mysql server.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:24 +0000 (13:44 +1200)]
Use /etc/mysql/koha-common.cnf instead of the Debian one.
koha-common.postinst now creates a symlink to the Debian one.
The sysadmin may replace that manually with something that allows
Koha to access a remote mysql server.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:22 +0000 (13:44 +1200)]
Add koha-foreach, a script to run a command for each Koha instance.
Use script to enable the build_Holds_queue.pl cron job.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:21 +0000 (13:44 +1200)]
Centralize creation of Koha instance dirs.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:20 +0000 (13:44 +1200)]
Add scripts to start, stop, restart Zebra, and rebuild its indexes.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:19 +0000 (13:44 +1200)]
Add koha-upgrade-schema, a script to upgrade the database schema.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:18 +0000 (13:44 +1200)]
Add koha-dump-defaults, a script to dump a defaults file.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:17 +0000 (13:44 +1200)]
Add koha-reset-passwd, a script for resetting a user's password.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:16 +0000 (13:44 +1200)]
Add koha-enable, a script to re-enable a Koha instance.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:15 +0000 (13:44 +1200)]
Add koha-disable, a script to disable a Koha instance.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:14 +0000 (13:44 +1200)]
Add koha-restore, a script to restore a Koha instance from a dump.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:13 +0000 (13:44 +1200)]
Add koha-list, a script to list all Koha instances.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:12 +0000 (13:44 +1200)]
Add koha-dump, a script to dump a Koha site.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:11 +0000 (13:44 +1200)]
Add koha-remove, a script to remove a Koha instance.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:10 +0000 (13:44 +1200)]
Add koha-create, a script to create a new Koha instance.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:09 +0000 (13:44 +1200)]
Add koha-post-install-setup, a script to be run by sysadmin post-install.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:08 +0000 (13:44 +1200)]
Replace dependencies on koha-dev-env with list of packages.
The dependencies are needed both at build time and at run time. Build
time needs them for running tests. To avoid duplicating the (long!)
list of dependencies, we do a little bit of trickery, and generate
a koha:Depends substvar, from all build dependencies (except debhelper),
and use ${koha:Depends} in the koha-common (not koha) Depends header.
A little bit tricky, but works.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:07 +0000 (13:44 +1200)]
Split off koha-common.
koha-common will be suitable for hosts with multiple Koha instances,
or those that otherwise need to do thing differently from the main
koha package.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:06 +0000 (13:44 +1200)]
Set version number in debian/changelog to indicate upcoming 3.2.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:05 +0000 (13:44 +1200)]
Convert debian/copyright file to the DEP5 format.
The DEP5 format is machine-parseable, which will help keep track of
things in the future.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:04 +0000 (13:44 +1200)]
Switch to native source format.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:03 +0000 (13:44 +1200)]
Bugfix: Install old yui stylesheets, since Koha needs them.
Also fix paths, since we can't install them where Koha expects them,
since that location is used by the Debian packaged yui.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:02 +0000 (13:44 +1200)]
Bugfix: Create the jquery.js symlink for opac to the right target.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:01 +0000 (13:44 +1200)]
Bugfix: Remove Debian packaging files remaining from old packaging effort.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Lars Wirzenius [Tue, 25 May 2010 01:44:00 +0000 (13:44 +1200)]
Bugfix: Remove pointless executable bits from sql files.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Mon, 24 May 2010 15:15:18 +0000 (11:15 -0400)]
removed unconditional warn introduced in previous patch
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nahuel ANGELINETTI [Wed, 12 May 2010 11:44:32 +0000 (13:44 +0200)]
(bug #4487) permit - and . in callnumber plugin
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Wed, 12 May 2010 12:37:17 +0000 (08:37 -0400)]
Correct position of non-sorted table column
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Galen Charlton [Mon, 24 May 2010 15:00:41 +0000 (11:00 -0400)]
Revert "(bug #3798) fix changing request branch"
This reverts commit
ad01b57bcced141cf3c14f3b44e59114adf8024e.
This commit had introduced bug 4526.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Owen Leonard [Wed, 19 May 2010 13:46:12 +0000 (09:46 -0400)]
Corrected: Fix for Bug 4529, columns on circ history all screwy
- fix formatting of last renew date
- Add table zebra striping
- Other markup structure changes
- Revised template assumes that issues.branchcode == checkout library and displays
that value instead of issues.issuingbranch (which is always empty, see Bug 2806)
issues.branchcode seems to reflect the item's holding branch *after* having
been updated as part of the checkout transaction.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Alex Arnaud [Tue, 18 May 2010 07:43:20 +0000 (09:43 +0200)]
(BUG #4521) aqbudgets.pl - Transform undefined budget spent value to 0.00 value
This patch tranform the undefined value of budget spent to a money value which equals 0.00.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Tue, 18 May 2010 16:34:34 +0000 (17:34 +0100)]
Remove obsolete variables from basket.pl
basket.pl calculates variables i, odd and count which are
no longer used in the template
removing them allows some simplification of the main loop
and cuts out on an extra db call
Loop through basketgroups also made more readable
Try to dimish the number of undef warnings filling the logs
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Wed, 19 May 2010 14:00:09 +0000 (15:00 +0100)]
Remove generation of an unnecessary warning
We've checked the return for definedness and
assigned an empty string to it ao we don't want
to make it undef again
This is a good argument that cascading if-elses expecially with
long unstructured elses are a bad idea
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Wed, 19 May 2010 17:42:38 +0000 (18:42 +0100)]
Bug 4510 Script processes single supplier not an array
Script was written as though it had an array rather than
a single supplier. Replaced the excess punctuation with a single
supplier variable
replaced the C-style currency loop with a simpler perl-style one
we only need 1 loop not multiples
Changed variable name $GST to $tax_rate it's not magical and not a constant
and we all know what tax is
Fetch Contract data once rather than twice from two different modules
Correct size of discount data on display
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Nahuel ANGELINETTI [Tue, 18 May 2010 08:02:38 +0000 (10:02 +0200)]
(bug #4522) fix plugin unimarc 210$c
This patch change the way to retrieve the value to insert in the record.
The way it was done, was verry ugly.
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Colin Campbell [Wed, 19 May 2010 09:25:08 +0000 (10:25 +0100)]
Bug 4517 - add authentication to reorder_members.pl
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>