koha.git
15 years agofixed "too many opened files" error during translation
Marc Chantreux [Fri, 12 Dec 2008 17:13:14 +0000 (18:13 +0100)]
fixed "too many opened files" error during translation

The problem was that the TmplTokenizer create global symbols to store file
handlers so the objects aren't destroyed by the garbage collector.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2864 [2/2]: move rss/* to misc/cronjobs/rss/*
Galen Charlton [Mon, 15 Dec 2008 15:58:47 +0000 (09:58 -0600)]
bug 2864 [2/2]: move rss/* to misc/cronjobs/rss/*

As rss.pl is not a CGI script, moved it to join the
other cronjobs.  Full documentation of the script
is in misc/cronjobs/rss/rss.pl, but to summarize:

[1] rss.pl is run on the command line to produce
    an RSS XML document.  The output should be
    placed in a directory accessible to the OPAC
    (or staff) web interface so that users can download
    the RSS feed.  An example of usage:

    misc/cronjobs/rss.pl lastAcquired.conf

    Normally rss.pl should be run periodically (e.g., daily)
    to keep the feed up-to-date.

[2] The configuration file (e.g., lastAcquired.conf) lists

    * name of the template file to use
    * path of output file
    * SQL query

    rss.pl runs the SQL query, then feeds the output of the
    query through the template to produce the output file.

[3] The template file (e.g., lastAcquired.tmpl) uses
    HTML::Template syntax like any of the HTML
    templates for the web interface.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2864 [1/2]: restore rss/rss.pl
Galen Charlton [Mon, 15 Dec 2008 15:58:46 +0000 (09:58 -0600)]
bug 2864 [1/2]: restore rss/rss.pl

Restored basic functionality of rss/rss.pl:

[1] Reverted "Add support for itemtypes. Still need to hardcode 'reservable'"
    Revert commit e7575b00edd6098a869425a69856916108e84914, which had
    replace the script with one of its templates.

[2] Minor fixes to update it, including using HTML::Template::Pro instead
    of HTML::Template, perltidy, and turning on warnings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd default classification sources and filing rules to fr-FR
Frederic Demians [Mon, 17 Nov 2008 16:38:46 +0000 (17:38 +0100)]
Add default classification sources and filing rules to fr-FR

fr-FR install wasn't populating classication rules tables:

  * class_sort_rules
  * class_sources

This patch add default values for those tables
mandatory during installation process.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2829: add a plugin for 010$a field and 210$c
Nahuel Angelinetti [Thu, 11 Dec 2008 15:39:27 +0000 (16:39 +0100)]
bug 2829: add a plugin for 010$a field and 210$c

This plugin use the 'ISBN' field(010$a) to search the "publishercode"(editor) and set it in as 210$c.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2842: ->regexp('syspref') failed for users of iso dateformat.
Joe Atzberger [Thu, 4 Dec 2008 04:33:02 +0000 (22:33 -0600)]
Bug 2842: ->regexp('syspref') failed for users of iso dateformat.

Sticky due date and patron import were the two areas affected.

15 years agoDates expanding to expose some time (HH:MM:SS) granularity.
Joe Atzberger [Fri, 19 Sep 2008 00:02:48 +0000 (19:02 -0500)]
Dates expanding to expose some time (HH:MM:SS) granularity.

t/Dates.t is essentially restored from its previous state with
the revision that it now does not use C4::Context or check syspref
for the default date format.  Instead it sets the C4::Dates default
directly, taking cue from command line argument or ENV.  ISO format
revised to accept "T" separator and "Z" (zulu) terminator. POD
expanded and corrected.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpdate german opac and intranet and french intranet
Chris Cormack [Mon, 26 Jan 2009 07:48:56 +0000 (20:48 +1300)]
Update german opac and intranet and french intranet

15 years agoMore Nederlands updates
Chris Cormack [Sun, 18 Jan 2009 02:38:19 +0000 (15:38 +1300)]
More Nederlands updates

15 years agoNederlands opac update
Chris Cormack [Sat, 17 Jan 2009 07:28:18 +0000 (20:28 +1300)]
Nederlands opac update

15 years agoGerman opac updates
Chris Cormack [Thu, 15 Jan 2009 10:05:47 +0000 (23:05 +1300)]
German opac updates

15 years agoCroatian, German and Greek opac updates
Chris Cormack [Tue, 13 Jan 2009 23:06:38 +0000 (12:06 +1300)]
Croatian, German and Greek opac updates

15 years agoGreek opac
Chris Cormack [Sun, 11 Jan 2009 02:15:15 +0000 (15:15 +1300)]
Greek opac

15 years agoGreek and Dutch opac updates
Chris Cormack [Sat, 10 Jan 2009 07:26:26 +0000 (20:26 +1300)]
Greek and Dutch opac updates

15 years agoItalian updates
Chris Cormack [Fri, 9 Jan 2009 00:56:54 +0000 (13:56 +1300)]
Italian updates

15 years agoThai opac updated, and renaming mongolian
Chris Cormack [Thu, 8 Jan 2009 08:45:25 +0000 (21:45 +1300)]
Thai opac updated, and renaming mongolian

15 years agoMongolian Opac changes and German staff interface
Chris Cormack [Wed, 7 Jan 2009 20:23:43 +0000 (09:23 +1300)]
Mongolian Opac changes and German staff interface

15 years agoCroatian Opac updates
Chris Cormack [Tue, 6 Jan 2009 10:21:07 +0000 (23:21 +1300)]
Croatian Opac updates

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoGerman, Greek, and NZ english staff interface updates
Chris Cormack [Mon, 5 Jan 2009 21:34:46 +0000 (10:34 +1300)]
German, Greek, and NZ english staff interface updates

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoHindi, Marathi, and Mongolian (start of translation)
Chris Cormack [Sun, 4 Jan 2009 06:07:09 +0000 (19:07 +1300)]
Hindi, Marathi, and Mongolian (start of translation)

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoThai intranet and Opac
Chris Cormack [Sat, 3 Jan 2009 07:44:03 +0000 (20:44 +1300)]
Thai intranet and Opac

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoUpdated french opac
Chris Cormack [Fri, 2 Jan 2009 21:21:00 +0000 (10:21 +1300)]
Updated french opac

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoBengali intranet and opac
Chris Cormack [Fri, 2 Jan 2009 20:18:22 +0000 (09:18 +1300)]
Bengali intranet and opac

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoTurkish intranet and opac updates
Chris Cormack [Fri, 2 Jan 2009 09:58:39 +0000 (22:58 +1300)]
Turkish intranet and opac updates

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoGerman intranet, Greek intranet, Tetum Opac, and Turkish intranet updates
Chris Cormack [Thu, 1 Jan 2009 08:21:46 +0000 (21:21 +1300)]
German intranet, Greek intranet, Tetum Opac, and Turkish intranet updates

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoGreek Intranet updates
Chris Cormack [Tue, 30 Dec 2008 19:31:17 +0000 (08:31 +1300)]
Greek Intranet updates

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoUkranian and Russian intranet .po files
Chris Cormack [Tue, 30 Dec 2008 01:58:47 +0000 (14:58 +1300)]
Ukranian and Russian intranet .po files

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoUpdated Norwegian and Polish Intranet
Chris Cormack [Tue, 30 Dec 2008 01:19:57 +0000 (14:19 +1300)]
Updated Norwegian and Polish Intranet

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoLaoo intranet and Chinese (China) Intranet
Chris Cormack [Mon, 29 Dec 2008 20:28:36 +0000 (09:28 +1300)]
Laoo intranet and Chinese (China) Intranet

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoUpdating to 3.0.1 (Dutch Intranet)
Chris Cormack [Mon, 29 Dec 2008 20:22:31 +0000 (09:22 +1300)]
Updating to 3.0.1 (Dutch Intranet)

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoUpdating Chinese (Taiwan) to use the strings in 3.0.1
Chris Cormack [Mon, 29 Dec 2008 20:17:58 +0000 (09:17 +1300)]
Updating Chinese (Taiwan) to use the strings in 3.0.1

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoChinese (China) Intranet po file
Chris Cormack [Mon, 29 Dec 2008 20:14:45 +0000 (09:14 +1300)]
Chinese (China) Intranet po file

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoChinese (Taiwan) Intranet
Chris Cormack [Mon, 29 Dec 2008 19:45:42 +0000 (08:45 +1300)]
Chinese (Taiwan) Intranet

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoGerman opac, intranet, Greek opac and intranet, and Tetum opac
Chris Cormack [Mon, 29 Dec 2008 19:37:21 +0000 (08:37 +1300)]
German opac, intranet, Greek opac and intranet, and Tetum opac

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoThese are actually the opac .po files
Chris Cormack [Mon, 29 Dec 2008 09:44:50 +0000 (22:44 +1300)]
These are actually the opac .po files

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoGerman intranet, Greek intranet and opac, NZ intranet, Armenian Intranet, Tetum Opac...
Chris Cormack [Mon, 29 Dec 2008 09:38:39 +0000 (22:38 +1300)]
German intranet, Greek intranet and opac, NZ intranet, Armenian Intranet, Tetum Opac, and Turkish intranet and opac updates

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoGerman intranet, Greek intranet, NZ english intranet and Turkish Opac
Chris Cormack [Sat, 27 Dec 2008 21:25:43 +0000 (10:25 +1300)]
German intranet, Greek intranet, NZ english intranet and Turkish Opac

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoNZ English intranet, Greek intranet, Turkish Opac
Chris Cormack [Sat, 27 Dec 2008 09:20:01 +0000 (22:20 +1300)]
NZ English intranet, Greek intranet, Turkish Opac

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoGreek, German and NZ english intranet updates
Chris Cormack [Fri, 26 Dec 2008 20:14:31 +0000 (09:14 +1300)]
Greek, German and NZ english intranet updates

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoNZ english file for localisation
Chris Cormack [Fri, 26 Dec 2008 08:18:24 +0000 (21:18 +1300)]
NZ english file for localisation

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoGreek and Turkish staff translations
Chris Cormack [Fri, 26 Dec 2008 05:42:18 +0000 (18:42 +1300)]
Greek and Turkish staff translations

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoGerman and Greek staff translations
Chris Cormack [Thu, 25 Dec 2008 09:23:21 +0000 (22:23 +1300)]
German and Greek staff translations

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoUpdated translations
Chris Cormack [Wed, 24 Dec 2008 17:31:31 +0000 (06:31 +1300)]
Updated translations

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoMore translation updates
Chris Cormack [Tue, 23 Dec 2008 18:28:29 +0000 (07:28 +1300)]
More translation updates

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoLocalisation for NZ english
Chris Cormack [Tue, 23 Dec 2008 10:09:07 +0000 (23:09 +1300)]
Localisation for NZ english

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoCroatian translations plus update Maori translation
Chris Cormack [Tue, 23 Dec 2008 10:06:55 +0000 (23:06 +1300)]
Croatian translations plus update Maori translation

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoMore .po updates
Chris Cormack [Tue, 23 Dec 2008 07:03:11 +0000 (20:03 +1300)]
More .po updates

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoMore .po file changes
Chris Cormack [Tue, 23 Dec 2008 04:19:14 +0000 (17:19 +1300)]
More .po file changes

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
15 years agoMore translations
Chris Cormack [Mon, 22 Dec 2008 19:37:24 +0000 (08:37 +1300)]
More translations

15 years agoUpdated po files
Chris Cormack [Mon, 22 Dec 2008 09:48:20 +0000 (22:48 +1300)]
Updated po files

15 years agoUpdated .po files
Chris Cormack [Sat, 20 Dec 2008 08:47:46 +0000 (21:47 +1300)]
Updated .po files

15 years agoShow "no title", when a notice doesn't have a title
Nahuel ANGELINETTI [Thu, 11 Dec 2008 12:54:05 +0000 (13:54 +0100)]
Show "no title", when a notice doesn't have a title

This patch just check if there is a title, else show "No Title".

15 years ago(bug #2862) improve sql reports
Nahuel ANGELINETTI [Fri, 12 Dec 2008 10:56:19 +0000 (11:56 +0100)]
(bug #2862) improve sql reports

Clear all non-alphanum chars at the end of an sql query.
Use ESCAPE=HTML to escape double quotes in csv export

15 years agominor fixes to UNIMARC_sync_date_created_with_marc_biblio.pl
Galen Charlton [Thu, 11 Dec 2008 16:36:25 +0000 (10:36 -0600)]
minor fixes to UNIMARC_sync_date_created_with_marc_biblio.pl

- chmod 0755
- add newline in error message shown if attempting to
  run in MARC21 database

15 years ago(bug #2856) Activate the duplicate patrons detection and check birthdate only if...
Nahuel Angelinetti [Wed, 10 Dec 2008 16:26:33 +0000 (17:26 +0100)]
(bug #2856) Activate the duplicate patrons detection and check birthdate only if one is set

This patch activate the check of unique member, it was checked but not shown, and the member was added even if a duplicate was
detected.
It improve the duplicate detection, to check the birthdate only if it was specified in the form.
And fix an url of "Yes" link(if the borrower added IS the duplicate detected).

15 years ago(bug #2831) Add a variable, that create a js error, and make the script not working.
Nahuel ANGELINETTI [Thu, 11 Dec 2008 15:48:16 +0000 (16:48 +0100)]
(bug #2831) Add a variable, that create a js error, and make the script not working.

the variable added is numberpattern, and is get from the document.

15 years agoFix something that doesn't work in some perl versions.
Nahuel Angelinetti [Wed, 10 Dec 2008 09:24:36 +0000 (10:24 +0100)]
Fix something that doesn't work in some perl versions.

15 years agofix permissions error introduced by previous patch
Galen Charlton [Mon, 1 Dec 2008 16:38:43 +0000 (10:38 -0600)]
fix permissions error introduced by previous patch

Modules in C4 should not be executable.

15 years agobug 2505: turn on warnings in two scripts
Galen Charlton [Thu, 11 Dec 2008 14:26:10 +0000 (08:26 -0600)]
bug 2505: turn on warnings in two scripts

15 years agoadd calls to clear_syspref_cache()
Galen Charlton [Thu, 11 Dec 2008 15:48:51 +0000 (09:48 -0600)]
add calls to clear_syspref_cache()

temporary until mutator for sysprefs created

15 years agoUpdating po files.
Henri-Damien LAURENT [Thu, 11 Dec 2008 14:40:10 +0000 (15:40 +0100)]
Updating po files.

15 years ago(bug #2854) add the possibility to make a fuzzy search on the barcode
Nahuel Angelinetti [Tue, 9 Dec 2008 16:28:41 +0000 (17:28 +0100)]
(bug #2854) add the possibility to make a fuzzy search on the barcode

This patch add a field that permit to make a "like" and "not like" filter on barcode in the catalog report.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #2853) fix an error in returned string
Nahuel Angelinetti [Tue, 9 Dec 2008 14:15:43 +0000 (15:15 +0100)]
(bug #2853) fix an error in returned string

this patch delete the last char of the returned string, that is not conform to unimarc, only one blankchar must be at the end of
the leader string.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoMissing ";" in javascript
Nahuel Angelinetti [Tue, 9 Dec 2008 10:23:14 +0000 (11:23 +0100)]
Missing ";" in javascript

This patch fix a missing ; in javascript, that open the renew popup. Instead it open it in the current window.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug #2852 encoding problems with custom summaries
Henri-Damien LAURENT [Mon, 8 Dec 2008 19:56:21 +0000 (20:56 +0100)]
bug #2852 encoding problems with custom summaries

decoding data in order to correctly display.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoNo more used since a while.
Nahuel Angelinetti [Thu, 27 Nov 2008 16:39:12 +0000 (17:39 +0100)]
No more used since a while.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoForce MARC::File::XML to use LibXML Parser
Frederic Demians [Sun, 7 Dec 2008 20:37:59 +0000 (21:37 +0100)]
Force MARC::File::XML to use LibXML Parser

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug in rebuild_zebra verbose logging - found another print I didn't want to see all...
Michael Hafen [Fri, 21 Nov 2008 16:34:44 +0000 (09:34 -0700)]
bug in rebuild_zebra verbose logging - found another print I didn't want to see all the time

Add the phrase 'if ( $verbose_logging )' to the two print statements
concerning the skipping of biblio or authority records.

I recently had to split biblio and authority index updating in my cron
script ( had some really big records so had to add the -x switch which
should only be used on biblios accourding to the help ).  So I noticed
that rebuild_zebra.pl printed messages that it was skipping biblios or
authorities.

This patch is to conditionalize those prints based on the verbose
logging switch.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoadd an hidden field with booksellerid
Nahuel Angelinetti [Wed, 3 Dec 2008 16:52:39 +0000 (17:52 +0100)]
add an hidden field with booksellerid

The bug throw because the booksellerid is not in the request, and the newordersuggestion.pl need this one to import
it in a new order.
So I just added an hidden input in the search form.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobetter language check
Nahuel Angelinetti [Thu, 27 Nov 2008 13:43:21 +0000 (14:43 +0100)]
better language check

This patch use a regexp instead 'eq' to find if french is an opaclanguage.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2818 - Allow patron editing to coexist with minPasswordLength and '****'.
Joe Atzberger [Mon, 24 Nov 2008 23:42:33 +0000 (17:42 -0600)]
Bug 2818 - Allow patron editing to coexist with minPasswordLength and '****'.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2752 - comment out problematic DELETE op.
Joe Atzberger [Mon, 8 Dec 2008 16:01:23 +0000 (10:01 -0600)]
Bug 2752 - comment out problematic DELETE op.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug Fix : 2844
Henri-Damien LAURENT [Mon, 8 Dec 2008 16:39:30 +0000 (17:39 +0100)]
Bug Fix : 2844

Some old mysql versions were not happy with the proposed SQL syntax.
Now it is more Mysql version safe.
Adding table names on JOIN

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix POD error introduced in last patch
Galen Charlton [Mon, 1 Dec 2008 17:12:55 +0000 (11:12 -0600)]
fix POD error introduced in last patch

Run prove xt/author/podcorrectness.t to verify
that POD is syntactically correct.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2817: Added support to pull Amazon information based on UPC, EAN, and 13-digit...
Danny Bouman [Mon, 24 Nov 2008 19:21:08 +0000 (14:21 -0500)]
bug 2817: Added support to pull Amazon information based on UPC, EAN, and 13-digit ISBN

By adding support for UPC,EAN and 13-digit ISBN we are able to pull much more content from Amazon, especially on most music and dvd content which
does not have an ISBN.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug #2757: change the opac login generation
Nahuel Angelinetti [Tue, 2 Dec 2008 10:24:30 +0000 (11:24 +0100)]
bug #2757: change the opac login generation

This patch change the method used to generate a new login for a user when his informations are modified(memberentry.pl).

Before the login are generated with the first letter of lastname and the 9 first letter of the surname, and do not verify the
login already exist).
Now the login will be lastname.surnameX, where X is an incremented digit if the login already exists.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2758: don't confirm checkout if fine balance is 0
Galen Charlton [Tue, 2 Dec 2008 16:58:40 +0000 (10:58 -0600)]
bug 2758: don't confirm checkout if fine balance is 0

Fixes problem where if the IssuingInProcess preference is ON,
the operator is always required to confirm a checkout if
the patron has had any fine transactions at all, even if
the patron's balance is 0.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoTrivial cleanup
Joe Atzberger [Thu, 4 Dec 2008 04:33:03 +0000 (22:33 -0600)]
Trivial cleanup

2 FIXME's added.
Vestigial "8-character tabs" comment removed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2675 users public lists do not show on opac-detail.pl
Allen Reinmeyer [Wed, 3 Dec 2008 18:10:50 +0000 (12:10 -0600)]
Bug 2675 users public lists do not show on opac-detail.pl

Code change actually occurs in opac-addbybiblionumber.pl accessed via opac-detail.pl.
Bug fix allows for users to select the 'save to lists' link and add item
to their private, public and all open lists.  Previously, only private
and open lists were retrieved and listed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoMinor logical cleanup.
Joe Atzberger [Mon, 1 Dec 2008 21:38:07 +0000 (15:38 -0600)]
Minor logical cleanup.

The conditional assignment previously was:
    $norequests = 0 && $norequests if ....

The execution of "0" served no purpose.
Also consolidated RequestOnOpac logic to the one line that cared about it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoComment out unused variable.
Joe Atzberger [Mon, 1 Dec 2008 21:38:06 +0000 (15:38 -0600)]
Comment out unused variable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoPure whitespace edits. Trying to make members more readable.
Joe Atzberger [Mon, 24 Nov 2008 23:42:32 +0000 (17:42 -0600)]
Pure whitespace edits. Trying to make members more readable.

Use git diff -w to show only one line (a blank one) was edited (removed).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix permissions error introduced by previous patch
Galen Charlton [Mon, 1 Dec 2008 16:38:23 +0000 (10:38 -0600)]
fix permissions error introduced by previous patch

Modules in C4 should not be executable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoTranslating UNIMARC plugins in English
Henri-Damien LAURENT [Mon, 24 Nov 2008 21:31:24 +0000 (22:31 +0100)]
Translating UNIMARC plugins in English

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCorrections and tweaks to recent lists fixes.
Owen Leonard [Mon, 24 Nov 2008 20:34:18 +0000 (14:34 -0600)]
Corrections and tweaks to recent lists fixes.

Corrected an instance where <!-- TMPL_IF --> was embedded inside an HTML tag (conflicts with translation script). Modified styling of confirm button to match existing interface convention.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agocreating update database for 3.0.1
Henri-Damien LAURENT [Mon, 24 Nov 2008 16:44:58 +0000 (17:44 +0100)]
creating update database for 3.0.1

- adds 2 new sys prefs AllowRenewalOverride and MergeAuthoritiesOnupdate AllowRenewallOverride
MergeAuthoritiesOnUpdate
- set null issues.issuedate to lastreneweddate
- Adding some changes in Database for bugfixes only UNIMARC

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago[bug #2750] Cannot return to another branch if the independantbranch option is set...
Henri-Damien LAURENT [Mon, 24 Nov 2008 08:43:32 +0000 (09:43 +0100)]
[bug #2750] Cannot return to another branch if the independantbranch option is set as ON

The code was modified to change the holding branch ONLY if the return to
the right branch is done. If you set IndependantBranch to on, you must
return the document to the HomeBranch.
And verify the return is done before show the message that allow to
transfert the document to another branch.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAllow renewal limits to be overridden
Henri-Damien LAURENT [Mon, 24 Nov 2008 05:29:58 +0000 (06:29 +0100)]
Allow renewal limits to be overridden

Originally by Jesse Weaver <jesse.weaver@liblime.com>

This patch creates a new system preference, AllowRenewalLimitOverride,
that, if YES, allows the renewal limit to be manually overridden. It
updates C4::Circulation and reserve/renewscript.pl to obey this.

Adapted for 3.0 : Henri-Damien LAURENT
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBugs 2541 and 2587 - AddIssue must return date object as intended.
Joe Atzberger (siptest [Thu, 11 Sep 2008 03:30:04 +0000 (22:30 -0500)]
Bugs 2541 and 2587 - AddIssue must return date object as intended.

SIP actually relied on the AddIssue return that was not reliable.
AddRenew also updated to return C4::Dates object for datedue.

Please note, any running SIPServer will have to be restarted
*immediately* after applying this patch, because although Koha
C4 behaves as normal, the SIP server runs as a Net::Server with
components cached.  Changes will not be applied until SIPServer
restarts, and so checkout actions may fail until then.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago[REPLACE previous] Removing map calls in void context
Henri-Damien LAURENT [Wed, 19 Nov 2008 15:03:50 +0000 (16:03 +0100)]
[REPLACE previous] Removing map calls in void context

Thanks Joe.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUpdate MARC to add 099$c and 099$d fields, with :
Henri-Damien LAURENT [Fri, 21 Nov 2008 21:37:04 +0000 (22:37 +0100)]
Update MARC to add 099$c and 099$d fields, with :

This allow the acquisition date sorting in UNIMARC.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUpdating default UNIMARC framework
Henri-Damien LAURENT [Sat, 22 Nov 2008 06:17:44 +0000 (07:17 +0100)]
Updating default UNIMARC framework

The previous one was out of date and contained some errors.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2801 and other cleanup.
Joe Atzberger [Tue, 18 Nov 2008 16:33:54 +0000 (10:33 -0600)]
Bug 2801 and other cleanup.

In addition to documented bug:
~ SearchString took an unused argument,
~ refactored repeated code into column_picks(),
~ fixed display during delete_confirm, including "name",
~ removed unused C4::Dates dependency.

Resend: typo fixed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2531 followup
Galen Charlton [Fri, 21 Nov 2008 00:12:42 +0000 (18:12 -0600)]
bug 2531 followup

* & -> &amp; in URL for XHTML validation
* (unrelated to prior patch) remove broken link to
  button-bg.png for confirm button

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug #2531 Cannot delete private shelf
Allen Reinmeyer [Mon, 17 Nov 2008 21:10:27 +0000 (15:10 -0600)]
Bug #2531 Cannot delete private shelf

Added logic to create a list of private lists to check on deletion.  Multiple pages have the ability to delete lists, both private and public.  Default option of retrieving a user's lists is retrieving the public ones.  Now private lists of the owner are retrieved as well and checked upon deletion request.  This allows any method of deletion to delete the correct list without examining the myriad of options currently used to indicate display of privateshelves and expect all pages to know whether a shelf number comes from a private or public list.  Since deletion occurs based on shelf number and the virtualshelves table has a primary key on shelf number, this will not cause unwanted deletion of shelves.

UPDATE:  added logic for conditional creation of shelves.  Also note change in staff side as deletions worked except for viewing a populated shelf, then deleting.  The confirm message showed, but the display was of public shelves, not private.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2365: Serials prediction errors: Roll-overs occur with wrong issue in some cases.
Ryan Higgins [Wed, 19 Nov 2008 15:55:38 +0000 (09:55 -0600)]
Bug 2365: Serials prediction errors: Roll-overs occur with wrong issue in some cases.

See bugzilla for details.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoproblem saving authority with ? and other special characters [resend]
Henri-Damien LAURENT [Wed, 19 Nov 2008 14:36:18 +0000 (15:36 +0100)]
problem saving authority with ? and other special characters [resend]

Filtering those signs in order not to have them interpreted.
Removing some warns

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoImproving UNIMARC(A) compliance
Henri-Damien LAURENT [Wed, 19 Nov 2008 10:59:29 +0000 (11:59 +0100)]
Improving UNIMARC(A) compliance

Adding some fields to index.
Adding also some indexes in order to be able to query specific fields.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUse biblioitems.itemtype as a default for items.itype
Michael Hafen [Fri, 12 Sep 2008 19:16:58 +0000 (13:16 -0600)]
Use biblioitems.itemtype as a default for items.itype

This correct the html select default in additem.pl, and enforces use of
biblioitems.itemtype as the default in Items::AddItem.  The code in
Items is to catch items added through MARC record staging.

Thanks to Joe Atzberger for suggestion.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix for bug 2447: yuipath variable not getting passed to help pages
Jesse Weaver [Fri, 22 Aug 2008 15:54:30 +0000 (10:54 -0500)]
fix for bug 2447: yuipath variable not getting passed to help pages

This updates help.pl to pass the yuipath variable correctly. It also adds some script references to help-top.inc to avoid other js errors.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>