Updating history docs
(cherry picked from commit 0060b10af9acdc9eb0b5529d96de29375b8c79d0)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5700: MT4004 : additem.pl Some Status were not defaulted to the correct value Status 0 was lost because test was done on value and not on the fact that a value was defined or not. when value is 0 then it was not used as default value for

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 14422c8ed9df29a6b89e8afe69c4d05056618124)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5699: don't discard $3 when building a record (UNIMARC specific)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 60e0a76fc027ff8d97c3630fce0a7b8222b6d5fd)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5691 - Delete all items respects independentbranches system preferences

Squashed commit of the following:

commit 66cdb8804136803a3f626d183c8f192f61f3c7b1
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Fri Feb 4 12:55:10 2011 +1300

    Bug 5691: Updating copyright statement

commit 79ef6c269afc9c644c51709a7657542a0fc6d7d6
Author: Chris Cormack <chrisc@catalyst.net.nz>
Date:   Fri Feb 4 12:52:13 2011 +1300

    Bug 5691 - Fixing a syntax error and tidying up some formatting

commit a66485dba113c05ed51a3b4ff19f788e335aa1f6
Author: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Date:   Tue Oct 5 17:23:55 2010 +0200

    (MT #1365) Delete all items

    Using DelItemCheck in cataloguing/additem.pl
    when deleting all items

commit fe845fd48ab22ff82ad6d8971c468c327b49f3c4
Author: Christophe Croullebois <christophe.croullebois@biblibre.com>
Date:   Wed Sep 22 11:39:28 2010 +0200

    (MT #1365) Delete all items

    Now if IndependantBranches is on and a user try to delete all items, only the items of his branch will be deleted.
    A message explain this fact.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Followup: (MT #1365) Fixing up the English idiom
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit a4cc394508182f292b4767504dfbac882744c3df)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5532 - sysprefs editor should show names of saved prefs

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 7acfb3a17f9ab592b385b032c93c96d6894ff821)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5689 - System preference notifications are not translatable

Defining strings in the template so that they can be translated.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit aac253a5e0192b14dfa23e34c76629020c392bca)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5115, Tags JavaScript includes many untranslatable strings

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit dec6be9148ec28b240015762cdeb7019fbfadeb6)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5690

MT3947: items.timestamp were not updated on edition

If items.timestamp is used in the framework and hidden
the fact that it is NOT deleted before update is done would input the previous timestamp,
which is not the desired behaviour.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 60dd25b5c230249581a9736458aad4bad783dd52)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fixing a syntax error, that snuck in with a merge
(cherry picked from commit e29aca325d199468673365ee7540760b38630833)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 3319 - Need error message when adding patron and libraries are defined

- Hiding patron add toolbar when branches or categories are undefined
- Blocking patron entry form if branches or categories are undefined
- Removing nonfunctional template logic for displaying missing category
  error message.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit e6a3029470501b3a8269986c1448d5f8b2d6b7f2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 3212 Force leader 9 position to 'a' for new biblios

When Creating a new biblio record, if the cataloguer doesn't use the leader
plugin, a biblio record can be saved with a leader not containing a 'a' in 9
position. If the biblio contains UTF-8 characters, its decoding can fail.

This issue applies to MARC-21 not UNIMARC.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f1f36a0c940fa53a5671b379a31d77c2cbe40a7f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5673: test guarantorid consistently

Incorrect checking of guarantorid was causing moremember.pl to
try and construct addresses using data from non-existent guarantors
ensure that test is consistently checking that value is defined and not
'', '0' or 0 [ i.e. what perl does for you anyway!!]

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 49b5f77194ccf688e95b3fbb5f08ea5ba18f7f7e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 2341: items marked 'on order' not reserveable from search results

Items created as part of the acquisitions process, and assigned the temporary notforloan value of -1,
cannot be placed on hold from the search results in either the OPAC or staff client (the link is missing).

This patch changes the evaluation of items->notforloan from a Boolean (if $items->{notforloan}) to a comparison
(if $items->{notforloan} > 0).  Any notforloan status with a negative value can therefore be reserved.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f692123bf1b2b843d348a897852018caa04de76f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug: 4263 - Repeatable subfields in items

Squashed commit of the following:

commit f441094d5095d165eab18340c983a831cce8f6e0
Author: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Date:   Mon Jul 5 20:33:23 2010 +0200

    bug4263 followup : Can't blank subfields

    Previous bug4263 reintroduced bug 2466: fix clearing item field
    This keeps bug4263 followup to be assigned (donot blank dateaccessioned)
    But also allow to blank item subfields.

commit 92889b766c41b48bdd0e3a33ca4b183b1e259805
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Fri Apr 23 13:54:30 2010 +0200

    (bug #4263) dateaccessionned is cleaned on item modification

    Every item modification, date accessionned is cleaned, if there is no modification made, we must'nt reset to "undef" the value.

commit 5abb2db16b2564d32e84b7cc680acbc301d73179
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Tue Mar 2 09:57:33 2010 +0100

    (bug #4263) fix the edition of items with repeatable subfields

    The subfield management in item level is broken, fields are concatenated in one field, and if the librarian edit it, the values are not selected.
    This big patch fix three things:
     1) saving fields that are stocked in SQL(using koha2marc mapping) are now well cut and separated in _REAL_ subfields
     2) loading records with repeatable subfields are now well returned
     3) Editing items with repeatable fields works well

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 4263 Removing extranious block of code
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit aa398ed055a7226ba02d6559b297cb172b3ce3df)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 4931: Stocking can be by homebranch or holding branch

Squashed commit of the following:

commit 105de81639cbac5084e4a5c099b19569043e69ff
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Tue Jul 13 11:58:01 2010 +0200

    (bug #4931) fix forgottens input in buttons

    the previous patch missed an hidden input in next buttons that break next page. This fix it.

commit db00295a6b9d1d36fc888ba6a0558011fd6884ba
Author: Nahuel ANGELINETTI <nahuel.angelinetti@biblibre.com>
Date:   Fri Jul 2 15:27:59 2010 +0200

    (bug #4931) add the ability to choose home or holding branch in stocktaking

    This add radio box in stocktaking to base it on home or holdingbranch

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Bug 4391 Followup: Adding back lost declaration of $branchcode
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 35b47b6ff71ea2bcfc699ec35132756d01bfadd3)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Updating history docs
(cherry picked from commit c269dfdeb49ac45d492edde5b1ad1f67d01aff65)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5661 Fix a problem when doing an authority search with no sort order

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 079796ed189541a0f04126c97e97cad50fb18783)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5681: Fixes leading zeroes in Add Mulpiple Copies

From Biblibre:
I don't know why, but removing sprintf solves the problems with leading zeroes
and the problems with large values.

(written by jean-andré santoni)

Note from Chris:

The width is never set, so the sprintf always defaults to a float, which
trims the leading zeros. I am not smart enough to figure out how to set
a valid width when calling it, and removing the sprintf seems to work
See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5681 for
test results

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4f7bcdcbae336d7cceb71b60f77a8ba2249b0f54)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5683 - it is possible to save corrupt records

This patch makes it impossible to save records with variables fields that don't
contain any subfields. Prior to this patch, link_bibs_to_authorities.pl would
sometimes corrupt records.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 428556cd130db0cfcffd6fe081f32dc1218a904f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Updating Version Number to 3.02.03.001

Updating Version Number to 3.02.03.001

Bug 4160: Currency conversion doesn't handle rates other than 100

Changes data type for currency.rate to accomodate bigger currency conversion rates.

FLOAT( 15, 5 )

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5665: Routing slip prints too wide for narrow printers

This patch switches off some min-width styling which causes right hand
of page to be clipped.

Work sponsored by Opus

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 241fa939b48b2eb7e87360f2e47073df0b64af25)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5452 - Overdue date color in borrower's today issues

Patch sent by Fridolyn SOMERS, but not in git format
(cherry picked from commit 1c461680c89fb73d0df55260dc9173899bcd032b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

BUG 5649: Change wording on review.tmpl from white\black to approve\rejected consistent with the rest of the page

Changes the wording on review.tmpl from white\black to approve\rejected consistent with the rest of the page

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 460a7b566bded878b4fd800f8baa98e83e32e38b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5477 [SIGN-OFF] Fix test cases that require database access

This moves the DB-requiring tests out of the way, with the exception of
00-load.t which is used by the git hooks. For it, it makes it skip
loading problematic modules. This allows 'make test' to complete successfully
without a database configured, wich is a required part of making packages.

This has been tested against the v3.02.03 tag and the master branch.

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9df2a4a8fc24ebb693ffb80a218b12137f8b282d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5376: Batch Mod and Delete require superlibrarian permissions

This only occurs with IndependantBranches turned on; in an attempt to check that the items being
modified belonged to the user's branch, the code made a simultaneous comparison and assignment,
which is not permitted in all compilations of Perl.

Splitting the assignment of $itembranchcode and the check for its non-null value fixes the problem

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 12c116236f0f686005bbe035659778012bcaf862)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Translation updates

- Two new languages:

  . sd-PK - Sindhi
  . is-IS - Icelandic

- Fix a naming error for nb-NO and nn-NO
(cherry picked from commit 671419dcce781aa01f300012f0f425c040749f73)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5654: remove disused directory

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 34ba87625a80701cce7a1ffca9fab1f3691bb3ab)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Adding Jerome Charaoui to the history docs, 130 people have code in Koha now
(cherry picked from commit 7f4771588e08dc418d304f249efad03dde67fdbb)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

History updated
(cherry picked from commit 7d87094fc84a88584af72f27e10509b2ef5416de)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5506 Fix installation of prefs translations in standard installs

[3.2] Should be applied

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 1fc16ea5431eba97b7562a94e6493249d4e700f7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Updating Version Number to 3.02.03.000

Release Notes for 3.02.03.000

Bug 5327 fixing missing number of tests
(cherry picked from commit d64008644a72d88e8ab5442cb24ff64d23665a8f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Added more unit tests to check when JSONStream should fail.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 5f0f2e297a7d7e51dc7503493025c14d39944757)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327: Added unit tests to Output_JSONStream.t

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 434d9a3c66c54c028c971a0bd59312d099ba358a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327: small typo in the Members.t test
(cherry picked from commit 1c89ce34b914cd5247cb6103b9bda5cde9720dcb)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 Made test file for Accounts.pm

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 669280c7ab200637f06a5b6852409f7207f68403)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327: Shifting and little tidy up of the members tests
(cherry picked from commit 314772637ce23285defd5372c772c3562c560fc2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 Some tests added

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d567945517021ed093c7ec7c246514cea444df12)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 - Now we are doing db calls, we need to shift this to t/db_dependent
(cherry picked from commit e03026adffe58561db842f7dcf8dcb064539b224)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Added unit tests to test all of get_amazon_tld in Amazon.pm.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b56121db026837e3d6d6e7e7f3800d7a5b92923c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327: Little change to Record.t
(cherry picked from commit 23f92a8f8dcded82bf5c3b319f373350a011e078)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 1 more test added.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 5aa80408756c14565481259a927ab40488a4bd00)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Added unit tests for Biblio and moved it to db_dependent as it requires the database.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 65e2cda8d2dcb89c0af6b6bcf07118e05b0123e8)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 Cleaning up XISBN.t a bit
(cherry picked from commit 4093615e9f2f79f8738769edbfb4b41733b284da)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 - Fixing a path issue with XISBN.t
(cherry picked from commit 71a7d2ad389ff946c5fc65293240caf3d3e290f6)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 litte fix for Background tests
(cherry picked from commit c8ba99e155cc3357edfc30c23e4b4e5797b241c3)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 shifting database dependent modules and scripts to t/db_dependent
(cherry picked from commit eff21765f9784e09905042dd7080cbef099306d9)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5327 updated test file

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit cc039cdb0f29e800d300a0c3688645fb83075bf9)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Added unit tests using a test database for XISBN.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 52762c6c798548536a57fb0a10b0b1590e75b925)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Created unit testing using the testdatabase for XISBN.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f2d575c92c8f445ac41acb2b78c52a5d7be17b6d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Added extra unit tests to Debug.t

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 3b22fc6cc0267473fea7f7431ce9bc9861145b0d)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5327 started testing

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 80f8c41e4c5da0263b25b6c4bfd894f0113777cc)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 Starting tests for BackgroundJob

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 594a31bfe12465f281bb6e8acaa3e5d6b4083fb9)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 Starting Unit Tests for Auth.pm

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 3df717479cd7e19fef2d6d18300636391f1d2b5b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 removing uneeded tests

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 81f9c4976c171aae6e7f630dc8eb27a3e5424bb0)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5399: Follow up style patch, moving exits out of subroutine
(cherry picked from commit 12741cfafa7513ee7b4627863c18346cb8507873)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5399: remove useless eval 'use C4::Foo'

Also add a couple FIXMEs

Marcel: Signed and updated for current master

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4532ca70bc5842667c6ff53d9fec5d7e7b4f4317)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Adding a new developer to the history
(cherry picked from commit eae38fa6800454db627c4ab7e5a50ec17f42e018)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5403 Remove DisplayISBN and GetPublisherNameFromIsbn

These two subroutines were no longer being used by any other code
removed them from their respective modules
If we need any ISBN in future we should use Business::ISBN directly

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit a61db4986d7635e2eadb32f4df7332261e773826)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5327 - Adding UNIT Tests.

Squashed commit of the following:

commit 146d14665c52edaa85e38b70aabc9d52be5d64b6
Author: Zach Sim <joseph.zachariah.sim@gmail.com>
Date:   Mon Jan 17 16:07:24 2011 +1300

    Edited DisplayISBN to cleanup the ISBN using _isbn_cleanup if it is not 13 or 10 digits long.

commit ba97b26d9a25470b0717cdd60a3d4f7a5c459ca9
Author: Zach Sim <joseph.zachariah.sim@gmail.com>
Date:   Mon Jan 17 16:06:14 2011 +1300

    Added extra unit tests to test C4::Koha::DisplayISBN.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 53a301b8f20ba285c8e483aa6d5a3b2539380ccb)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 4885 - Only 1 ISBN shows in non-XSL detail view

Fixed by doing a pretty dumb copy of GetMarcNotes. Functional,
but it could be there is a more efficient way to do it given
we want one repeating tag rather than a range of tags?

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
- fixed small typo in opac-detail
- corrected isbd punctuation in opac-detail
- tested with 0, 1, 2, 3 isbns in 020, MARC21
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 3459, topissues doesn't take care of ccode

- Change conditional to display filter in sidebar without EXPR
- Enhance switch between ccode default and itemtype default searches
- Enable preselect of submitted collection code in filter form,
  stealing code from opac-search.pl

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f45969422c55f34edec3145b7e2fa1a85222932f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 4438: incorrect "Budget total exceeds period allocation" error when editing fund

The process in check_parent_total for period allocation was not good.
It took all the children of a period.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 9bf9e2d9b4408579667d904ec94d064dc0c8f882)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5006 - Invalid XHTML in record matching rules template

- Rework JavaScript clone routines to use jQuery, to take
  label "for" into account, to handle incrementing label,
  and to properly place cloned blocks at the bottom of the group
- Rework JavaScript delete routines to use jQuery, to take
  block label numbers into account, and to show the "add"
  link if you have deleted the last block.
- Correcting markup which nests <div> inside <fieldset>
- Ensuring labels' "for" attribute matches input IDs
- Adding "required" style to required fields

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

(bug #3743) fix acquisition stats ordering

This patch fix ordering in acquisition stats to order by month number.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit e8de8b97c66a67427f4b458e2c3f3e43ea43d963)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5611: Simple typo fix in the comments
(cherry picked from commit be37db49fb329f8911dabb0d12d2a6e09bb9dc91)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Typo fix for history file
(cherry picked from commit 3153abe61b441ee8b4088c9b13f2954c63546cab)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Adding release info, and missing meetings to the history
(cherry picked from commit 31993509b21b61f8b0546dd6b71cfa6d9801dc9e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Adding new developers to the history

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5611 Tidy up C4::Scrubber

Remove the unneeded package variables
Remove unnecessary variables
Removed some cargo-cult programming
Tidied the indentation from mix of tabs & spaces
Add a Test that we actually return the required class
of object

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 073fb1aee655f9f29e99cc56ddf584eb6c7813a9)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5611 INIT block causes failure with mod perl

Per module INIT Blocks are not run in mod_perl so their
variables are not visible. A lexical var is adequate
for this purpose

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit e0d76bd88d25e87f9d8f450f1c4e029812eacf02)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5601 :: Add tests for bugfix

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0d5029ec5b3b95a3e38b67aa1aa1be6196e19dfb)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5601 Fix processing of DueDate return

item duedate is not a datetime entity but a string retrieved
direct from the db that only needs restructuring
checkout was doing so but item_info was pretending it was in secs
(actually Item.pm manipulated then overwrote it!!)
assume the date in the db is correct (otherwise madness ensues)
dont try to second guess it
As duedates do not yet include a time element assume end of day
as a safety first

[F. Demians] I confirm Joe Atzberger diagnostic. That's a bug reported by a
library. I've tested Colin Campell solution. It fixes the bug.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d4842d45601bd0f9c1bd33bf7978586ae746888f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5055 Use standard file paths in crontab.example

This is a revised patch, removing the lines pertaining to logrotate.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit af60ade73b0ac5c15308994632b45f99b0b8ae1b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 4131 have subscription so edit routing if one exists

Changes the template variable checked in serials-menu.inc for determining where to
show 'Create Routing List' or 'Edit Routing List' to hasRouting.

Also adds the $hasRouting variable to serials/routing.pl and serials/routing-preview.pl,
for completeness.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b7fdfc1384a749471f2c9a00b910b063778085e2)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5486 remove note about HomeOrHoldingBranch being removed soon

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 50694f39594f1f4fcfd0efe28a1f47ab6c23bfd7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5603: advance_notice.pl uninitialized element in hash

Changings one of the LEFT JOINS in C4::Members::Messaging::GetMessagingPreferences
to a JOIN to prevent NULL message_transport_types from being returned

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 8185db47878630399eedc8ca227ab0e111a3acad)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5492 update import patrons page title

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4173f2221fd0387e670c40bd4da18223e79f2244)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5604 additional icons in the Seshat icon set

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d1ef8313609bb5617a6c3439b55da5e4df96e88f)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 4945 - Patron search is limited by default to the currently logged-in library

I couldn't figure out how (or whether) GetBranchesLoop could be
convinced to return a list of branches without selecting one, so
I swapped GetBranchesLoop with GetBranches. This will preselect
a branch only if a branch has been submitted as part of a query.

This does NOT preselect the correct branch when IndependantBranches
is turned on.

I also added a template variable which is true if a query has
been submitted with a branch or a category so that the extra
form fields can be displayed, reminding the user that they
added limiters to their query.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 98efac4c0a3c6dfd857901ce6c639f93bcda8b76)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

(bug #3737) fix title search in order history

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 15334926adf722083f03553eed575d056e907ad1)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5589: Remove duplicated Exports in Suggestions.pm

Rather bizarrely Suggestions.pm was setting up @EXPORT, @ISA
and $VERSION twice. Have removed one invocation

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d1172b98d9a2b8dde3c700b0d116816b4d45fa26)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 4984, Invalid XHTML in staff client search results

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 1b344bdbd1475efa0bb4f919521ed3ee0e86874b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Additional fix for Bug 3550, Use GetRecordValue to get the subtitle

- Adding subtitle to Hold Ratio report output
- Sorting by default on ratio, descending
- Adding author
- Removing description

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 05c240953a7989af72c461bd9e2e37bac0fe2a66)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Follow up on fix for Bug 5570, item types not showing on other editions

Fix for the staff client.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 811023934af8464bf943caa06c3d156a766d1b16)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5570 - item types not showing on other editions

The item type which shows on other editions is the biblio-level
itemtype. XISBN.pm had some item-handling code, but I'm
removing it because it is unused. The editions tab should
now display item type only if item-level itemtypes are not
enabled.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit bbd50b2d1219c904f3a7db3cfa49feca13bd8278)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5480 Some usual UNIMARC cataloguing plugins doesn't work anymore

[3.2] To be applied

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5583 Rename fieldnumber to blocknumber

Variable fieldnumber does not refer to a field
It is the ISBD block number
Rename to blocknumber
Say what we mean adds to maintainability

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 926ab8c54486a3cd5491d119dd0024ef94980d5b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5582 Pass tag nums as a string to Doc Popup

Add quotes around tag number when calling doc popup
Otherwise numbers with leading zeroes are interpreted
as octal e.g. 020 returns doc for 016

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 782654d178ada36ea834c1738ec20e4df7956a19)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5585: fix display of current date on receipts and slips

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 80641597e548d3757c8b5c9274b85cc75059415b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Removing OPACNoResultsFound Enhancement Syspref

This pref was accidentally added during non-English syspref updates.
It is properly a part of enh bug 1997 which will not be included in
the 3.2.x branch.

Fix for Bug 3347 - Inconsistencies with tables in opac-shelves.tmpl

Changes to list contents view to make it consistent with search results

My intention is to make the OPAC more consistent in the way it displays
lists of items, whether it be in search results, lists, etc. This patch
adds data to the list contents output and reformats it to that end.

The other significant change is the removal of jQuery table sorting.
Since list contents are both sorted and paginated on the server
side. Adding a client-side sort to one page of many doesn't make sense.

Other changes include:

- Change "Your lists" to "Your private lists"
- Remove "sort by" column because it seems unnecessary
- Adding logic to control display of count (item or items
  rather than item(s)
- Styling pagination bar and placing at the bottom of the page,
  consistent with other instances of pagination navigation

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 4950 - checkbox should be removed when can't place a hold

- Hiding form controls for titles which can't be placed on hold
- Highlighting hold blocked message for better visibility
- Showing table of blocked holds even if none can be placed on
  hold: hiding the table hides the messages explaining why
  titles can't be placed on hold
- Removing an unused line from the script which was leaving errors
  in the error log
- Consolidating error messages into one box which were displaying
  in two.
- Correcting link to unused opac-userdetails.pl

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 5571 - tags as bulleted list too long

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5419: make reason checkouts blocked stand out

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit f379638c9d1921e8663e2c8c5bfabe27af42a666)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

bug 5497: make all library fields available to circ receipt/slips

This allows the receipt template to be more readily customized
to include the library's address, phone number, email address, etc.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 4daef50c7a554e6ef2b83e29ac877a70366bddfa)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Fix for Bug 3918 - Add to order lists inconsistent

- Added new include to contain add to basket options
- Minor markup corrections

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 562653bc8d76414e40fa229afcec3320f3b2cf1a)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>

Bug 5375 (Update date/time last transaction (MARC 005) when saving authority record)

Update 005 date/time when saving authority record for MARC21 and UNIMARC.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 11908331497c514b8ba224f30dfff00277f7f42b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>