koha.git
13 years agobug 5311: correction to database update
Galen Charlton [Sat, 30 Oct 2010 03:49:14 +0000 (23:49 -0400)]
bug 5311: correction to database update

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0d84902eca94fca399040e3c0088ee74f69cf68c)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdate language mappings to fix Bug 5311
Jared Camins-Esakov [Sat, 30 Oct 2010 03:49:13 +0000 (23:49 -0400)]
Update language mappings to fix Bug 5311

This patch updates the language_rfc4646_to_iso639 mapping table with the
correct mappings for several languages that were not mapped correctly to
the codes used in MARC, including Finnish (which was not mapped at all),
and Armenian (which was mapped to an obsolete code). This patch also
changes English and French to use the proper three-letter codes, which
will eliminate false positives when, for example, limiting by French
brings up results in Afrikaans.

This patch adds the changes to the updatedatabase.pl script, and removes
the incorrectly specified DBversion in the previous patch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
13 years agobug 5190: improve linking to MARC field documentation
Galen Charlton [Sat, 30 Oct 2010 02:35:44 +0000 (22:35 -0400)]
bug 5190: improve linking to MARC field documentation

* zero-pad tag numbers as needed
* handle special case for linking to UNIMARC 0XX vs. 1-8XX
* add a wrapper function
* add comment about the poor linkability of IFLA's UNIMARC documentation

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 141ec0b9bcfa0bcf34d82cbb7ddc722a078e216e)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5190: link to MARC21/UNIMARC online doc in the bib editor
Galen Charlton [Sat, 30 Oct 2010 02:35:43 +0000 (22:35 -0400)]
bug 5190: link to MARC21/UNIMARC online doc in the bib editor

Patch from  Tomás Cohen Arazi <tomascohen@gmail.com>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 29432ee42cf25d79f28054eaea85f46edc688d1b)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5326 fix link to old prefs editor on patron attributes
Nicole Engard [Sat, 30 Oct 2010 00:28:49 +0000 (20:28 -0400)]
bug 5326 fix link to old prefs editor on patron attributes

on the patron attributes page if you have ExtendedPatronAttributes
turned off the error points you to the old sys prefs editor - this
patch fixes that

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 45a6cca1a17093291dc6ab0883578b79bff0b6e7)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5326 fix extended patron attribute error
Nicole Engard [Sat, 30 Oct 2010 00:28:48 +0000 (20:28 -0400)]
bug 5326 fix extended patron attribute error

the error message if you have ExtendedPatronAttributes turned
off linked to the old sys prefs editor, link has been updated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 83f03fb9d3bbbf5101a7209f934e91b7876fc2dc)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5137, Remove obsolete code counting issues by item type in circ
Owen Leonard [Fri, 29 Oct 2010 12:37:41 +0000 (08:37 -0400)]
Fix for Bug 5137, Remove obsolete code counting issues by item type in circ

The removed section of code contained a "my $dbh = C4::Context->dbh"
which was required for the query of BOR_NOTES. That line has been
moved accordingly.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit b2bda465d770c078b14eef8493c0554143d90cc4)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5008 - "Remove" link missing when Cart in expanded view
Owen Leonard [Fri, 29 Oct 2010 12:29:02 +0000 (08:29 -0400)]
Fix for Bug 5008 - "Remove" link missing when Cart in expanded view

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0d41ba7300a228217ac32a1169bf24b0e79aff98)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 4986 move serials prefs from cataloging tab to serials tab
Nicole Engard [Fri, 29 Oct 2010 12:23:41 +0000 (08:23 -0400)]
bug 4986 move serials prefs from cataloging tab to serials tab

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d1593acec727c6aa06fc0d3159c62b454d225518)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5114 - Can't edit basket in Internet Explorer
Owen Leonard [Fri, 29 Oct 2010 12:15:37 +0000 (08:15 -0400)]
Fix for Bug 5114 - Can't edit basket in Internet Explorer

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit 0bb33cd7ceee5cdb8bf2a5bcde552257f2279cfb)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5019 remove link to funds
Nicole Engard [Fri, 29 Oct 2010 12:10:44 +0000 (08:10 -0400)]
bug 5019 remove link to funds

This patch renames the link to budgets to say 'budgets & funds'
and removes the links to funds (which went no where).

This patch also adds the acq menu to the budget pages.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit d5eb56dd528d29aace607f2994ff7fc2c132db57)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5177 Selecting default sort result by syspref
Frédéric Demians [Fri, 29 Oct 2010 11:47:33 +0000 (07:47 -0400)]
Bug 5177 Selecting default sort result by syspref

Syspref .pref file was defining a code for descending order which wasn't
expected by .tmpl files... 'desc' instead of 'dsc'.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit aa7df17f7c63ae51f8d2088b795af6d92b85e6a0)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5363 - Removing unused module (C4::Cache::FastMemcached)
Chris Cormack [Wed, 3 Nov 2010 20:31:03 +0000 (16:31 -0400)]
Bug 5363 - Removing unused module (C4::Cache::FastMemcached)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoCorrecting Version Number for 3.2.x branch
Chris Nighswonger [Wed, 3 Nov 2010 18:42:50 +0000 (14:42 -0400)]
Correcting Version Number for 3.2.x branch

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 4141: fix upgrade of OPAC XSLT parameters from 3.0.x
Galen Charlton [Wed, 3 Nov 2010 17:49:00 +0000 (13:49 -0400)]
bug 4141: fix upgrade of OPAC XSLT parameters from 3.0.x

Note that OPACXSLTResultsDisplay and OPACXSLTDetailsDisplay
are boolean parameters in 3.2.x, not string parameters.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdating version number and fixing the xxx in updatedatabase ... my bad
Chris Cormack [Wed, 3 Nov 2010 17:28:24 +0000 (06:28 +1300)]
Updating version number and fixing the xxx in updatedatabase ... my bad

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5308: add foreign key constraints as well
Galen Charlton [Mon, 1 Nov 2010 12:23:35 +0000 (08:23 -0400)]
bug 5308: add foreign key constraints as well

Follows up on previous patch to require that routing
list entries be linked to subscriptions and patrons.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5308: subscriptionroutinglist more strict
Srdjan Jankovic [Fri, 15 Oct 2010 00:58:00 +0000 (13:58 +1300)]
bug 5308: subscriptionroutinglist more strict

borrowernumber and subscriptionid NOT NULL, UNIQUE(subscriptionid, borrowernumber)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 2567: let 008/15-17 and 008/24-27 be set
Galen Charlton [Mon, 25 Oct 2010 14:16:19 +0000 (10:16 -0400)]
bug 2567: let 008/15-17 and 008/24-27 be set

Fixes bug where the MARC21 008 plugin was falsely
claiming that it set the illustration and nature of
contents positions by deriving it from other fields
in the bib records.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5318: fix value of r4 rank weight
Galen Charlton [Wed, 27 Oct 2010 12:24:03 +0000 (08:24 -0400)]
bug 5318: fix value of r4 rank weight

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 4991: follow-up tweaks
Galen Charlton [Sat, 30 Oct 2010 04:40:15 +0000 (00:40 -0400)]
bug 4991: follow-up tweaks

* make some strings translatable
* display library name instead of code in add/edit
  holiday panel
* minor textual fixes to hints

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 4991, Overhaul of Calendar interface
Owen Leonard [Mon, 12 Jul 2010 20:41:28 +0000 (16:41 -0400)]
Fix for Bug 4991, Overhaul of Calendar interface

- Put hints, key, and existing holidays into right column
- Style entry form for added clarity and consistency with other
  forms in Koha
- Change the way dynamically displayed hints are shown to better
  match existing static hints in Koha's interface
- Add branch name (instead of branch code) for clarity
- Add the ability to add and edit holiday titles (previously
  only description could be edited).
- Add links to the list of existing single-day holidays and
  exceptions which opens the calendar to that month/year

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agotweak wording of merge target
Galen Charlton [Sat, 30 Oct 2010 05:13:23 +0000 (01:13 -0400)]
tweak wording of merge target

Since the merge functionality is for merging biblio
records, not items, made the language more precise.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoadd missing help file for merging records
Nicole Engard [Sat, 30 Oct 2010 05:13:22 +0000 (01:13 -0400)]
add missing help file for merging records

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5301: improve escaping of XML characters in bib output
Galen Charlton [Wed, 27 Oct 2010 12:24:04 +0000 (08:24 -0400)]
bug 5301: improve escaping of XML characters in bib output

<, >, ', or " in an item call number will no longer make
the bib displays break when using XSLT mode.

Added a new routine to C4::Koha, xml_escape(), to implement
converting &, <, >, ', and " to their corresponding
entities.

Patch loosely based on work done by Daniel Latrémolière <daniel.latremoliere@bulac.fr>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5243: avoid crash when saving authority records on certain setups
Galen Charlton [Thu, 28 Oct 2010 12:09:47 +0000 (08:09 -0400)]
bug 5243: avoid crash when saving authority records on certain setups

This does not seem to occur on all platforms - C4::Search
exports SimpleSearch() by default - but adding the 'C4::Search::'
qualifier certainly doesn't hurt things.

Patch by Fridolyn Somers <fridolyn.somers@gmail.com>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5162: follow-up patch to not clear hidden input setting attribute type
Galen Charlton [Fri, 29 Oct 2010 11:40:37 +0000 (07:40 -0400)]
bug 5162: follow-up patch to not clear hidden input setting attribute type

Otherwise, can't saved new attributes set from a cloned
input or select control.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5162, patron attributes 'new' link should create blank value
Owen Leonard [Fri, 29 Oct 2010 11:40:36 +0000 (07:40 -0400)]
Fix for Bug 5162, patron attributes 'new' link should create blank value

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoEnhancement 5074 (Adding possibility to cleanup_database.pl to purge only older sessi...
Marcel de Rooy [Thu, 28 Oct 2010 13:05:20 +0000 (09:05 -0400)]
Enhancement 5074 (Adding possibility to cleanup_database.pl to purge only older sessions) [UPDATED for master]

Currently, the misc/cronjobs script cleanup_database truncates the session table (deleting all records, including active sessions).
With an additional parameter sessdays, this behavior could be changed or (perhaps better) extended. If the parameter sessdays is passed along with a number of days, the script only deletes older session records. This is accomplished by examining the values of lasttime, atime or ctime in the record.
So, calling the script like:
  ./cleanup_database.pl -v -sessions -sessdays 7
will only delete sessions records older than 7 days. The "old style" call
  ./cleanup_database.pl -v -sessions
still works too and truncates the table as before.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5050 move language prefs to I18N/L10N tab
Nicole Engard [Thu, 28 Oct 2010 15:53:51 +0000 (11:53 -0400)]
bug 5050 move language prefs to I18N/L10N tab

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5151 removed bolded terms in breadcrumbs
Nicole Engard [Thu, 28 Oct 2010 15:42:12 +0000 (11:42 -0400)]
bug 5151 removed bolded terms in breadcrumbs

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5237: Testing renewals on patron barcodes with + signs at the end
Liz Rea [Thu, 28 Oct 2010 14:00:03 +0000 (10:00 -0400)]
bug 5237: Testing renewals on patron barcodes with + signs at the end

According to notes in bug, patch was originally by Chris Cormack.

Signed-off-by: Liz Rea <lrea@nekls.org>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5163 change title of holds to pull page
Nicole Engard [Thu, 28 Oct 2010 13:52:47 +0000 (09:52 -0400)]
bug 5163 change title of holds to pull page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5258 change 'order' to 'order line' on receive page
Nicole Engard [Thu, 28 Oct 2010 13:45:04 +0000 (09:45 -0400)]
bug 5258 change 'order' to 'order line' on receive page

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5224 Remove the adjective Shopping from basket
Colin Campbell [Thu, 28 Oct 2010 13:39:09 +0000 (09:39 -0400)]
Bug 5224 Remove the adjective Shopping from basket

New orders breadcrumbs were using the inappropriate term
Shopping basket whereas basket is used elsewhere

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBUG 5239 add space between number and words in acq search
Nicole Engard [Thu, 28 Oct 2010 13:35:15 +0000 (09:35 -0400)]
BUG 5239 add space between number and words in acq search

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5221 - Preselect tab containing itemtype/authval image in use
Owen Leonard [Thu, 28 Oct 2010 13:29:23 +0000 (09:29 -0400)]
Fix for Bug 5221 - Preselect tab containing itemtype/authval image in use

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5236 - "hide my tags" link does nothing
Owen Leonard [Thu, 28 Oct 2010 13:23:11 +0000 (09:23 -0400)]
Fix for Bug 5236 - "hide my tags" link does nothing

Removing the link. The suggested functionality doesn't
seem useful.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoremove unused template include
Galen Charlton [Wed, 27 Oct 2010 11:48:22 +0000 (07:48 -0400)]
remove unused template include

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 5223, 'related subjects' should read 'subjects'
Owen Leonard [Tue, 26 Oct 2010 13:28:50 +0000 (09:28 -0400)]
Fix for Bug 5223, 'related subjects' should read 'subjects'

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoFix for Bug 4261 - keyword mapping should show which framework the map is for
Owen Leonard [Tue, 26 Oct 2010 13:00:51 +0000 (09:00 -0400)]
Fix for Bug 4261 - keyword mapping should show which framework the map is for

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agohistory updates - recent releases
Galen Charlton [Mon, 1 Nov 2010 02:35:12 +0000 (22:35 -0400)]
history updates - recent releases

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5327: follow-up to fix SIP tests
Galen Charlton [Sun, 31 Oct 2010 22:25:47 +0000 (18:25 -0400)]
bug 5327: follow-up to fix SIP tests

* removed t/SIP_SIPServer.t - despite the file name,
  C4/SIP/SIPserver.pm is not actually a module and
  cannot be 'used' or 'required'
* set module search path so that t/SIP_ILS.t and
  t/SIP_Sip.t will pass

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5327: More basic unit tests for C4 modules
Katrin Fischer [Sun, 31 Oct 2010 22:25:46 +0000 (18:25 -0400)]
Bug 5327: More basic unit tests for C4 modules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoHistory updates
Chris Cormack [Sun, 31 Oct 2010 22:25:21 +0000 (18:25 -0400)]
History updates

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoremove extraneous semicolon
Galen Charlton [Sun, 31 Oct 2010 04:46:39 +0000 (00:46 -0400)]
remove extraneous semicolon

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoUpdated links in Main Page Help
Brian Engard [Sun, 31 Oct 2010 04:46:38 +0000 (00:46 -0400)]
Updated links in Main Page Help

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5327: Add unit test for ItemType.pm
Nate Curulla [Sun, 31 Oct 2010 09:15:22 +0000 (05:15 -0400)]
Bug 5327: Add unit test for ItemType.pm

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agounit test stub for Z3950.pm
Daniel Grobani [Sat, 30 Oct 2010 02:44:27 +0000 (22:44 -0400)]
unit test stub for Z3950.pm

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoCreate Unit Test for ImportBatch
Brian Engard [Sat, 30 Oct 2010 03:39:26 +0000 (23:39 -0400)]
Create Unit Test for ImportBatch

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 5146: patron import files require header row
Galen Charlton [Thu, 28 Oct 2010 11:57:32 +0000 (07:57 -0400)]
bug 5146: patron import files require header row

Fixed help text on this point as well as options for
supplying dates in the input file.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5327: Add basic unit tests to some C4 modules
Magnus Enger [Sat, 30 Oct 2010 04:42:59 +0000 (00:42 -0400)]
Bug 5327: Add basic unit tests to some C4 modules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5327: Add basic unit tests to some C4 modules
Katrin Fischer [Sat, 30 Oct 2010 03:53:45 +0000 (23:53 -0400)]
Bug 5327: Add basic unit tests to some C4 modules

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agocreate unit test files
Nicole Engard [Sat, 30 Oct 2010 03:41:25 +0000 (23:41 -0400)]
create unit test files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoAdding a simple test for Service.pm
Liz Rea [Sat, 30 Oct 2010 02:44:26 +0000 (22:44 -0400)]
Adding a simple test for Service.pm

At the advisement of the great Chris Cormack. (thanks for the lesson)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agoBug 5322 - Added pwgen dependency
Robin Sheat [Sat, 30 Oct 2010 01:23:43 +0000 (21:23 -0400)]
Bug 5322 - Added pwgen dependency

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
13 years agobug 3211: fix some errors that crept into the cleanup
Galen Charlton [Mon, 25 Oct 2010 15:04:46 +0000 (11:04 -0400)]
bug 3211: fix some errors that crept into the cleanup

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoFurther fixes for Bug 3211, cataloging value plugin forms should be valid XHTML
Owen Leonard [Mon, 26 Jul 2010 16:35:56 +0000 (12:35 -0400)]
Further fixes for Bug 3211, cataloging value plugin forms should be valid XHTML

- Adding page heading
- Adding "Cancel" link to close popup
- Correctly marking up <label> <input> pairs
- Correctly escaping JavaScript blocks
- General markup corrections

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 5128: fix syntax errors in previous patch
Galen Charlton [Fri, 22 Oct 2010 12:19:45 +0000 (08:19 -0400)]
bug 5128: fix syntax errors in previous patch

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoupdate AUTHOR in Makefile.PL
Galen Charlton [Fri, 22 Oct 2010 06:07:22 +0000 (02:07 -0400)]
update AUTHOR in Makefile.PL

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoDB revision 3.02.00.004 - general release of Koha 3.2.0
Galen Charlton [Fri, 22 Oct 2010 05:46:44 +0000 (01:46 -0400)]
DB revision 3.02.00.004 - general release of Koha 3.2.0

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoRelease notes for Koha 3.2.0
Galen Charlton [Fri, 22 Oct 2010 05:45:28 +0000 (01:45 -0400)]
Release notes for Koha 3.2.0

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agostandardize name of ILS-DI:AuthorizedIPs syspref
Galen Charlton [Fri, 22 Oct 2010 04:17:18 +0000 (00:17 -0400)]
standardize name of ILS-DI:AuthorizedIPs syspref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoupdated to installation instructions
Galen Charlton [Fri, 22 Oct 2010 03:40:08 +0000 (23:40 -0400)]
updated to installation instructions

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3597: DelItemCheck now refuses to delete items in transit for holds
Galen Charlton [Fri, 22 Oct 2010 03:01:34 +0000 (23:01 -0400)]
bug 3597: DelItemCheck now refuses to delete items in transit for holds

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3597: "delete all items" no longer deletes checked out or waiting items
Galen Charlton [Fri, 22 Oct 2010 02:56:04 +0000 (22:56 -0400)]
bug 3597: "delete all items" no longer deletes  checked out or waiting items

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 5128: leave record.abs to French defaults
Galen Charlton [Fri, 22 Oct 2010 02:42:27 +0000 (22:42 -0400)]
bug 5128: leave record.abs to French defaults

Compromise so that the majority of the English UNIMARC
framework can be accepted into 3.2.

Non-French UNIMARC users should observe the comment
at the bottom of record.abs.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 5128 [3.2] Unimarc default for holdings. Written with French default
Zeno Tajoli [Fri, 8 Oct 2010 15:54:56 +0000 (17:54 +0200)]
Bug 5128 [3.2] Unimarc default for holdings. Written with French default

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 4972 Fix table creations failing due to foreign key checks
Colin Campbell [Thu, 8 Jul 2010 15:19:17 +0000 (16:19 +0100)]
Bug 4972 Fix table creations failing due to foreign key checks

create tables were failing with cryptic 1005 error from mysql
wrapped creation of aqbasketgroups and aqcontract in
FOREIGN_KEY_CHECKS=0 and FOREIGN_KEY_CHECKS=1

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3881: remove unused OpacPrivacy syspref
Galen Charlton [Fri, 22 Oct 2010 02:17:15 +0000 (22:17 -0400)]
bug 3881: remove unused OpacPrivacy syspref

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agofixing various links to point to *.koha-community.org
Galen Charlton [Fri, 22 Oct 2010 02:08:24 +0000 (22:08 -0400)]
fixing various links to point to *.koha-community.org

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3756: remove disused system preference from database
Galen Charlton [Fri, 22 Oct 2010 01:50:27 +0000 (21:50 -0400)]
bug 3756: remove disused system preference from database

This leaves a few system preferences displayed on the
local use tab in the syspref editor that should be displayed
elsewhere, but all of the ones left are actually in use.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoUpdate changelog and build script in preperation for 3.2.0 release
Robin Sheat [Fri, 22 Oct 2010 00:28:24 +0000 (13:28 +1300)]
Update changelog and build script in preperation for 3.2.0 release

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 4176: remove references to unimplemented system preference MIME
Galen Charlton [Fri, 22 Oct 2010 01:36:45 +0000 (21:36 -0400)]
bug 4176: remove references to unimplemented system preference MIME

The intended functionality of this system preference was never
implemented.  To avoid template changes prior to 3.2.0, put in
hard-coded string 'CSV' to (accurately) identify the type of
the output files in the affected reports.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3756: remove more references to disused sysprefs
Galen Charlton [Fri, 22 Oct 2010 01:21:21 +0000 (21:21 -0400)]
bug 3756: remove more references to disused sysprefs

OPACSubscriptionDisplay
OPACDisplayExtendedSubInfo
OAI-PMH:Set
OAI-PMH:Subset
ILS-DI:AuthorizedIPs
libraryAddress
kohaspsuggest
OrderPdfTemplate
marc
acquisitions

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoremove last vestiges of NOTMARC mode
Galen Charlton [Fri, 22 Oct 2010 01:06:52 +0000 (21:06 -0400)]
remove last vestiges of NOTMARC mode

MARC, the metadata exchange format for the 20th century!

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3756: start removing references to disused sysprefs
Galen Charlton [Fri, 22 Oct 2010 00:35:35 +0000 (20:35 -0400)]
bug 3756: start removing references to disused sysprefs

holdCancelLength
PINESISBN
sortbynonfiling
TemplateEncoding

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoremove two disused functions
Galen Charlton [Fri, 22 Oct 2010 00:31:13 +0000 (20:31 -0400)]
remove two disused functions

html2marc and html2marcxml are not used, and html2marcxml
is the last user of the dead syspref TemplateEncoding

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoremove a couple duplicate lines
Galen Charlton [Fri, 22 Oct 2010 00:14:17 +0000 (20:14 -0400)]
remove a couple duplicate lines

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years ago(bug 3536) fix homeorholdingbranch on return
Henri-Damien LAURENT [Thu, 9 Sep 2010 18:54:12 +0000 (14:54 -0400)]
(bug 3536) fix homeorholdingbranch on return

this patch create a new systempreference "homeorholdingbranch"-like used only for returns.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
An additional edit was made to circ/returns.pl by Ian Walls of ByWater Solutions to force the dialog message for the return to
use the branch specified by the new HomeOrHoldingBranchReturn system preference, rather than always Homebranch.
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 5303 Overdue notices subject is improperly encoded
Frédéric Demians [Wed, 13 Oct 2010 19:43:55 +0000 (21:43 +0200)]
Bug 5303 Overdue notices subject is improperly encoded

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoFixing a double count of a developer and adding a new one to the history
Chris Cormack [Thu, 21 Oct 2010 02:30:17 +0000 (15:30 +1300)]
Fixing a double count of a developer and adding a new one to the history

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 4305 - prevent errors when handling invalid ISBN13 values
Robin Sheat [Wed, 20 Oct 2010 07:13:15 +0000 (20:13 +1300)]
Bug 4305 - prevent errors when handling invalid ISBN13 values

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoMerge branch 'translation' of git://git.workbuffer.org/git/koha into to-push
Galen Charlton [Thu, 21 Oct 2010 21:25:45 +0000 (17:25 -0400)]
Merge branch 'translation' of git://git.workbuffer.org/git/koha into to-push

13 years agoTranslations
Chris Cormack [Thu, 21 Oct 2010 21:12:19 +0000 (10:12 +1300)]
Translations

13 years agoBug 4472 Fix &nbsp; handling for UNIMARC intranet XSL
Frédéric Demians [Sun, 17 Oct 2010 14:18:23 +0000 (16:18 +0200)]
Bug 4472 Fix &nbsp; handling for UNIMARC intranet XSL

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agobug 3164: fix OPAC holds in SingleBranchMode
Galen Charlton [Sun, 17 Oct 2010 17:17:06 +0000 (13:17 -0400)]
bug 3164: fix OPAC holds in SingleBranchMode

Account for case where no branch is explicitly supplied.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoAdd one new speech, bugfix a few other history lines
MJ Ray [Thu, 14 Oct 2010 16:45:37 +0000 (17:45 +0100)]
Add one new speech, bugfix a few other history lines

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years ago(MT #3697) Fixed GetAuthorityRecords
Jean-André Santoni [Wed, 26 May 2010 07:33:26 +0000 (09:33 +0200)]
(MT #3697) Fixed GetAuthorityRecords

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years ago[MT3696] Fixed ILSDI GetAvailability call
Jean-André Santoni [Wed, 26 May 2010 07:20:43 +0000 (09:20 +0200)]
[MT3696] Fixed ILSDI GetAvailability call
(cherry picked from commit 96552d64727dc6fc2525cc9c0c6ece0c718b999d)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years ago(MT #3698) Fixed ILSDI GetRecords
Jean-André Santoni [Wed, 26 May 2010 07:43:58 +0000 (09:43 +0200)]
(MT #3698) Fixed ILSDI GetRecords
(cherry picked from commit f69061357a75a5e024fe6379a1a48f8755a2b6db)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoremove scratch files from the it-IT SQL files
Galen Charlton [Tue, 12 Oct 2010 20:30:22 +0000 (16:30 -0400)]
remove scratch files from the it-IT SQL files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoadd new lenny dependency libmodule-install-perl to the apt-get-debian-lenny.sh script
Liz Rea [Tue, 12 Oct 2010 14:19:17 +0000 (09:19 -0500)]
add new lenny dependency libmodule-install-perl to the apt-get-debian-lenny.sh script

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoadd Italian installer SQL to test cases
Galen Charlton [Tue, 12 Oct 2010 14:18:46 +0000 (10:18 -0400)]
add Italian installer SQL to test cases

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoItalian installer SQL
Galen Charlton [Tue, 12 Oct 2010 14:18:11 +0000 (10:18 -0400)]
Italian installer SQL

Created by Zeno Tajoli <tajoli@cilea.it>.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agofix step to install Indexdata apt key
Galen Charlton [Tue, 12 Oct 2010 12:48:50 +0000 (08:48 -0400)]
fix step to install Indexdata apt key

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoUpdates to INSTALL.debian documentation for 3.2.
Liz Rea [Mon, 11 Oct 2010 20:31:10 +0000 (16:31 -0400)]
Updates to INSTALL.debian documentation for 3.2.

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoAdding a temporary workaround to keep template tests from borking on very large templates
Chris Nighswonger [Thu, 7 Oct 2010 03:31:57 +0000 (23:31 -0400)]
Adding a temporary workaround to keep template tests from borking on very large templates

NOTE: This should be properly fixed at some point in 3.4

This may help:

http://www.perlmonks.org/?node_id=150748

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agoBug 5288 - Update package dependencies, control source details
Robin Sheat [Thu, 7 Oct 2010 02:57:52 +0000 (15:57 +1300)]
Bug 5288 - Update package dependencies, control source details

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
13 years agomark 3.2.0 release candidate - DBrev 3.01.00.999
Galen Charlton [Thu, 7 Oct 2010 01:26:58 +0000 (21:26 -0400)]
mark 3.2.0 release candidate - DBrev 3.01.00.999

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>