koha.git
15 years agobug: bookcount.pl pulls wrong title. Problem is sql joins on wrong columns
Michael Hafen [Fri, 22 Aug 2008 17:12:47 +0000 (11:12 -0600)]
bug: bookcount.pl pulls wrong title. Problem is sql joins on wrong columns

the sql seems to assume that biblionumber and biblioitemnumber are always the same, which in my case they aren't.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 2424: Altering layout of advanced search screen to make it compatible...
Owen Leonard [Wed, 30 Jul 2008 13:24:20 +0000 (08:24 -0500)]
Fix for Bug 2424: Altering layout of advanced search screen to make it compatible with Internet Explorer 6. Documentarians: this will require an updated screenshot.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 2548, "Links to Reports that No Longer Exist in Side Menu." Some links...
Owen Leonard [Mon, 25 Aug 2008 16:14:27 +0000 (11:14 -0500)]
Fix for Bug 2548, "Links to Reports that No Longer Exist in Side Menu." Some links were left behind after removal from reports-home.tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSpelling correction. Fixes Bug 2501.
Owen Leonard [Mon, 25 Aug 2008 16:14:45 +0000 (11:14 -0500)]
Spelling correction. Fixes Bug 2501.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2545: fix XSLTDetailsDisplay
Galen Charlton [Fri, 22 Aug 2008 00:59:45 +0000 (19:59 -0500)]
bug 2545: fix XSLTDetailsDisplay

Corrected so that when XSLTDetailsDisplay is ON but
XSLTResultsDisplay is OFF, the portion of the OPAC bib
details page that's derived from the MARC bib record
is no longer missing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix itemtype image problem in moremember.pl
Jesse Weaver [Fri, 22 Aug 2008 15:54:31 +0000 (10:54 -0500)]
Fix itemtype image problem in moremember.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2509: fix file permissions
Galen Charlton [Thu, 21 Aug 2008 21:39:45 +0000 (16:39 -0500)]
bug 2509: fix file permissions

Following suggestion by Vincent Danjean for Debian
packaging, 0755 -> 0644 for non-executable
files.

Also removed shebang from a few modules in C4.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2540: allow download of report
Galen Charlton [Thu, 21 Aug 2008 15:48:31 +0000 (10:48 -0500)]
bug 2540: allow download of report

$error return C4::Reports::execute_query is
always defined.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for bug 1101: Renew All for the OPAC
Jesse Weaver [Thu, 21 Aug 2008 16:52:11 +0000 (11:52 -0500)]
fix for bug 1101: Renew All for the OPAC

This adds a Renew All form to the OPAC, and updates opac-renew.pl to take multiple item= parameters.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for bug 1771: Template errors with remote itemtype image
Jesse Weaver [Wed, 20 Aug 2008 18:21:50 +0000 (13:21 -0500)]
fix for bug 1771: Template errors with remote itemtype image

This adds a new function, getitemtypeimagelocation, that returns the image
unmodified for absolute urls and returns the proper intranet or opac path
otherwise. It also updates all of the relevant files to use that function.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for bug 2488: OPACItemsResultsDisplay/singlebranchmode
Jesse Weaver [Tue, 19 Aug 2008 22:11:20 +0000 (17:11 -0500)]
fix for bug 2488: OPACItemsResultsDisplay/singlebranchmode

This patch changes the template slighly so that these two system preferences do not conflict.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for minor error in shelfbrowser queries
Jesse Weaver [Tue, 19 Aug 2008 22:11:21 +0000 (17:11 -0500)]
Fix for minor error in shelfbrowser queries

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for bug 2477: Improve Speed of the Shelf Browser
Jesse Weaver [Tue, 19 Aug 2008 19:01:23 +0000 (14:01 -0500)]
fix for bug 2477: Improve Speed of the Shelf Browser

This patch updates the queries for the shelf browser in opac-detail.pl for a
slight performance gain. It also adds a param for dateformat to C4::Auth to
fix a warning.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoStill fixing permission and first line of scripts
Vincent Danjean [Fri, 15 Aug 2008 20:49:36 +0000 (22:49 +0200)]
Still fixing permission and first line of scripts

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoNo 'BOM' marker for a script file
Vincent Danjean [Fri, 15 Aug 2008 19:06:19 +0000 (21:06 +0200)]
No 'BOM' marker for a script file

'#!' must be the first characters

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoShebang line must be the first of the file
Vincent Danjean [Fri, 15 Aug 2008 19:03:04 +0000 (21:03 +0200)]
Shebang line must be the first of the file

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd support for DESTDIR
Vincent Danjean [Fri, 15 Aug 2008 18:29:55 +0000 (20:29 +0200)]
Add support for DESTDIR

Distributions (such as Debian) needs a staging area when building the package

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2503: documentation improvements in C4::Circulation
Andrew Moore [Wed, 20 Aug 2008 16:21:45 +0000 (11:21 -0500)]
bug 2503: documentation improvements in C4::Circulation

These are some documentation changes that I made to C4::Circulation as
I was writing tests for it.

moved around the docs for CanBookBeIssued. It was in the wrong spot in the file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for bug 2528: installation fails with confusing error message
Jesse Weaver [Mon, 18 Aug 2008 17:37:55 +0000 (12:37 -0500)]
fix for bug 2528: installation fails with confusing error message

This makes the dns check happen earlier, and fail humanely if there is a problem.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug #2429, bad HTML from unclosed <head>.
Joe Atzberger [Mon, 18 Aug 2008 17:11:56 +0000 (12:11 -0500)]
Bug #2429, bad HTML from unclosed <head>.

Also some cleanup of opac-showmarc script including removing bogus
dependencies (DBI, CGI methods).  Should consider using C4::XSLT if
applicable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFixing a couple of minor markup issues.
Owen Leonard [Tue, 19 Aug 2008 15:08:13 +0000 (10:08 -0500)]
Fixing a couple of minor markup issues.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2524: improving the submitted test reports
Andrew Moore [Fri, 15 Aug 2008 18:17:14 +0000 (13:17 -0500)]
Bug 2524: improving the submitted test reports

switching from 'prove' to 'perl' to run the test scripts when we're preparing
them to be submitted to smolder. Prove adds an additional summary at the end
of the test run which confuses the TAP parser in smolder. It thinks that an
additional test has been run, and it fails it.

Then, I added a '-' before the command in the Makefile. THat's so that even
if 'perl' returns a failing code (because some tess failed), the rest of the
rules are run and a report gets submitted. Othewise, only passing reports
get sent.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2525: fixing tests for misc/cronjobs/longoverdue.pl
Andrew Moore [Fri, 15 Aug 2008 16:40:05 +0000 (11:40 -0500)]
bug 2525: fixing tests for misc/cronjobs/longoverdue.pl

This patch fixes the tests so that they include the new required parameters for longoverdues.pl.

This patch also doesn't include a test script that accidently got in the last one.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2524: Adding script to submit test reports to smolder server
Andrew Moore [Fri, 15 Aug 2008 13:41:28 +0000 (08:41 -0500)]
Bug 2524: Adding script to submit test reports to smolder server

This patch adds a target in the t/Makefile and a script in t/smolder_smoke_signal
to submit the results of test runs to a smolder server. It will allow users to submit
their own test results to a central location by running "make submit" from the t/
directory.

Smolder is a web-based application that aggregates and presents the output of
tests. We have an instance running at:
http://arwen.metavore.com:8000/app/public_projects/smoke_reports/1

More information about using smolder for Koha is available at:
http://wiki.koha.org/doku.php?id=en:development:smoke_reports

I intend to have the test suite run each night automatically and the results
sent to the smolder server. This will help us keep track of the current state
of the the code and possibly catch bugs introduced by changes. I encourge others
to submit their own test results if they want, especially if they are on an unusual
platform or are with a non-standard configuration.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for bug 2155: duplicate checkin box on returns screen
Jesse Weaver [Thu, 14 Aug 2008 18:08:47 +0000 (13:08 -0500)]
Fix for bug 2155: duplicate checkin box on returns screen

This changes some css and markup to make the return box at the top not show when one is on the checkin screen. It also moves the markup for the autocompleting search box to its own file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPrevent compilation errors from complex C4 import/export.
Joe Atzberger [Thu, 14 Aug 2008 18:52:39 +0000 (13:52 -0500)]
Prevent compilation errors from complex C4 import/export.

SIP code uses UNIVERSAL modules that do not tolerate the circular deps in
C4, specifically, in Auth.pm.  Changing the order so that UNIVERSAL follows
the other imports is important to avoiding failures like:
  perl -w -e 'use UNIVERSAL qw(can); use C4::Auth;'
    "MarkIssueReturned" is not exported by the C4::Circulation module

This patch should resolve the problem earlier seen with Shelves too.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2502: correctly check patron account expiration
Galen Charlton [Thu, 14 Aug 2008 16:13:50 +0000 (11:13 -0500)]
bug 2502: correctly check patron account expiration

When placing a hold request from the staff interface,
now correctly indicate if the patron account has expired.
Prior to this patch, would warn that the account
had expired even when the expiry date is in the future,
and vice versa.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoHave zebrasrv log less
Michael Hafen [Wed, 13 Aug 2008 18:43:52 +0000 (12:43 -0600)]
Have zebrasrv log less

Better to fill the hard drive with biblio than with zebra logs ;)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agokohabug 2507 Fixing labels search to indicate keyword rather than title search
Chris Nighswonger [Wed, 13 Aug 2008 14:38:25 +0000 (09:38 -0500)]
kohabug 2507 Fixing labels search to indicate keyword rather than title search

Documentation may require an updated screen shot

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agomasthead - realign terminology for Tag Cloud
Joe Atzberger [Tue, 12 Aug 2008 20:56:28 +0000 (15:56 -0500)]
masthead - realign terminology for Tag Cloud

Tag Cloud should link to user-generated tags, in a cloud display.
What used to be called "Tag Cloud" (ISBD subject links for UNIMARC libraries)
should be called a "Subject ...".  AFAICT it doesn't currently use a "cloudy"
display, so some other term might be more appropriate.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoWorking on preconfiguring for the package
Chris Cormack [Sat, 9 Aug 2008 23:35:58 +0000 (11:35 +1200)]
Working on preconfiguring for the package

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBumping patch number, new package release
Chris Cormack [Tue, 5 Aug 2008 21:07:13 +0000 (09:07 +1200)]
Bumping patch number, new package release

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoStarting work on the postinst file
Chris Cormack [Tue, 5 Aug 2008 10:05:23 +0000 (22:05 +1200)]
Starting work on the postinst file

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMore work on packaging
Chris Cormack [Mon, 4 Aug 2008 23:05:40 +0000 (11:05 +1200)]
More work on packaging

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFixing some bugs in the package, updating dependencies
Chris Cormack [Mon, 4 Aug 2008 22:35:49 +0000 (10:35 +1200)]
Fixing some bugs in the package, updating dependencies

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBumping patch number
Chris Cormack [Mon, 4 Aug 2008 22:22:36 +0000 (10:22 +1200)]
Bumping patch number

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoStill working
Chris Cormack [Sun, 3 Aug 2008 10:12:54 +0000 (22:12 +1200)]
Still working

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoKeeping on working on the packaging
Chris Cormack [Sun, 3 Aug 2008 09:49:05 +0000 (21:49 +1200)]
Keeping on working on the packaging

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMore packaging work
Chris Cormack [Sun, 3 Aug 2008 09:26:49 +0000 (21:26 +1200)]
More packaging work

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFiles needed for packaging
Chris Cormack [Sun, 3 Aug 2008 09:20:33 +0000 (21:20 +1200)]
Files needed for packaging

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [18/18]: fixing pod syntax in C4/SIP/Sip/MsgType.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:53 +0000 (10:11 -0500)]
Bug 2400 [18/18]: fixing pod syntax in C4/SIP/Sip/MsgType.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [17/18]: fixing pod syntax in C4/SIP/ILS/Item.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:52 +0000 (10:11 -0500)]
Bug 2400 [17/18]: fixing pod syntax in C4/SIP/ILS/Item.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [16/18]: fixing pod syntax in C4/SIP/ILS/Patron.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:51 +0000 (10:11 -0500)]
Bug 2400 [16/18]: fixing pod syntax in C4/SIP/ILS/Patron.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [15/18]: fixing pod syntax in C4/External/BakerTaylor.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:50 +0000 (10:11 -0500)]
Bug 2400 [15/18]: fixing pod syntax in C4/External/BakerTaylor.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [14/18]: fixing pod syntax in C4/Barcodes/incremental.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:49 +0000 (10:11 -0500)]
Bug 2400 [14/18]: fixing pod syntax in C4/Barcodes/incremental.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [13/18]: fixing pod syntax in C4/Barcodes/hbyymincr.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:48 +0000 (10:11 -0500)]
Bug 2400 [13/18]: fixing pod syntax in C4/Barcodes/hbyymincr.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [12/18]: fixing pod syntax in C4/NewsChannels.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:47 +0000 (10:11 -0500)]
Bug 2400 [12/18]: fixing pod syntax in C4/NewsChannels.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [11/18]: fixing pod syntax in C4/Labels.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:46 +0000 (10:11 -0500)]
Bug 2400 [11/18]: fixing pod syntax in C4/Labels.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [10/18]: fixing pod syntax in C4/ImportBatch.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:45 +0000 (10:11 -0500)]
Bug 2400 [10/18]: fixing pod syntax in C4/ImportBatch.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [9/18]: fixing pod syntax in C4/Overdues.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:44 +0000 (10:11 -0500)]
Bug 2400 [9/18]: fixing pod syntax in C4/Overdues.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [8/18]: fixing pod syntax in C4/Koha.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:43 +0000 (10:11 -0500)]
Bug 2400 [8/18]: fixing pod syntax in C4/Koha.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [7/18]: fixing pod syntax in C4/Barcodes.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:42 +0000 (10:11 -0500)]
Bug 2400 [7/18]: fixing pod syntax in C4/Barcodes.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [6/18]: fixing pod syntax in C4/Serials.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:41 +0000 (10:11 -0500)]
Bug 2400 [6/18]: fixing pod syntax in C4/Serials.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [5/18]: fixing pod syntax in C4/SMS.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:40 +0000 (10:11 -0500)]
Bug 2400 [5/18]: fixing pod syntax in C4/SMS.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [4/18]: fixing pod syntax in C4/Reports.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:39 +0000 (10:11 -0500)]
Bug 2400 [4/18]: fixing pod syntax in C4/Reports.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [3/18]: fixing pod syntax in C4/Log.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:38 +0000 (10:11 -0500)]
Bug 2400 [3/18]: fixing pod syntax in C4/Log.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [2/18]: fixing pod syntax in C4/Scheduler.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:37 +0000 (10:11 -0500)]
Bug 2400 [2/18]: fixing pod syntax in C4/Scheduler.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2400 [1/18]: fixing pod syntax in C4/Acquisitions.pm
Andrew Moore [Tue, 12 Aug 2008 15:11:36 +0000 (10:11 -0500)]
Bug 2400 [1/18]: fixing pod syntax in C4/Acquisitions.pm

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoNomenclature cleanup prior to release v3.00.00
Joshua Ferraro [Sun, 10 Aug 2008 21:40:37 +0000 (16:40 -0500)]
Nomenclature cleanup prior to release

15 years agoChanging nomenclature prior to release, removing -stable
Joshua Ferraro [Sun, 10 Aug 2008 21:39:53 +0000 (16:39 -0500)]
Changing nomenclature prior to release, removing -stable

15 years agoUpdate labels formatstring parse to pick the correct item tag from MARC data.
Ryan Higgins [Sun, 10 Aug 2008 21:07:11 +0000 (16:07 -0500)]
Update labels formatstring parse to pick the correct item tag from MARC data.

This patch allows use of "952a" e.g. in labels format string, getting the item-level
data from the correct MARC tag.  Previously it just grabbed the data from the first item tag.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years agoUpdate longoverdue.pl cron job to manage setting lost values.
Ryan Higgins [Sun, 10 Aug 2008 20:42:29 +0000 (15:42 -0500)]
Update longoverdue.pl cron job to manage setting lost values.

This patch deprecates the NoReturnSetLost system preference, which, as it
turns out, was not implemented anyway.  New longoverdue script allows one to
specify on the commandline system-wide delays for changing items to different
lost statuses, and optionally charge for the item.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years agoAdding some missing folks to the About page
Joshua Ferraro [Sun, 10 Aug 2008 20:52:49 +0000 (15:52 -0500)]
Adding some missing folks to the About page

15 years agoAdding three statistics files that NPL uses, they don't
Joshua Ferraro [Sun, 10 Aug 2008 20:38:42 +0000 (15:38 -0500)]
Adding three statistics files that NPL uses, they don't
work 100% with stock 3.0 yet but are good examples of
custom scripts that libraries might want to write and
schedule periodically

15 years agoUpdates to the example crontab
Joshua Ferraro [Sun, 10 Aug 2008 20:18:48 +0000 (15:18 -0500)]
Updates to the example crontab

15 years agoRemove biblio.* from sample notice templates and
Joshua Ferraro [Sun, 10 Aug 2008 19:49:56 +0000 (14:49 -0500)]
Remove biblio.* from sample notice templates and
replace with <<items.content>>

15 years agoFix for 2492: Mail::Sendmail chokes on utf-8 [ process_message_queue.pl ]
Joshua Ferraro [Sun, 10 Aug 2008 19:42:47 +0000 (14:42 -0500)]
Fix for 2492: Mail::Sendmail chokes on utf-8 [ process_message_queue.pl ]

15 years agoUpdate fines cronjob: remove redundant scripts, remove some superfluous code in remai...
Ryan Higgins [Sun, 10 Aug 2008 12:24:03 +0000 (07:24 -0500)]
Update fines cronjob: remove redundant scripts, remove some superfluous code in remaining fines.pl.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years agoMinor update to README for RM
Joshua Ferraro [Sun, 10 Aug 2008 14:48:22 +0000 (09:48 -0500)]
Minor update to README for RM

15 years agoUpdates to the subtag registry for new translations
Joshua Ferraro [Sun, 10 Aug 2008 14:45:05 +0000 (09:45 -0500)]
Updates to the subtag registry for new translations
Updates to the RElease Manager's notes
Fix Danish langauge from dk to da

15 years agoTranslation updates prior to 3.0-stable release
Joshua Ferraro [Sun, 10 Aug 2008 13:24:00 +0000 (08:24 -0500)]
Translation updates prior to 3.0-stable release

15 years agoReverting an earlier change to overdue.pl (still broken) and
Joshua Ferraro [Sun, 10 Aug 2008 11:45:50 +0000 (06:45 -0500)]
Reverting an earlier change to overdue.pl (still broken) and
fixing a translation problem with borrowers_stats.ptmpl:

xgettext.pl: Warning: borrowers_stats.tmpl: line 28: SGML "closed start tag" notation: <p<!-- TMPL_IF NAME="debug"--> class="debug"<

15 years agoRelease Notes for 3.0-stable
Joshua Ferraro [Sun, 10 Aug 2008 11:44:43 +0000 (06:44 -0500)]
Release Notes for 3.0-stable

15 years agoFinal cleanup of labels for 3.0
Ryan Higgins [Sun, 10 Aug 2008 10:25:55 +0000 (05:25 -0500)]
Final cleanup of labels for 3.0

This patch adds the callnum_split and text_justify options to the templates,
fixes bad javascript to switch between 'formatstring' and fixed-field means of specifying labels content,
fixes csv output when fixed-fields specifiers are used, and adds some help text for the formatstring case.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years agofix for 2382: Self Checkout Won't Work for Staff with Circ
Joshua Ferraro [Sun, 10 Aug 2008 00:47:34 +0000 (19:47 -0500)]
fix for 2382: Self Checkout Won't Work for Staff with Circ

15 years agoPrevent borrower import from overwriting data that it shouldn't, and polish off a...
Ryan Higgins [Sat, 9 Aug 2008 20:27:27 +0000 (15:27 -0500)]
Prevent borrower import from overwriting data that it shouldn't, and polish off a couple error conditions.

When an imported patron matches an existing one, keep data in the original record unless our import file
includes that column.  Also, check for branch & categorycodes, and produce error if invalid.  Finally,
auto-calculate expiry date if not given.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years agokohabug 2475 [3/?] Adding splitting algorithm for fiction call numbers
Chris Nighswonger [Sat, 9 Aug 2008 18:03:01 +0000 (13:03 -0500)]
kohabug 2475 [3/?] Adding splitting algorithm for fiction call numbers

This patch also looks for the call number type in items.cn_source and if
that is NULL, falls back to the DefaultClassificationSource syspref.

Splitting algorithms need to be written for other known/supported call
number systems (ie. sudocs, udc, generic, etc.)

Documentation Notes:

For now, if a call number falls through the regex checking for formal lccn or ddcn,
it is passed through the regex for a fiction call number; if it falls through that,
it is returned unsplit.

If a call number does not split, please update enhancement request 2500 with the
requested information.

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2500

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years ago2433: Cannot apply manual credits with an item number
Joshua Ferraro [Sat, 9 Aug 2008 17:56:04 +0000 (12:56 -0500)]
2433: Cannot apply manual credits with an item number

This patch changes the behavior so that you can enter in
a barcode instead of an itemnumber for the manual credit
and invoice screens. Also, the borrower's account page now
displays a link back to the item record if an item was
linked to the charge

15 years ago2487: Collection code select boxes in Adv search show both code and description
Joshua Ferraro [Sat, 9 Aug 2008 17:06:04 +0000 (12:06 -0500)]
2487: Collection code select boxes in Adv search show both code and description

15 years agocommented out unconditional warns
Galen Charlton [Sat, 9 Aug 2008 15:53:15 +0000 (10:53 -0500)]
commented out unconditional warns

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years agoBug fix : use delete_field/insert_grouped_field rather than replace_with
Henri-Damien LAURENT [Sat, 9 Aug 2008 15:53:14 +0000 (10:53 -0500)]
Bug fix : use delete_field/insert_grouped_field rather than replace_with

replace_with maight have unexpected behaviour.
Has to test merge_authority.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years agoBug Fixing merge_authority.pl
Henri-Damien LAURENT [Sat, 9 Aug 2008 15:53:13 +0000 (10:53 -0500)]
Bug Fixing merge_authority.pl

merge works on the fly now.
But for an obscure reason, merge_authority.pl fails to update database when lanched on command line.
Adding one table to LOCK for noZebra UPDATE in Biblio.pm
You should remove C4::Search from merg_authority.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years ago2482: Default Letter on Notice Triggers Causes Error
Joshua Ferraro [Sat, 9 Aug 2008 13:08:11 +0000 (08:08 -0500)]
2482: Default Letter on Notice Triggers Causes Error

Changing 'Default' to 'No notice' as per solution
suggested in bug report

15 years agokohabug 2475 [2/2] Porting LCCN splitting code to Labels.pm
Chris Nighswonger [Sat, 9 Aug 2008 12:36:27 +0000 (07:36 -0500)]
kohabug 2475 [2/2] Porting LCCN splitting code to Labels.pm

This patch corrects the csv field list processing alogrithm in two areas:

1. It adjusts the regexp to handle quoted fields with embedded spaces.
2. It adds descrimination for individual 952 subfields.

Documentation needs to be written for the label layout editor.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years agokohabug 2463 & 2464 Removing unlinked fields from label-edit-layout.pl
Chris Nighswonger [Sat, 9 Aug 2008 12:36:26 +0000 (07:36 -0500)]
kohabug 2463 & 2464 Removing unlinked fields from label-edit-layout.pl

This patch removes unlinked fields from the 'Choose Order Of Text Fields to Print'
option on label-edit-layout.pl

It also adds code to make the 'Itemtype' field respect the item-level_itypes syspref.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years agokohabug 2475 [1/2] Porting LCCN splitting code to Labels.pm
Chris Nighswonger [Sat, 9 Aug 2008 12:36:25 +0000 (07:36 -0500)]
kohabug 2475 [1/2] Porting LCCN splitting code to Labels.pm

This patch ports LCCN splitting code from Koha 2.2.9 to Koha 3.0
This algorithm has been ported just as it appears on some production
systems. LCCNs that do not split correctly should have a bug opened
and include an exact example so that the regexp's can be adjusted.

This patch also adds code to split DDCNs using the *loosest* possible
interpretation of DDCN rules. On the simple end, the DDCN split
algorithm will handle being passed just a Dewey call number.
However, there may be some unusually complex DDCNs that will not
split properly. These will need to have a bug submitted for them
including a specific example so that the regexp's can be adjusted.

The correct choice of splitting alogrithm is determimed by the
item level classification source (items.cn_source).

Documentation should be updated to reflect these changes. Please include
the bit about complex call numbers and the need of a bug report.

[LL Bug 26]

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years agoBug 2410: Can't use string ("0") as an ARRAY ref while "strict refs" in use at detail...
Joshua Ferraro [Sat, 9 Aug 2008 13:01:14 +0000 (08:01 -0500)]
Bug 2410: Can't use string ("0") as an ARRAY ref while "strict refs" in use at detail.pl line 219

Thanks to HDL for your patch, I couldn't get it to apply so I did it manually

No change to documentation

15 years ago2425: Spelling Error - Permissions
Joshua Ferraro [Sat, 9 Aug 2008 12:45:35 +0000 (07:45 -0500)]
2425: Spelling Error - Permissions

15 years agoUpdates to the installation instructions
Joshua Ferraro [Sat, 9 Aug 2008 12:03:37 +0000 (07:03 -0500)]
Updates to the installation instructions

In particular, removing references to the zebraqueue daemon
and replacing with mention of the -z option with rebuild_zebra.pl

15 years agoTemporary fix for bug 2483: t/Barcodes.t has database dependent tests in it
Joshua Ferraro [Sat, 9 Aug 2008 11:49:21 +0000 (06:49 -0500)]
Temporary fix for bug 2483: t/Barcodes.t has database dependent tests in it

Moving Barcodes.t to db_dependent to avoid failure of make test

15 years agoResolves problem where duplicate blank barcodes threw errors
Joshua Ferraro [Fri, 8 Aug 2008 20:15:23 +0000 (15:15 -0500)]
Resolves problem where duplicate blank barcodes threw errors
form now only checks for duplication when the barcode is non-empty

15 years agofix for #2440 : acquisition recieve & item creation
Paul POULAIN [Thu, 31 Jul 2008 12:19:51 +0000 (14:19 +0200)]
fix for #2440 : acquisition recieve & item creation

It has to be reintroduced, as some (most in France) libraries don't create
items on recieve, but after "equipment" step.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years agobug 2496: add 'edit' link to authority search results
Galen Charlton [Fri, 8 Aug 2008 19:22:59 +0000 (14:22 -0500)]
bug 2496: add 'edit' link to authority search results

When search for an authority record from the bib
record editor, a new link is added to each
authority result to edit the authority record.  This
allows a cataloger to do the following:

1. Start editing a bib record
2. Click on the '...' to select an authorized heading
   for an authority-controlled field.
3. Look at the results in the pop-up window and
   see that an authority record needs correction.
4. Click on the 'edit authority' link.  This allows
   the authority to be revised.  Note that this
   takes place in the popup window, not the originally
   bib editing window.
5. Save the authority record, then close the popup
   window and redo the heading search.

For various reasons, this not a perfect workflow; this
patch is designed to satisfy an immediate requirement
but needs to be reworked in 3.2.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years agoRemove <br /> from syspref descriptions.
Joe Atzberger [Thu, 7 Aug 2008 16:02:19 +0000 (11:02 -0500)]
Remove <br /> from syspref descriptions.

The template HTML-escapes the descriptions now (as it should).
So we can't make them prettier w/ HTML inserted.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years agoLink correction (affected only non-js users).
Owen Leonard [Fri, 8 Aug 2008 18:21:06 +0000 (13:21 -0500)]
Link correction (affected only non-js users).

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years agoAdd help text indicating that one should not use stopwords with Zebra.
Ryan Higgins [Fri, 8 Aug 2008 17:28:48 +0000 (12:28 -0500)]
Add help text indicating that one should not use stopwords with Zebra.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years agoPartial fix for 2446: single word queries that were stopwords
Joshua Ferraro [Fri, 8 Aug 2008 19:09:52 +0000 (14:09 -0500)]
Partial fix for 2446: single word queries that were stopwords
weren't being striped out of the query

15 years agoFix to prevent crash on null dateexpiry.
Joe Atzberger [Fri, 8 Aug 2008 17:15:10 +0000 (12:15 -0500)]
Fix to prevent crash on null dateexpiry.

Error was:
    Usage: Date::Calc::Date_to_Days(year, month, day)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years agoAdding "New Item" menu option. Jumps to anchor for Add Item form.
Owen Leonard [Fri, 8 Aug 2008 16:06:47 +0000 (11:06 -0500)]
Adding "New Item" menu option. Jumps to anchor for Add Item form.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
15 years agoChanging tabindex="-1" to tabindex="0". Fixes 2493.
Owen Leonard [Fri, 8 Aug 2008 14:43:44 +0000 (09:43 -0500)]
Changing tabindex="-1" to tabindex="0". Fixes 2493.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>