From 0bb46e1d57c8460d3cfd77bddbe0bdfee5d5905f Mon Sep 17 00:00:00 2001 From: Joshua Ferraro Date: Thu, 24 Jul 2008 16:23:33 -0500 Subject: [PATCH] Fix for bug 2398: Source of Classification - Add item or Edit item in staff client is defaulting to the ASNCR code instead of the blank above For some reason the loop used to build the list of values was setting the first value to the $value variable if $value wasn't set already, and the default_value was inside rather than outside the loop. I've removed the setting inside the loop and placed the default value outide the loop. It's possible I just don't understand what the original intention was. --- cataloguing/additem.pl | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl index da09dd091e..4c9ecfc462 100755 --- a/cataloguing/additem.pl +++ b/cataloguing/additem.pl @@ -371,10 +371,9 @@ foreach my $tag (sort keys %{$tagslib}) { ($class_source eq $default_source); push @authorised_values, $class_source; $authorised_lib{$class_source} = $class_sources->{$class_source}->{'description'}; - $value = $class_source unless ($value); - $value = $default_source unless ($value); } - + $value = $default_source unless ($value); + #---- "true" authorised value } else { -- 2.20.1