From 24d9a112d0229be3ac1abc633d3debb36684b01d Mon Sep 17 00:00:00 2001 From: Andrew Moore Date: Fri, 15 Aug 2008 13:17:14 -0500 Subject: [PATCH] Bug 2524: improving the submitted test reports switching from 'prove' to 'perl' to run the test scripts when we're preparing them to be submitted to smolder. Prove adds an additional summary at the end of the test run which confuses the TAP parser in smolder. It thinks that an additional test has been run, and it fails it. Then, I added a '-' before the command in the Makefile. THat's so that even if 'perl' returns a failing code (because some tess failed), the rest of the rules are run and a report gets submitted. Othewise, only passing reports get sent. Signed-off-by: Galen Charlton --- t/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/Makefile b/t/Makefile index a4ff5ec0e7..a049677e26 100644 --- a/t/Makefile +++ b/t/Makefile @@ -106,6 +106,6 @@ $(SMOLDER_REPORT_TARBALL) :: $(SMOLDER_REPORT_FILENAME) $(SMOLDER_REPORT_FILENAME) :: report report :: config_file $(ZEBRA_CONF_FILES) $(SCRIPTS) - KOHA_CONF=$(TEST_CONF_FILE) PERL5LIB=$(PERL5LIB) TEST_CLASS=$(TEST_CLASS) RUN_EXPENSIVE_TESTS=$(RUN_EXPENSIVE_TESTS) \ - $(PROVE) $(PROVE_FLAGS) $(TEST_FILES) > $(SMOLDER_REPORT_FILENAME) + -KOHA_CONF=$(TEST_CONF_FILE) PERL5LIB=$(PERL5LIB) TEST_CLASS=$(TEST_CLASS) RUN_EXPENSIVE_TESTS=$(RUN_EXPENSIVE_TESTS) \ + $(PERL) $(TEST_FILES) > $(SMOLDER_REPORT_FILENAME) -- 2.20.1