From c543f1ee08ea6c2176dbdc47df0d0f6357c88713 Mon Sep 17 00:00:00 2001 From: Oleg Nesterov Date: Fri, 8 Feb 2008 04:19:07 -0800 Subject: [PATCH] wait_task_zombie: remove ->exit_state/exit_signal checks for WNOWAIT The first "p->exit_state != EXIT_ZOMBIE" check doesn't make too much sense. The exit_state was EXIT_ZOMBIE when the function was called, and another thread can change it to EXIT_DEAD right after the check. The second condition is not possible, detached non-traced threads were already filtered out by eligible_child(), we didn't drop tasklist since then. Signed-off-by: Oleg Nesterov Cc: Roland McGrath Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- kernel/exit.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/kernel/exit.c b/kernel/exit.c index dee8b4d634..42a8713b20 100644 --- a/kernel/exit.c +++ b/kernel/exit.c @@ -1196,10 +1196,6 @@ static int wait_task_zombie(struct task_struct *p, int noreap, int exit_code = p->exit_code; int why, status; - if (unlikely(p->exit_state != EXIT_ZOMBIE)) - return 0; - if (unlikely(p->exit_signal == -1 && p->ptrace == 0)) - return 0; get_task_struct(p); read_unlock(&tasklist_lock); if ((exit_code & 0x7f) == 0) { -- 2.20.1