X-Git-Url: http://git.rot13.org/?p=BackupPC.git;a=blobdiff_plain;f=lib%2FBackupPC%2FCGI%2FRestoreFile.pm;h=c828f3046f3fc638326cc210b5ecef6c0dbc078a;hp=2a726d297c7c91c20ca1d7c6b2c8ce55f0402e16;hb=f9796d809e6a7d4ed2c356f0f32f1a3d628d3d1f;hpb=16755c17628b28a58d75663d7541036344826961 diff --git a/lib/BackupPC/CGI/RestoreFile.pm b/lib/BackupPC/CGI/RestoreFile.pm index 2a726d2..c828f30 100644 --- a/lib/BackupPC/CGI/RestoreFile.pm +++ b/lib/BackupPC/CGI/RestoreFile.pm @@ -10,7 +10,7 @@ # Craig Barratt # # COPYRIGHT -# Copyright (C) 2003 Craig Barratt +# Copyright (C) 2003-2009 Craig Barratt # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -28,7 +28,7 @@ # #======================================================================== # -# Version 3.0.0, released 28 Jan 2007. +# Version 3.2.0, released 31 Jul 2010. # # See http://backuppc.sourceforge.net. # @@ -41,7 +41,7 @@ use BackupPC::CGI::Lib qw(:all); use BackupPC::FileZIO; use BackupPC::Attrib qw(:all); use BackupPC::View; -use Encode qw/from_to/; +use Encode qw/from_to decode_utf8/; sub action { @@ -157,6 +157,10 @@ sub restoreFile ErrorExit("Can't restore bad file ${EscHTML($dir)} ($num, $share)"); } my $f = BackupPC::FileZIO->open($a->{fullPath}, 0, $a->{compress}); + if ( !defined($f) ) { + my $fullPath = decode_utf8($a->{fullPath}); + ErrorExit("Unable to open file ${EscHTML($fullPath)} ($num, $share)"); + } my $data; if ( !$skipHardLink && $a->{type} == BPC_FTYPE_HARDLINK ) { # @@ -179,10 +183,11 @@ sub restoreFile my $fileName = $1 if ( $dir =~ /.*\/(.*)/ ); $fileName =~ s/"/\\"/g; - print "Content-Type: $contentType\n"; - print "Content-Transfer-Encoding: binary\n"; + print "Content-Type: $contentType\r\n"; + print "Content-Transfer-Encoding: binary\r\n"; - if ( $ENV{HTTP_USER_AGENT} =~ /\bmsie\b/i ) { + if ( $ENV{HTTP_USER_AGENT} =~ /\bmsie\b/i + && $ENV{HTTP_USER_AGENT} !~ /\bopera\b/i ) { # # Convert to cp1252 for MS IE. TODO: find a way to get IE # to accept UTF8 encoding. Firefox accepts inline encoding @@ -191,7 +196,7 @@ sub restoreFile from_to($fileName, "utf8", "cp1252") if ( $Conf{ClientCharset} ne "" ); } - print "Content-Disposition: attachment; filename=\"$fileName\"\n\n"; + print "Content-Disposition: attachment; filename=\"$fileName\"\r\n\r\n"; while ( $f->read(\$data, 1024 * 1024) > 0 ) { print STDOUT $data; }