From: Dobrica Pavlinusic Date: Mon, 7 Feb 2011 12:39:18 +0000 (+0000) Subject: LIMIT doesn't work since we don't get correct number of results X-Git-Url: http://git.rot13.org/?p=BackupPC.git;a=commitdiff_plain;h=37393374870be74815cbe9e42c1d284ff03945c7;hp=5dd40a3be1f8798659f7f84f0769d91beb159091 LIMIT doesn't work since we don't get correct number of results --- diff --git a/lib/BackupPC/Search.pm b/lib/BackupPC/Search.pm index 38837c0..ee982ff 100644 --- a/lib/BackupPC/Search.pm +++ b/lib/BackupPC/Search.pm @@ -227,24 +227,25 @@ sub getFiles($) { my $order = getSort('search', 'sql', $param->{'sort'}); + # XXX LIMIT $on_page doesn't work since we don't get correct number of results my $sql_order = qq{ ORDER BY $order - LIMIT $on_page OFFSET ? }; my $sql_results = qq{ select $sql_cols $sql_from $sql_where $sql_order }; my $sth = $dbh->prepare($sql_results); - $sth->execute( $offset ); + my $rows = $sth->execute( $offset ); my @ret; - + while (my $row = $sth->fetchrow_hashref()) { push @ret, $row; + last if $#ret + 1 >= $on_page; } $sth->finish(); - return ($sth->rows, \@ret); + return ($rows, \@ret); } sub getFilesHyperEstraier($) {