From: cbarratt Date: Sun, 12 Nov 2006 07:54:42 +0000 (+0000) Subject: Updates in preparation for 3.0.0beta2: X-Git-Tag: v3_0_0beta2~3 X-Git-Url: http://git.rot13.org/?p=BackupPC.git;a=commitdiff_plain;h=b81d2da5e16975674f011e4833337ac0fa24e0ea Updates in preparation for 3.0.0beta2: * Config Editor "Save" button is now always visible, but greyed out until there are changes to save. * Config editor allows other tabs to be selected when there is an error, which allows you to fix an error (eg: missing binary) in an exiting config file. Errors are now displayed at the top of the page in addition to next to the erroneous setting. * Fixed config.pl editor writing to solve bug with multi-line text strings ending in newline. Reported and root caused by Les Stott and Jerry Groendyke. * Fixed error recovery case in BackupPC::PoolWrite, reported by Samuel Bancal. * New directory/file/hardlink and symlink image icons from Jono Woodhouse, making directory browse more compact. * Reordered the Server navigation bar links, suggested by David Relson. * Fixed typos in init.d/src/gentoo-backuppc, configure.pl and config.pl reported by David Relson. --- diff --git a/ChangeLog b/ChangeLog index 4818cad..f6cc6e3 100644 --- a/ChangeLog +++ b/ChangeLog @@ -21,21 +21,44 @@ # Version __VERSION__, __RELEASEDATE__ #------------------------------------------------------------------------ +* Config Editor "Save" button is now always visible, but greyed out + until there are changes to save. + +* Config editor allows other tabs to be selected when there is an + error, which allows you to fix an error (eg: missing binary) in + an exiting config file. Errors are now displayed at the top of + the page in addition to next to the erroneous setting. + * configure.pl checks version of Encode.pm. Reported by Chris Stone. * Several fixes to bin/BackupPC_fixupBackupSummary from Stian Jordet. +* Fixed config.pl editor writing to solve bug with multi-line text + strings ending in newline. Reported and root caused by Les Stott + and Jerry Groendyke. + +* Fixed error recovery case in BackupPC::PoolWrite, reported by + Samuel Bancal. + * Fixed table width in backup browsing to avoid Firefox layout anomoly, provided by Jono Woodhouse. -* CSS file updates from Jono Woodhouse. Priod (v2) version is included +* CSS file updates from Jono Woodhouse. Prior (v2) version is included as BackupPC_stnd_orig.css in case people prefer the old skin. * More compact host summary, including disabled host indication, from Jono Woodhouse. +* New directory/file/hardlink and symlink image icons from Jono + Woodhouse, making directory browse more compact. + * BackupPC.pid is now world readable, suggested by Casper Thomsen. +* Reordered the Server navigation bar links, suggested by David Relson. + +* Fixed typos in init.d/src/gentoo-backuppc, configure.pl and config.pl + reported by David Relson. + #------------------------------------------------------------------------ # Version 3.0.0beta1, 30 Jul 2006 #------------------------------------------------------------------------ @@ -45,6 +68,8 @@ * Added some CGI utf8 conversions from Rodrigo Real and Vincent Fleuranceau. +* Rsync transfers now correctly handle file names with \n or \r. + * Host name is forced to lower case, to match 2.x. * Fixed LOG file naming in BackupPC_restore and BackupPC_archive. diff --git a/bin/BackupPC b/bin/BackupPC index cf70977..8e718de 100755 --- a/bin/BackupPC +++ b/bin/BackupPC @@ -47,7 +47,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/bin/BackupPC_archive b/bin/BackupPC_archive index ad10f1f..f1fb9bd 100644 --- a/bin/BackupPC_archive +++ b/bin/BackupPC_archive @@ -29,7 +29,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/bin/BackupPC_archiveHost b/bin/BackupPC_archiveHost index 84dae6a..5740914 100755 --- a/bin/BackupPC_archiveHost +++ b/bin/BackupPC_archiveHost @@ -38,7 +38,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/bin/BackupPC_attribPrint b/bin/BackupPC_attribPrint index 72ea295..08e01be 100755 --- a/bin/BackupPC_attribPrint +++ b/bin/BackupPC_attribPrint @@ -31,7 +31,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/bin/BackupPC_compressPool b/bin/BackupPC_compressPool index 83867f0..4ca8048 100755 --- a/bin/BackupPC_compressPool +++ b/bin/BackupPC_compressPool @@ -49,7 +49,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/bin/BackupPC_dump b/bin/BackupPC_dump index f47b6e3..ae8fab1 100755 --- a/bin/BackupPC_dump +++ b/bin/BackupPC_dump @@ -70,7 +70,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/bin/BackupPC_fixupBackupSummary b/bin/BackupPC_fixupBackupSummary index 671b186..502845f 100755 --- a/bin/BackupPC_fixupBackupSummary +++ b/bin/BackupPC_fixupBackupSummary @@ -30,7 +30,7 @@ # #======================================================================== # -# Version 3.0.0beta0, released 11 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/bin/BackupPC_link b/bin/BackupPC_link index be888d3..03c740e 100755 --- a/bin/BackupPC_link +++ b/bin/BackupPC_link @@ -39,7 +39,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/bin/BackupPC_nightly b/bin/BackupPC_nightly index 2639b41..366345f 100755 --- a/bin/BackupPC_nightly +++ b/bin/BackupPC_nightly @@ -55,7 +55,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/bin/BackupPC_restore b/bin/BackupPC_restore index 8af7550..773322e 100755 --- a/bin/BackupPC_restore +++ b/bin/BackupPC_restore @@ -29,7 +29,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/bin/BackupPC_sendEmail b/bin/BackupPC_sendEmail index 4b8d652..5c33fae 100755 --- a/bin/BackupPC_sendEmail +++ b/bin/BackupPC_sendEmail @@ -31,7 +31,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/bin/BackupPC_serverMesg b/bin/BackupPC_serverMesg index 332afc8..48f7c42 100755 --- a/bin/BackupPC_serverMesg +++ b/bin/BackupPC_serverMesg @@ -43,7 +43,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/bin/BackupPC_tarCreate b/bin/BackupPC_tarCreate index 4eeabfa..e0fd0fb 100755 --- a/bin/BackupPC_tarCreate +++ b/bin/BackupPC_tarCreate @@ -53,7 +53,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/bin/BackupPC_tarExtract b/bin/BackupPC_tarExtract index 2f57fe6..7988a14 100755 --- a/bin/BackupPC_tarExtract +++ b/bin/BackupPC_tarExtract @@ -27,7 +27,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/bin/BackupPC_tarPCCopy b/bin/BackupPC_tarPCCopy index e9477a8..c703528 100755 --- a/bin/BackupPC_tarPCCopy +++ b/bin/BackupPC_tarPCCopy @@ -36,7 +36,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/bin/BackupPC_trashClean b/bin/BackupPC_trashClean index d5a58d4..3f7637e 100755 --- a/bin/BackupPC_trashClean +++ b/bin/BackupPC_trashClean @@ -29,7 +29,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/bin/BackupPC_zcat b/bin/BackupPC_zcat index 59dff2a..f3f99b8 100755 --- a/bin/BackupPC_zcat +++ b/bin/BackupPC_zcat @@ -32,7 +32,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/bin/BackupPC_zipCreate b/bin/BackupPC_zipCreate index 46731d8..93bf95b 100755 --- a/bin/BackupPC_zipCreate +++ b/bin/BackupPC_zipCreate @@ -52,7 +52,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/conf/BackupPC_stnd.css b/conf/BackupPC_stnd.css index 0d0e681..a50bcab 100644 --- a/conf/BackupPC_stnd.css +++ b/conf/BackupPC_stnd.css @@ -1,7 +1,7 @@ /* * BackupPC standard CSS definitions * - * Version 3.0.0beta1, released 30 Jul 2006. + * Version 3.0.0beta2, released 31 Oct 2006. * * See http://backuppc.sourceforge.net. * @@ -24,7 +24,7 @@ body { table { border-collapse: collapse; color: #000000; - padding:0px; + padding: 2px; } h1 { @@ -129,7 +129,7 @@ a.navbar { } .editSaveButton { - color:#ff0000; + color:#c0c0c0; font-size:14pt; font-weight:bold; } @@ -156,8 +156,9 @@ a.navbar { } .fviewborder { + border-left:1px solid #666666; border-bottom:1px solid #000000; - border-left:1px dotted #666666; + border-right:1px solid #666666; background-color:#eeeeee; font-size:9pt; } @@ -187,13 +188,14 @@ a.navbar { .histView { border-bottom:1px solid #000000; - border-left:2px solid #ffffff; + border-left:1px solid #000000; background-color:#eeeeee; font-size:10pt; } .histViewMis { border-bottom:1px solid #000000; + border-left:1px solid #000000; background-color:#ffdddd; } @@ -224,8 +226,9 @@ div.NavTitle { #Content { float:right; - width:80%; + width:79%; left:20%; top:10px; + right:10px; position:absolute; } diff --git a/conf/config.pl b/conf/config.pl index af66a76..069dd66 100644 --- a/conf/config.pl +++ b/conf/config.pl @@ -1181,7 +1181,7 @@ $Conf{RsyncdAuthRequired} = 1; # # When rsync checksum caching is enabled (by adding the # --checksum-seed=32761 option to $Conf{RsyncArgs}), the cached -# checksums can be occaisonally verified to make sure the file +# checksums can be occasionally verified to make sure the file # contents matches the cached checksums. This is to avoid the # risk that disk problems might cause the pool file contents to # get corrupted, but the cached checksums would make BackupPC @@ -1231,9 +1231,11 @@ $Conf{RsyncArgs} = [ '--recursive', # - # If you are using a patched client rsync that supports the - # --checksum-seed option (see http://backuppc.sourceforge.net), - # then uncomment this to enabled rsync checksum cachcing + # Rsync >= 2.6.3 supports the --checksum-seed option + # which allows rsync checksum caching on the server. + # Uncomment this to enable rsync checksum caching if + # you have a recent client rsync version and you want + # to enable checksum caching. # #'--checksum-seed=32761', @@ -1268,9 +1270,11 @@ $Conf{RsyncRestoreArgs} = [ '--recursive', # - # If you are using a patched client rsync that supports the - # --checksum-seed option (see http://backuppc.sourceforge.net), - # then uncomment this to enabled rsync checksum cachcing + # Rsync >= 2.6.3 supports the --checksum-seed option + # which allows rsync checksum caching on the server. + # Uncomment this to enable rsync checksum caching if + # you have a recent client rsync version and you want + # to enable checksum caching. # #'--checksum-seed=32761', diff --git a/configure.pl b/configure.pl index 74a221c..7cf5149 100755 --- a/configure.pl +++ b/configure.pl @@ -356,10 +356,10 @@ while ( 1 ) { print <{type}); my $modeStr = sprintf("0%o", $a->{mode} & 07777); $iconStr = < + EOF $attrStr .= <$typeStr diff --git a/lib/BackupPC/CGI/DirHistory.pm b/lib/BackupPC/CGI/DirHistory.pm index 6fb0366..acbe73a 100644 --- a/lib/BackupPC/CGI/DirHistory.pm +++ b/lib/BackupPC/CGI/DirHistory.pm @@ -28,7 +28,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # diff --git a/lib/BackupPC/CGI/EditConfig.pm b/lib/BackupPC/CGI/EditConfig.pm index 68c77a8..df38ebd 100644 --- a/lib/BackupPC/CGI/EditConfig.pm +++ b/lib/BackupPC/CGI/EditConfig.pm @@ -28,7 +28,7 @@ # #======================================================================== # -# Version 3.0.0beta1, released 30 Jul 2006. +# Version 3.0.0beta2, released 11 Nov 2006. # # See http://backuppc.sourceforge.net. # @@ -357,14 +357,14 @@ sub action ErrorExit(eval("qq{$Lang->{Only_privileged_users_can_edit_config_files}}")); } - if ( defined($In{menu}) || $In{editAction} eq $Lang->{CfgEdit_Button_Save} ) { + if ( defined($In{menu}) || $In{saveAction} eq "Save" ) { $errors = errorCheck(); if ( %$errors ) { # # If there are errors, then go back to the same menu # - $In{editAction} = ""; - $In{newMenu} = ""; + $In{saveAction} = ""; + #$In{newMenu} = ""; } if ( (my $var = $In{overrideUncheck}) ne "" ) { # @@ -401,7 +401,7 @@ sub action $newConf = { %$mainConf, %$hostConf }; } - if ( $In{editAction} ne $Lang->{CfgEdit_Button_Save} && $In{newMenu} ne "" + if ( $In{saveAction} ne "Save" && $In{newMenu} ne "" && defined($ConfigMenu{$In{newMenu}}) ) { $menu = $In{newMenu}; } @@ -475,9 +475,15 @@ EOF $content .= eval("qq($Lang->{CfgEdit_Header_Host})"); } - my $saveDisplay = "block"; - $saveDisplay = "none" if ( !$In{modified} - || $In{editAction} eq $Lang->{CfgEdit_Button_Save} ); + my $saveStyle = ""; + my $saveColor = "#ff0000"; + + if ( $In{modified} && $In{saveAction} ne "Save" && !%$errors ) { + $saveStyle = "style=\"color:$saveColor\""; + } else { + $In{modified} = 0; + } + # # Add action and host to the URL so the nav bar link is # highlighted @@ -488,7 +494,7 @@ EOF $groupText - + @@ -498,65 +504,78 @@ EOF - + + +